PHP Switch ID error in Navigation - php

I’m working on a site and I kept getting a
Notice: Undefined index: id in file root on line 3
I know its something simple but can’t figure out where the problem lies exactly.
here is the code:
<?php
switch($_GET['id']) {
default:
include('pages/hello.php');
break;
case "testimonials":
include('pages/testimonials.php');
break;
case "faq":
include('pages/faq.php');
break;
case "raq":
include('pages/raq.php');
break;
case "contact":
include('pages/contact.php');
break;
}
?>
line 3 would be <?php switch($_GET['id']) {
any help would be greatly appreciated!

This is because in your url id=x is not always set, so when your trying to switc hthe value its not there. what you should do is like so:
<?php
$id = isset($_GET['id']) ? $_GET['id'] : ''; //This is just a short if-else
switch($id)
{
default:
include('pages/hello.php');
break;
case "testimonials":
include('pages/testimonials.php');
break;
case "faq":
include('pages/faq.php');
break;
case "raq":
include('pages/raq.php');
break;
case "contact":
include('pages/contact.php');
break;
}
?>
Basciall $id = isset($_GET['id']) ? $_GET['id'] : ''; what this says is, IF id is within the url then use that, otherwise use an empty string, the reason for the empty string is it will trigger the default: within the switch statement
this way $id will always be set to something.

Make sure that id is set and the default should go at the end:
if (!isset($_GET['id'])) {
include('pages/hello.php');
}
else{
switch($_GET['id']) {
case "testimonials": include('pages/testimonials.php'); break;
case "faq": include('pages/faq.php'); break;
case "raq": include('pages/raq.php'); break;
case "contact": include('pages/contact.php'); break;
default: include('pages/hello.php'); break;
}
}
For security reasons, make sure to sanitalize yor $_GET['id']. I would suggest you to setup an array of allowed pages and include those that are in the array. You can use in_array function for that.

It seems that the url parameter 'id' is not defined, that's the cause of the notice.
You should first check for its existence, eg.
if (isset($_GET['id'])) {
your code here
}

Related

Php global $_GET variable

I have two files. one is header.php and index.php. I didn't understand how $_GET['a'] data is passing from header.php file to index.php for the routing system.
I have tried finding $_GET['a'] passing method from header.php to index.php
Image is a portion of the header.php file
/*index.php*/
include("sources/header.php");
$a = protect($_GET['a']);
switch ($a) {
case "account": include("sources/account.php"); break;
case "login": include("sources/login.php"); break;
case "register": include("sources/register.php"); break;
case "track": include("sources/track.php"); break;
case "testimonials": include("sources/testimonials.php"); break;
case "affiliate": include("sources/affiliate.php"); break;
case "contact": include("sources/contact.php"); break;
case "about": include("sources/about.php"); break;
case "faq": include("sources/faq.php"); break;
case "page": include("sources/page.php"); break;
case "exchange": include("sources/exchange.php"); break;
case "search": include("sources/search.php"); break;
case "password": include("sources/password.php"); break;
case "email-verify": include("sources/email-verify.php"); break;
case "logout":
unset($_SESSION['bit_uid']);
unset($_COOKIE['bitexchanger_uid']);
setcookie("bitexchanger_uid", "", time() - (86400 * 30), '/'); // 86400 = 1 day
session_unset();
session_destroy();
header("Location: $settings[url]");
break;
default: include("sources/homepage.php");
}
I expect to know how $_GET['a'] is passing from header.php to index.php
$_GET query contains the keys/values array that are passed to your script in the URL.
If you have the following URL:
http://www.example.com/test.php?a=login
Then $_GET will contain :
array
'a' => string 'login' (length=5)
$_GET is not read-only, you could also set some values from your PHP code, if needed :
You can pass data to $_GET in your header.php
$_GET['a'] = 'register';
But this doesn't seem like good practice, as $_GET is supposed to contain data from the URL requested by the client.
In header.php file you need change urls
Link
Source

Switch and if statement returns the first case condition regardless if it is true or not

I am working on a , project which i have configured to serves multiple pages from one index.php file using a switch statement like this:
switch(isset($_GET['q']{
case 'page':
require 'link_to_page.php';
break;
case 'login':
require = 'link_to_login.php';
break;
default:
require = 'link_to_404.php';
break;
}
As time goes by and more pages are added, i decided to move it to a selectPage() function which i now called and assigned to a variable $page and required it in my index.php file to make things simpler like this:
myFunctions.php
selectPage()
{
switch(isset($_GET['q']{
case 'page':
$output = 'link_to_page.php';
break;
case 'login':
$output = 'link_to_login.php';
break;
default:
$output = 'link_to_404.php';
break;
return $output;
}
}
My index.php looks like this:
require 'myFunctions.php';
$page = selectPage();
require $page;
Now the problem here is, regardless of which case is true case page: or case 'login':, $output returned is always equal to the first line of case condition checked, for example when case page: is the first line of case statement and $_GET['q'] == 'login', case page: $output value is returned, when i swapped the case 'login': with case page: for it to be the first condition checked, case 'login': $output value which is now the first line of condition is returned even if $_GET['q'] == 'page'.
i have also tried it with an if(statement) and the same thing happened.
How do i fix this, is there something am doing wrong?
Syntax error your Switch statement.
Right SYNTAX :
switch (n) {
case label1:
code to be executed if n=label1;
break;
case label2:
code to be executed if n=label2;
break;
case label3:
code to be executed if n=label3;
break;
...
default:
code to be executed if n is different from all labels;
}
So, myFunctions.php Page
function selectPage()
{
$page = isset($_GET['q']) ? $_GET['q'] : null;
switch ($page) {
case "page":
return 'link_to_page.php';
break;
case "login":
return "link_to_login.php";
break;
default:
return "link_to_404.php";
}
}
index.php page
require 'myFunctions.php';
$page = selectPage();
require $page;
Try this:
switch($_GET['q']){
....
}
You try to check $_GET['q'] but really you check isset($_GET['q']), so when PHP gets true it tries to compare values you give in case statement with true. And as your value are not empty or false values, that condition is true, and code under it will execute.

I Don't want ?lan=AL code in my url php?

I want to change the language without showing the url:
http://myweb.com/?lan=AL
or
http://myweb.com/about-us?lan=AL
How can it be done in background, not to show in url.
This is the code below.
require('_inc_lang/lan_en.php');
require('_inc_lang/lan_al.php');
require('_inc_lang/lan_de.php');
if(!isset($_SESSION['lan'])){
session_start();
}
if(isset($_GET['lan'])){
$_SESSION['lan'] = $_GET['lan'];
}
$lan = isset($_SESSION['lan']) ? $_SESSION['lan'] : 'al';
switch ($lan) {
case 'al':
$TEXT = $TEXT_AL;
break;
case 'de':
$TEXT = $TEXT_DE;
break;
case 'en':
$TEXT = $TEXT_EN;
break;
}
You can do it based on the browser language
<?php
$lang = substr($_SERVER['HTTP_ACCEPT_LANGUAGE'], 0, 2);
switch ($lang){
case "de":
$TEXT = $TEXT_DE;
break;
case "en":
$TEXT = $TEXT_EN;
break;
case "al":
$TEXT = $TEXT_AL;
break;
default:
$TEXT = $TEXT_EN;
}
?>
Change from GET to POST.
<form method="post">
..button/select/whatever have you
</form>
if(isset($_POST) && /* sanitise */)
$_SESSION['lan'] = $_POST['lan'];
Code needs a tidy up but you can do that yourself :) Is this what you are looking for?
Edit:
Absolutely totally must use a link or you will explode? The following SO pages will magically show you how!
Use a normal link to submit a form
How to submit a form with JavaScript by clicking a link?
You're already copying the language choice to the session, so if it is found in the URL, just location: to the version without the URL:
if(isset($_GET['lan'])){
$_SESSION['lan'] = $_GET['lan'];
header("Location: ".$_SERVER['SCRIPT_URI']);
}
Edit: note that I added variable $_SERVER['SCRIPT_URI'] instead of hard coded location; now it will work regardless of where it is called (SCRIPT_URI will give you server/page without query string)

PHP - Do an else to many ifs?

EDIT: Very simple, figure it out. Just put an else{} without a } before and that will work for both ifs.
Well I wrote this code and it works ok
if($_REQUEST['pag']){
// Variável da página
$pag = $_REQUEST['pag'];
// Possíveis páginas
if($pag == "registrar"){
include "inc/register.php";
}
if ($pag == "recuperar"){
include "inc/recover.php";
}
}
But what if the user types ?pag=ofksaofkoasdkfkopsd ?
The page won't exist, so I want to include a file if that happens.
Is there a way to make this without using a list or something?
you can do this by switch and that would be better way then if because
The switch statement is similar to a series of IF statements on the same expression. In many occasions, you may want to compare the same variable (or expression) with many different values, and execute a different piece of code depending on which value it equals to. This is exactly what the switch statement is for. (manual )
switch($_REQUEST['pag']){
case "registrar":
include "inc/register.php";
break;
case :"recuperar":
include "inc/recover.php";
break;
default:
//default you want to include
break;
}
i hope you know about the complexity of the code and in your case switch case has less complexity in worst/average case
Try with if with else like
$pag = $_REQUEST['pag'];
// Possíveis páginas
if($pag == "registrar"){
include "inc/register.php";
}
elseif ($pag == "recuperar"){
include "inc/recover.php";
}
else{
include "inc/default.php"
}
Or you can use switch case where you can found default option like
switch($pag)
{
case "register":include "inc/register.php";
break;
case "recuperar":include "inc/recover.php";
break;
default : include "inc/default.php";
}
use if {} else{} or switch case.
You can use nested if else though.
At least give an eye on the docs - http://php.net/manual/en/control-structures.elseif.php
Why don't you want to use an array? That really would be the best way to go IMHO. Adding pages is easier, you get less duplicated code... It would also be trivial to load the array from a config file or DB instead of having it hard-coded in a later stadium. I see only benefits.
$pages = array( "registrar" => "inc/register.php",
"recuperar" => "inc/recover.php" );
$requestedPage = $_REQUEST["pag"];
if(array_key_exists($requestedPage, $pages)){
include $pages[$requestedPage];
}
else {
include "inc/error404.php";
}
some Use the switch command.
switch ($_REQUEST['pag']) {
case 'registrar':
echo "some text or action";
break;
case 'xxx':
echo "some text or action";
break;
case 'xxxx':
echo "some text";
break;
default:
echo "some text";
}
$pag = isset($_REQUEST['pag']) ? $_REQUEST['pag'] : null;
switch($pag) {
case 'registrar':
require 'inc/register.php';
break;
case 'recuperar':
require "inc/recover.php";
break;
default:
// Include your default page
}
In a non-dynamic language like C++ you'll have to use
if() elseif() else to compare non-constant values.
if ($condition1)
{
//code
}
elseif ($condition2)
{
//code
}
elseif ($condition3)
{
//code
}
...
else
{
//this is what happens when no other condition is true
}
switch is a better practice. check #user1752647's answer
Try with the elseif and else
if($pag == "registrar"){
include "inc/register.php";
}elseif($pag == "recuperar"){
include "inc/recover.php";
}else{
... //include a file if the page doesn't exist
}
Or you can do it with a switch
switch($pag){
case "registrar":
include "inc/register.php";
break;
case "recuperar":
include "inc/recover.php";
break;
default:
... //include a file if the page doesn't exist
}
Hope it will help you.
You also can use this code
$pages = array("register", "recover");
if (in_array($_REQUEST["pag"], $pages)) {
include $_REQUEST["pag"].".php";
}
else{
include "default.php";
}

switch using $_SERVER['HTTP_HOST'] always defaults to first

I have the following code:
<?php
echo $_SERVER['HTTP_HOST'];
// CONFIGURATION ITEMS
$captcha_private_key = '';
$captcha_public_key = '';
switch ($_SERVER['HTTP_HOST']) {
case 'earth-neighbours.com' || 'www.earth-neighbours.com':
$captcha_private_key = '6Lcb_t4SAAAAALkdH4njSny2HYbrmGKS_G84kM_d';
$captcha_public_key = '6Lcb_t4SAAAAAPEtqJEcWXuo0zmRD5PxYkXx84R4';
echo 'live';
break;
case 'earth-neighbours.projects.mi24.net':
$captcha_private_key = '6Lca_t4SAAAAAJb5L4sA7fEHxDFA0Jl8jFw-h3hE';
$captcha_public_key = '6Lca_t4SAAAAAFd-Q2k8esFa9U8nQ2rirEZHFtAH';
break;
case 'earth-neighbours.local':
$captcha_private_key = '6LcZ_t4SAAAAAGc1_S9ahxo-Vg-e7QgHg4yAWBVU';
$captcha_public_key = '6LcZ_t4SAAAAAPHQDb_f-g4mS6mpmc0heustHQ60&hl';
echo 'local';
break;
}
?>
It's running on the local server (earth-neighbours.local) so should output 'local'. Instead it outputs 'live'. The echo at the top however (echo $_SERVER['HTTP_HOST'];) returns the url earth-neighbours.local so it should be 'local' that is echoed. This has me stumped. I had it working before and now I've shifted it to the top of the page and it doesn't work. Weird! Anyone?
PHP does not do switch case or statements like other programming languages.
When you write the following:
switch ($test) {
case 1 || 2:
$blah();
break;
}
This is what actually happens:
switch ($test) {
if (true == $test) {
}
}
The reason this happens is because the case content actually gets evaluated, and in PHP, 1 || 2 === true. PHP then does a typecast on $test to boolean, and $test, unless empty, comes out true.
The PHP "correct" syntax is:
switch ($test) {
case 1:
case 2:
$blah();
break;
In PHP (and a few other languages, actually), once the interpreter gets in the switch, the only way it will come out is by break. Not breaking at the end of a case tells it to continue.
Use:
case 'earth-neighbours.com':
case 'www.earth-neighbours.com':
instead of:
case 'earth-neighbours.com' || 'www.earth-neighbours.com':
As that is an incorrect syntax for the switch statement

Categories