EDIT: Very simple, figure it out. Just put an else{} without a } before and that will work for both ifs.
Well I wrote this code and it works ok
if($_REQUEST['pag']){
// Variável da página
$pag = $_REQUEST['pag'];
// Possíveis páginas
if($pag == "registrar"){
include "inc/register.php";
}
if ($pag == "recuperar"){
include "inc/recover.php";
}
}
But what if the user types ?pag=ofksaofkoasdkfkopsd ?
The page won't exist, so I want to include a file if that happens.
Is there a way to make this without using a list or something?
you can do this by switch and that would be better way then if because
The switch statement is similar to a series of IF statements on the same expression. In many occasions, you may want to compare the same variable (or expression) with many different values, and execute a different piece of code depending on which value it equals to. This is exactly what the switch statement is for. (manual )
switch($_REQUEST['pag']){
case "registrar":
include "inc/register.php";
break;
case :"recuperar":
include "inc/recover.php";
break;
default:
//default you want to include
break;
}
i hope you know about the complexity of the code and in your case switch case has less complexity in worst/average case
Try with if with else like
$pag = $_REQUEST['pag'];
// Possíveis páginas
if($pag == "registrar"){
include "inc/register.php";
}
elseif ($pag == "recuperar"){
include "inc/recover.php";
}
else{
include "inc/default.php"
}
Or you can use switch case where you can found default option like
switch($pag)
{
case "register":include "inc/register.php";
break;
case "recuperar":include "inc/recover.php";
break;
default : include "inc/default.php";
}
use if {} else{} or switch case.
You can use nested if else though.
At least give an eye on the docs - http://php.net/manual/en/control-structures.elseif.php
Why don't you want to use an array? That really would be the best way to go IMHO. Adding pages is easier, you get less duplicated code... It would also be trivial to load the array from a config file or DB instead of having it hard-coded in a later stadium. I see only benefits.
$pages = array( "registrar" => "inc/register.php",
"recuperar" => "inc/recover.php" );
$requestedPage = $_REQUEST["pag"];
if(array_key_exists($requestedPage, $pages)){
include $pages[$requestedPage];
}
else {
include "inc/error404.php";
}
some Use the switch command.
switch ($_REQUEST['pag']) {
case 'registrar':
echo "some text or action";
break;
case 'xxx':
echo "some text or action";
break;
case 'xxxx':
echo "some text";
break;
default:
echo "some text";
}
$pag = isset($_REQUEST['pag']) ? $_REQUEST['pag'] : null;
switch($pag) {
case 'registrar':
require 'inc/register.php';
break;
case 'recuperar':
require "inc/recover.php";
break;
default:
// Include your default page
}
In a non-dynamic language like C++ you'll have to use
if() elseif() else to compare non-constant values.
if ($condition1)
{
//code
}
elseif ($condition2)
{
//code
}
elseif ($condition3)
{
//code
}
...
else
{
//this is what happens when no other condition is true
}
switch is a better practice. check #user1752647's answer
Try with the elseif and else
if($pag == "registrar"){
include "inc/register.php";
}elseif($pag == "recuperar"){
include "inc/recover.php";
}else{
... //include a file if the page doesn't exist
}
Or you can do it with a switch
switch($pag){
case "registrar":
include "inc/register.php";
break;
case "recuperar":
include "inc/recover.php";
break;
default:
... //include a file if the page doesn't exist
}
Hope it will help you.
You also can use this code
$pages = array("register", "recover");
if (in_array($_REQUEST["pag"], $pages)) {
include $_REQUEST["pag"].".php";
}
else{
include "default.php";
}
Related
I have the following PHP code that produces an error as the include files don't exist. I have not yet made them but I want to stop errors being produced (not just hidden). Is there anything I can put into my code that says "don't record any errors if the file doesn't exist, just ignore the instruction"
<?php
$PAGE = '';
if(isset($_GET['page'])) {
$PAGE = $_GET['page'];
};
switch ($PAGE) {
case 'topic': include 'topic.php';
break;
case 'login': include 'login.php';
break;
default: include 'forum.php';
break;
};
?>
use file_exists() to check if your file exists or not before calling include;
if (file_exists('forum.php')) {
//echo "The file forum.php exists";
include 'forum.php';
}
//else
//{
// echo "The file forum.php does not exists";
//}
Include the files only if they exist. You can add a check for existing file -
switch ($PAGE) {
case 'topic':
if(file_exists(path_to_file)) {
include 'topic.php';
}
break;
......
};
file_exists()
You seem to be looking for # operator which silences any errors from an expression, you can read more about it here: http://php.net/manual/en/language.operators.errorcontrol.php
Use file_exists() function:
<?php
$PAGE = '';
if(isset($_GET['page'])) {
$PAGE = $_GET['page'];
};
switch ($PAGE) {
case 'topic':
if (file_exists("topic.php")){
include 'topic.php';
}
break;
case 'login':
if (file_exists("login.php")){
include 'login.php';
}
break;
default:
if (file_exists("forum.php")){
include 'forum.php';
}
break;
};
?>
Documentation http://php.net/manual/en/function.file-exists.php
I am working on a , project which i have configured to serves multiple pages from one index.php file using a switch statement like this:
switch(isset($_GET['q']{
case 'page':
require 'link_to_page.php';
break;
case 'login':
require = 'link_to_login.php';
break;
default:
require = 'link_to_404.php';
break;
}
As time goes by and more pages are added, i decided to move it to a selectPage() function which i now called and assigned to a variable $page and required it in my index.php file to make things simpler like this:
myFunctions.php
selectPage()
{
switch(isset($_GET['q']{
case 'page':
$output = 'link_to_page.php';
break;
case 'login':
$output = 'link_to_login.php';
break;
default:
$output = 'link_to_404.php';
break;
return $output;
}
}
My index.php looks like this:
require 'myFunctions.php';
$page = selectPage();
require $page;
Now the problem here is, regardless of which case is true case page: or case 'login':, $output returned is always equal to the first line of case condition checked, for example when case page: is the first line of case statement and $_GET['q'] == 'login', case page: $output value is returned, when i swapped the case 'login': with case page: for it to be the first condition checked, case 'login': $output value which is now the first line of condition is returned even if $_GET['q'] == 'page'.
i have also tried it with an if(statement) and the same thing happened.
How do i fix this, is there something am doing wrong?
Syntax error your Switch statement.
Right SYNTAX :
switch (n) {
case label1:
code to be executed if n=label1;
break;
case label2:
code to be executed if n=label2;
break;
case label3:
code to be executed if n=label3;
break;
...
default:
code to be executed if n is different from all labels;
}
So, myFunctions.php Page
function selectPage()
{
$page = isset($_GET['q']) ? $_GET['q'] : null;
switch ($page) {
case "page":
return 'link_to_page.php';
break;
case "login":
return "link_to_login.php";
break;
default:
return "link_to_404.php";
}
}
index.php page
require 'myFunctions.php';
$page = selectPage();
require $page;
Try this:
switch($_GET['q']){
....
}
You try to check $_GET['q'] but really you check isset($_GET['q']), so when PHP gets true it tries to compare values you give in case statement with true. And as your value are not empty or false values, that condition is true, and code under it will execute.
I usually use this code below to include the page that I need into the body of my website to include the page when clicking on a link.
<?php
switch($_GET['page']){
case '1':
if(file_exists('main.php'))
{
include_once('main.php');
break;
}
default:
include_once('main.php');
break;
}
?>
but then I have to change this everytime i add a menu item by adding a case '2' ... etc
and now my question can this be written shorter/dynamically so that i just can add a link without having to change the piece of code everywhere?
ps: i did made it a little bit shorter.. but its still not good enough i think..
i also want to add this: i get my links from a ini file. i place it in there like this:
[navigation]
main.php = "Home"
if (!isset($_GET['page'])) {
$_GET['page'] = 'main.php';
}
switch ($_GET['page']){
case 'main.php':
case 'about.php':
case 'portfolio.php':
case 'tips.php':
$file = $_GET['page'];
break;
default:
$file = '404.html';
}
include_once $file;
is it possible to get this too from the ini file?
Try this:
$page = isset($_GET['page']) ? $_GET['page'] : "main.php";
if( file_exists($page)) include($page);
else include("404.html");
I’m working on a site and I kept getting a
Notice: Undefined index: id in file root on line 3
I know its something simple but can’t figure out where the problem lies exactly.
here is the code:
<?php
switch($_GET['id']) {
default:
include('pages/hello.php');
break;
case "testimonials":
include('pages/testimonials.php');
break;
case "faq":
include('pages/faq.php');
break;
case "raq":
include('pages/raq.php');
break;
case "contact":
include('pages/contact.php');
break;
}
?>
line 3 would be <?php switch($_GET['id']) {
any help would be greatly appreciated!
This is because in your url id=x is not always set, so when your trying to switc hthe value its not there. what you should do is like so:
<?php
$id = isset($_GET['id']) ? $_GET['id'] : ''; //This is just a short if-else
switch($id)
{
default:
include('pages/hello.php');
break;
case "testimonials":
include('pages/testimonials.php');
break;
case "faq":
include('pages/faq.php');
break;
case "raq":
include('pages/raq.php');
break;
case "contact":
include('pages/contact.php');
break;
}
?>
Basciall $id = isset($_GET['id']) ? $_GET['id'] : ''; what this says is, IF id is within the url then use that, otherwise use an empty string, the reason for the empty string is it will trigger the default: within the switch statement
this way $id will always be set to something.
Make sure that id is set and the default should go at the end:
if (!isset($_GET['id'])) {
include('pages/hello.php');
}
else{
switch($_GET['id']) {
case "testimonials": include('pages/testimonials.php'); break;
case "faq": include('pages/faq.php'); break;
case "raq": include('pages/raq.php'); break;
case "contact": include('pages/contact.php'); break;
default: include('pages/hello.php'); break;
}
}
For security reasons, make sure to sanitalize yor $_GET['id']. I would suggest you to setup an array of allowed pages and include those that are in the array. You can use in_array function for that.
It seems that the url parameter 'id' is not defined, that's the cause of the notice.
You should first check for its existence, eg.
if (isset($_GET['id'])) {
your code here
}
I have setup a new server and copyed my website on to it and the follow dont work (?p=home) includes pages.
Code:
if(isset($HTTP_GET_VARS['p']))
{
$page = $HTTP_GET_VARS['p'];
}
else
{
$page = 'home';
}
switch($page)
{
case 'home':
require('home.php');
break;
case 'login':
require('login.php');
break;
default:
echo('Error: There is no file on this server with that name');
}
On the other webhost it was on it worked fine am think in that it is a php.ini config file need editing can anyone help me?
Use the $_GET array instead of $HTTP_GET_VARS. The latter one is deprecated and probably disabled due to register_long_arrays.
This must do the trick :)
if(isset($_GET['p']))
{
$page = $_GET['p'];
}
else
{
$page = 'home';
}