binary value not getting updated in database through php - php

Question

I am trying to update status onclick. In display function i have given like this
if($row['IsActive']=="1")
{
echo "<td> <a href='managecategories.php?IsActive=0&CategoryID=" .$row['CategoryID']. "'>Active</a></td>";
}
else
{
echo "<td> <a href='managecategories.php?IsActive=1&CategoryID=" .$row['CategoryID']. "'>Deactive</a></td>";
}
and on loading the page it should get the database status, for that i have written code like this
if (isset($_GET['IsActive']))
{
$status = $_GET['IsActive'];
$id = $_GET['CategoryID'];
if($status =="0")
{
$sql = "update Categories set IsActive= 0 where CategoryID='$id'";
$result = mysql_query($sql) or die("Could not insert data into DB: " . mysql_error());
}
else
if($status =="1")
{
$sql = "update Categories set IsActive= 1 where CategoryID='$id'";
$result = mysql_query($sql) or die("Could not insert data into DB: " . mysql_error());
}
}
But i am not getting any result not errors... please hel me where i am wrong

Answer 1

I would assume that you are using an integer type in the database. I know I would use TINYINT for any boolean, because MySQL does not have a type boolean.
Your display function if($row['IsActive']=="1") supports that. However, your update query $sql = "update Categories set IsActive= 'false' where CategoryID='$id'"; does not. Here you try to save a string value.
So you should first make sure that the boolean value is stored as a TINYINT in the database. (Strings are harder to work with on the PHP side.) Then you need to make sure that the values you insert into the database are actually of the correct type. You should use 0 for false and 1 for true. That will also work in PHP:
$isActive = 1;
$if($isActive) {
// This code is run
}
Also note that you should validate the category id. You're now inserting user input without prior validation, which is dangerous. It is quite easy for a user to activate or deactive all categories in a single command.

Answer 2

In MySQL you don't have true and false, but only 0 and 1 (INT). So change your queries to something like this:
$sql = "update Categories set IsActive= 0 where CategoryID='$id'"; // FALSE
$sql = "update Categories set IsActive= 1 where CategoryID='$id'"; // TRUE
Additionally I see that in the first piece of code you correctly do this: if row is active print a link to deactivate (if 1 then print 0), and viceversa.
But in the second piece of code you get the value you have to set in the $status variable, and then you say again if 1 then store 0. This is a mistake. In fact, this way you always run an UPDATE query that set the active status to its current value, because of the double swap.
That is, try to swap the queries in the second piece of code, like this:
if ($status == "0")
{
$sql = "update Categories set IsActive=0 where CategoryID='$id'";
$result = mysql_query($sql) or die("Could not insert data into DB: " . mysql_error());
}
else if($status == "1")
{
$sql = "update Categories set IsActive=1 where CategoryID='$id'";
$result = mysql_query($sql) or die("Could not insert data into DB: " . mysql_error());
}