Increment individual IPs from IPv6 string (php) - php
What is a simple, elegant way to list the first x number of IPv6 IPs from a IPv6 string.
For example,
listIPs("2600:f333:10:c000::0", 4)
echos
2600:f333:10:c000::1
2600:f333:10:c000::2
2600:f333:10:c000::3
2600:f333:10:c000::4
Here's a sample of code that may have worked for IPv4, as it converted to int:
$input = "2600:f333:10:c000::/51";
$max = 4;
list($block, $cidr) = explode("/", $input);
$first = inet_pton( $block );
echo inet_ntop($first) . "\n";
for ($i = 1; $i < $max; $i++) {
//todo: die if it has exceeded block size based on $cidr
echo inet_ntop($first + $i) . "\n"; //doesn't work, packed binary?
}
Here's an example program written in C (since I don't know C++). It's fairly fast, but I'm not really happy with it. Maybe someone can help me improve it.
Edit: Obviously, I wrote this before it was turned into a PHP-only question. Turning this into PHP is left as an exercise to the reader (ew).
#include <arpa/inet.h>
#include <string.h>
#include <stdlib.h>
#include <errno.h>
#include <stdio.h>
#include <ctype.h>
/*
* Syntax: ./ipv6_list <ip>/<cidr-prefix>
*/
int main(int argc, char **argv) {
uint8_t start[16];
uint8_t address[16];
uint8_t mask[16] = { 0 };
uint8_t prefix = 128;
char *prefix_location;
int i;
/* This is the octet that, when changed, will result in <IP> & <mask> != <start IP> */
int mask_check_octet = 0;
if(argc != 2)
return 1;
/* Find prefix */
if((prefix_location = strstr(argv[1], "/")) != NULL) {
char *prefix_search = prefix_location + 1;
char *prefix_remaining;
long prefix_test;
if(!isdigit(*prefix_search))
return 2;
errno = 0;
prefix_test = strtol(prefix_search, &prefix_remaining, 10);
if(errno == ERANGE || prefix_test < 0 || prefix_test > 128 || strcmp(prefix_remaining, "") != 0)
return 2;
prefix = (uint8_t)prefix_test;
*prefix_location = '\0'; /* So we can just pass argv[1] into inet_pton(3) */
}
/* Convert prefix into mask */
for(i = 0; i < 16; i++) {
if(prefix == 0)
break;
mask_check_octet = i;
if(prefix < 8) {
mask[i] = ~((1 << (8 - prefix)) - 1);
break;
}
else
mask[i] = UINT8_MAX;
prefix -= 8;
}
/* Find address */
if(inet_pton(AF_INET6, argv[1], start) != 1)
return 3;
/* Start at the beginning of the network */
for(i = 0; i < 16; i++) {
start[i] &= mask[i];
address[i] = start[i];
}
/* Iterate */
while((address[mask_check_octet] & mask[mask_check_octet]) == start[mask_check_octet]) {
char address_str[INET6_ADDRSTRLEN];
inet_ntop(AF_INET6, address, address_str, sizeof(address_str));
printf("%s\n", address_str);
/* Add one to the address */
for(i = 15; i >= 0; i--) {
if(address[i] != UINT8_MAX)
break;
}
address[i]++;
for(i++; i < 16; i++)
address[i] = 0;
};
return 0;
}
You can use standard shell commands to limit its output (or just modify the while loop):
nfontes#brioche:~$ ./ipv6_list '2607:fc50:0:d00::0/106' | head -n 200
2607:fc50:0:d00::
2607:fc50:0:d00::1
2607:fc50:0:d00::2
2607:fc50:0:d00::3
2607:fc50:0:d00::4
2607:fc50:0:d00::5
2607:fc50:0:d00::6
2607:fc50:0:d00::7
2607:fc50:0:d00::8
2607:fc50:0:d00::9
2607:fc50:0:d00::a
2607:fc50:0:d00::b
2607:fc50:0:d00::c
2607:fc50:0:d00::d
2607:fc50:0:d00::e
[...]
2607:fc50:0:d00::c0
2607:fc50:0:d00::c1
2607:fc50:0:d00::c2
2607:fc50:0:d00::c3
2607:fc50:0:d00::c4
2607:fc50:0:d00::c5
2607:fc50:0:d00::c6
2607:fc50:0:d00::c7
Something similar (in PHP). It takes an IPv4/IPv6 address and increments it by given value:
// Takes an IPv4/IPv6 address in string format, and increments it by given value
function incrementIp($ip, $increment)
{
$addr = inet_pton ( $ip );
for ( $i = strlen ( $addr ) - 1; $increment > 0 && $i >= 0; --$i )
{
$val = ord($addr[$i]) + $increment;
$increment = $val / 256;
$addr[$i] = chr($val % 256);
}
return inet_ntop ( $addr );
}
Related
How translate a neural network from C to PHP
I'm trying to translate this algorithm from C language to PHP (for study) This is an example of a perceptron. I copied the example written in c and I'm trying to translate it into PHP. Currently I wrote this code, what am I wrong? As output I only know 101 iterations with result always 1. This is the C program: #include <stdio.h> #include <stdlib.h> #include <math.h> #include <time.h> #define LEARNING_RATE 0.1 #define MAX_ITERATION 100 float randomFloat() { return (float)rand() / (float)RAND_MAX; } int calculateOutput(float weights[], float x, float y) { float sum = x * weights[0] + y * weights[1] + weights[2]; return (sum >= 0) ? 1 : -1; } int main(int argc, char *argv[]) { srand(time(NULL)); float x[208], y[208], weights[3], localError, globalError; int outputs[208], patternCount, i, p, iteration, output; FILE *fp; if ((fp = fopen("test1.txt", "r")) == NULL) { printf("Cannot open file.\n"); exit(1); } i = 0; while (fscanf(fp, "%f %f %d", &x[i], &y[i], &outputs[i]) != EOF) { if (outputs[i] == 0) { outputs[i] = -1; } i++; } patternCount = i; weights[0] = randomFloat(); weights[1] = randomFloat(); weights[2] = randomFloat(); iteration = 0; do { iteration++; globalError = 0; for (p = 0; p < patternCount; p++) { output = calculateOutput(weights, x[p], y[p]); localError = outputs[p] - output; weights[0] += LEARNING_RATE * localError * x[p]; weights[1] += LEARNING_RATE * localError * y[p]; weights[2] += LEARNING_RATE * localError; globalError += (localError*localError); } /* Root Mean Squared Error */ printf("Iteration %d : RMSE = %.4f\n", iteration, sqrt(globalError/patternCount)); } while (globalError != 0 && iteration<=MAX_ITERATION); printf("\nDecision boundary (line) equation: %.2f*x + %.2f*y + %.2f = 0\n", weights[0], weights[1], weights[2]); return 0; } and this is the code that I wrote <?php define("LEARNING_RATE", 0.1); define("MAX_ITERATION", 100); function randomFloat(){ return (float) mt_rand() / mt_getrandmax(); } function calculateOutput($weights, $x, $y){ $sum = (float) $x * $weights[0] + $y * $weights[1] + $weights[2]; return ($sum >= 0) ? 1 : -1; } srand(time()); $i = 0; $ars = explode("\n",file_get_contents('https://raw.githubusercontent.com/RichardKnop/ansi-c-perceptron/master/test1.txt')); foreach($ars as $ar){ $temp = explode("\t", $ar); $x[$i] = (float) $temp[0]; $y[$i] = (float) $temp[1]; $output[$i] = (int) $temp[2]; if($output[$i] == 0) $output[$i] = -1; $i++; } $patternCount = $i; $weights[0] = randomFloat(); $weights[1] = randomFloat(); $weights[2] = randomFloat(); $iteration = 0; do{ $iteration++; $globalError = 0; for ($p = 0; $p < $patternCount; $p++) { $output = calculateOutput($weights, $x[$p], $y[$p]); $localError = $outputs[$p] - $output; $weights[0] += LEARNING_RATE * $localError * $x[$p]; $weights[1] += LEARNING_RATE * $localError * $y[$p]; $weights[2] += LEARNING_RATE * $localError; $globalError += ($localError*$localError); } $r .= "Iteration $iteration : RMSE = " . sqrt($globalError/$patternCount)."<br>"; }while($globalError != 0 && $iteration<=MAX_ITERATION); echo $r; echo "<br><hr><br>"; echo "Decision boundary (line) equation: ".$weights[0]."*x + ".$weights[1]."*y + ".$weights[2]." = 0<br>"; it's practically identical, but why does it not work?
$ars = explode("\n",file_get_contents('…')); Since the file ends with a \n, this yields an empty string as the last array value, which disrupts the foreach($ars as $ar) loop. To read the file into an array, simply use: $ars = file('…'); In the foreach($ars as $ar) loop, you used the wrong name $output[$i] instead of $outputs[$i]. $r .= "Iteration $iteration : RMSE = " . sqrt($globalError/$patternCount)."<br>"; }while($globalError != 0 && $iteration<=MAX_ITERATION); echo $r; You didn't initialize $r. Instead of the above, you can use: echo "Iteration $iteration : RMSE = " . sqrt($globalError/$patternCount)."<br>"; } while ($globalError != 0 && $iteration<=MAX_ITERATION);
Convert VB6 code to PHP
I want to convert Visual Basic 6 Code to PHP Code. I am new to PHP please help me to convert my VB6 Code to PHP. So far I tried to convert this into php code when I tried the code there is an error in the " CryptRC4 = CryptRC4 & Chr$((pvCryptXor(baS((CLng(baS(li)) + baS(lJ)) Mod 256), Asc(Mid$(sText, lIdx, 1))))); part and also I don't know how to proceed to the sub functions. Please see the codes below. The vb code is used to encrypt strings. I want to convert it to php format. PHP Code <?php function CryptRC4($sText,$sKey){ $baS = array(0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15, 16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31, 32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47, 48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63, 64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79, 80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95, 96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111, 112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127, 128,129,130,131,132,133,134,135,136,137,138,139,140,141,142,143, 144,145,146,147,148,149,150,151,152,153,154,155,156,157,158,159, 160,161,162,163,164,165,166,167,168,169,170,171,172,173,174,175, 176,177,178,179,180,181,182,183,184,185,186,187,188,189,190,191, 192,193,194,195,196,197,198,199,200,201,202,203,204,205,206,207, 208,209,210,211,212,213,214,215,216,217,218,219,220,221,222,223, 224,225,226,227,228,229,230,231,232,233,234,235,236,237,238,239, 240,241,242,243,244,245,246,247,248,249,250,251,252,253,254,255); $baK = array(0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15, 16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31, 32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47, 48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63, 64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79, 80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95, 96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111, 112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127, 128,129,130,131,132,133,134,135,136,137,138,139,140,141,142,143, 144,145,146,147,148,149,150,151,152,153,154,155,156,157,158,159, 160,161,162,163,164,165,166,167,168,169,170,171,172,173,174,175, 176,177,178,179,180,181,182,183,184,185,186,187,188,189,190,191, 192,193,194,195,196,197,198,199,200,201,202,203,204,205,206,207, 208,209,210,211,212,213,214,215,216,217,218,219,220,221,222,223, 224,225,226,227,228,229,230,231,232,233,234,235,236,237,238,239, 240,241,242,243,244,245,246,247,248,249,250,251,252,253,254,255); $bytSwap = 0; $li = 0; $lJ = 0; $lIdx = 0; for( $lIdx = 0; $lIdx < 256; $lIdx++){ $baS[$lIdx] = $lIdx; $baK[$lIdx] = ord(substr($sKey, 1 + ($lIdx % strlen($sKey)), 1)); } for($li = 0; $li < 256; $li++){ $lJ = ($baS[$li] + $baK[$li]) % 256; $bytSwap = $baS[$li]; $baS[$li] = $baS[$lJ]; $baS[$lJ] = $bytSwap; } $li = 0; $lJ = 0; $data_str = ""; for($lIdx = 0; $lIdx < strlen($sText); $lIdx++){ $li = ($li + 1) % 256; $lJ = ($lJ + $baS[$li]) % 256; $bytSwap = $baS[$li]; $baS[$li] = $baS[$lJ]; $baS[$lJ] = $bytSwap; #echo chr((pvCryptXor($baS[(round(($baS[$li]) + $baS[$lJ])) % 256], ord(substr($sText, $lIdx, 1))))); $data_str .= chr((pvCryptXor($baS[(round(($baS[$li]) + $baS[$lJ])) % 256], ord(substr($sText, $lIdx, 1))))); } echo $data_str; } function pvCryptXor($li, $lJ){ if($li = $lJ){ $pcx = $lJ; } else { $pcx = $li Xor $lJ; } return $pcx; } unction ToHexDump($sText) { $lIdx; for($lIdx = 1; $lIdx < strlen($sText); $lIdx++){ $thd .= Right$("0" & Hex(Asc(Mid(sText, lIdx, 1))), 2) echo $thd; } return $thd; } FromHexDump("events"); function FromHexDump($sText) { $fhd = ""; for($lIdx = 0; $lIdx < strlen($sText); $lIdx++){ $fhd .= chr(CLng("&H" & Mid(sText, lIdx, 2))); } return $fhd; } ?> VB Code: Public Function CryptRC4(sText As String, sKey As String) As String On Error Resume Next Dim baS(0 To 255) As Byte Dim baK(0 To 255) As Byte Dim bytSwap As Byte Dim li As Long Dim lJ As Long Dim lIdx As Long For lIdx = 0 To 255 baS(lIdx) = lIdx baK(lIdx) = Asc(Mid$(sKey, 1 + (lIdx Mod Len(sKey)), 1)) Next For li = 0 To 255 lJ = (lJ + baS(li) + baK(li)) Mod 256 bytSwap = baS(li) baS(li) = baS(lJ) baS(lJ) = bytSwap Next li = 0 lJ = 0 For lIdx = 1 To Len(sText) li = (li + 1) Mod 256 lJ = (lJ + baS(li)) Mod 256 bytSwap = baS(li) baS(li) = baS(lJ) baS(lJ) = bytSwap CryptRC4 = CryptRC4 & Chr$((pvCryptXor(baS((CLng(baS(li)) + baS(lJ)) Mod 256), Asc(Mid$(sText, lIdx, 1))))) Next End Function Private Function pvCryptXor(ByVal li As Long, ByVal lJ As Long) As Long On Error Resume Next If li = lJ Then pvCryptXor = lJ Else pvCryptXor = li Xor lJ End If End Function Public Function ToHexDump(sText As String) As String On Error Resume Next Dim lIdx As Long For lIdx = 1 To Len(sText) ToHexDump = ToHexDump & Right$("0" & Hex(Asc(Mid(sText, lIdx, 1))), 2) Next End Function Public Function FromHexDump(sText As String) As String On Error Resume Next Dim lIdx As Long For lIdx = 1 To Len(sText) Step 2 FromHexDump = FromHexDump & Chr$(CLng("&H" & Mid(sText, lIdx, 2))) Next End Function
I revised your updated code and it seems you only had a few minor errors in it, look and my changes: I guess you can use the build in PHP function hex2bin and bin2hex instead fo you own hex conversion. function CryptRC4($sText,$sKey){ $baS = range(0, 255); // you can use range instead of your manual arrays $baK = range(0, 255); $bytSwap = 0; $li = 0; $lJ = 0; $lIdx = 0; for( $lIdx = 0; $lIdx < 256; $lIdx++){ $baS[$lIdx] = $lIdx; $baK[$lIdx] = ord(substr($sKey, 1 + ($lIdx % strlen($sKey)), 1)); } for($li = 0; $li < 256; $li++){ $lJ = ($baS[$li] + $baK[$li]) % 256; $bytSwap = $baS[$li]; $baS[$li] = $baS[$lJ]; $baS[$lJ] = $bytSwap; } $li = 0; $lJ = 0; $data_str = ""; for($lIdx = 0; $lIdx < strlen($sText); $lIdx++){ $li = ($li + 1) % 256; $lJ = ($lJ + $baS[$li]) % 256; $bytSwap = $baS[$li]; $baS[$li] = $baS[$lJ]; $baS[$lJ] = $bytSwap; #echo chr((pvCryptXor($baS[(round(($baS[$li]) + $baS[$lJ])) % 256], ord(substr($sText, $lIdx, 1))))); $data_str .= chr((pvCryptXor($baS[(round(($baS[$li]) + $baS[$lJ])) % 256], ord(substr($sText, $lIdx, 1))))); } return $data_str; // changed from echo to return } function pvCryptXor($li, $lJ){ if($li == $lJ){ // you had an error here, use == to compare instead of a single = $pcx = $lJ; } else { $pcx = $li ^ $lJ; // XOR function in PHP is the ^ operator } return $pcx; } $str_hex = bin2hex("events"); $str_enc = CryptRC4($str_hex,"password"); $str_dec = hex2bin(CryptRC4($str_enc,"password")); echo $str_hex . PHP_EOL . $str_enc . PHP_EOL . $str_dec; OUTPUT: 6576656e7473 '�����~i�� events So it seems to me as it's actually encoding and decoding correctly!?
It seems the original VB6 implementation of CryptRC4 function is from my answer to "VB6 encrypt text using password" question on SO. So let me try answering your Q with this short php implementation of all public functions in the VB6 snippet: function CryptRC4($text, $key) { return openssl_encrypt($text, "RC4-40", $key, 1 | 2); } function ToHexDump($text) { return strtoupper(bin2hex($text)); } function FromHexDump($text) { return hex2bin($text); } You can excercise these one-liners with something like this: $text = "a message here"; $password = "password"; $encr = ToHexDump(CryptRC4($text, $password)); $decr = CryptRC4(FromHexDump($encr), $password); echo $text . PHP_EOL . $encr . PHP_EOL . $decr;
As it's intended for passwords, you can save yourself a lot of hassle. PHP has got built in functions (version 5.5 and newer) that are designed for dealing with the hashing of passwords and for verifying hashed passwords against the password submitted by a user. Have a read through the PHP relevant PHP manual pages http://php.net/manual/en/book.password.php
Send data to webserver from Arduino using Ethercad lib
i'm trying to send multiple data to a webserver using Ethercard library but for any reason is is only sending one data at a time. Here is the the code I'm using: #include <enc28j60.h> #include <EtherCard.h> #include <net.h> #define HTTP_HEADER_OFFSET 163 #define MAX_STRINGS 100 #define MAX_STRING_LENGTH 8 /* Setup for Ethernet Library */ static byte mymac[] = { 0x74, 0x69, 0x69, 0x2D, 0x30, 0x31 }; const char website[] PROGMEM = "www.arksecurity.net16.net"; const char device[] = "0004"; char test[MAX_STRINGS][MAX_STRING_LENGTH+1]; unsigned long timer; unsigned long tempo = 5000; String register[20]; unsigned int sentOK = 0; char* localID[MAX_STRINGS]; int countRegister = 2; //int countRegister = 1; int countID; byte Ethernet::buffer[700]; void setup() { Serial.begin(57600); register[0] = "empty"; if (!ether.begin(sizeof Ethernet::buffer, mymac, 53)) { Serial.println("Failed to access Ethernet controller"); while(1); } else Serial.println("Ethernet controller initialized"); Serial.println(); if (!ether.dhcpSetup()) { Serial.println("Failed to get configuration from DHCP"); while(1); } else Serial.println("DHCP configuration done"); if (!ether.dnsLookup(website)) { Serial.println("DNS failed"); while(1); } else Serial.println("DNS resolution done"); ether.printIp("SRV IP:\t", ether.hisip); Serial.println(); timer = millis() - tempo; } void loop() { char tempRegister[80]; ether.packetLoop(ether.packetReceive()); if (millis() - timer > tempo) { timer += tempo; ether.browseUrl(PSTR("/DevicesQuery.php?device="), device , website, response_callback); if(test[0][0] != 0) { int missing = 0; Serial.println("Data Received"); for(int i = 0; i < countID ; i++) { for(int x = 0; x < 8 ; x++) { if (test[i][x] == '\0') { missing = 1; } } } if(missing) { Serial.println("Data Missing"); tempo = 5000; } else { for(int g; g < countID ; g++) { register[g] = String(test[g]); } tempo = 40000; } } else{ Serial.println("Waiting for server response..."); tempo = 5000; } //register[0] = "?ID=1234"; //register[1] = "?ID=5678"; if(register[0] != "empty") { for(int i = 0; i < countRegister ; i++) { register[i].toCharArray(tempRegister, 80); //delay(5000); //Serial.println(tempRegister); ether.browseUrl(PSTR("/log.php"), tempRegister , website, browser_callback); //while(sentOK == 0); //sentOK = 0; } countRegister = 0; register[0] = "empty"; } } } static void response_callback (byte status, word off, word len) { for(int i=0;i<MAX_STRINGS;i++) for(int j=0;j<=MAX_STRING_LENGTH;j++) test[i][j] = 0; int i_string = 0; int i_char = 0; int i_ethBuff = off + HTTP_HEADER_OFFSET; char carat; countID = 0; for (i_ethBuff = off + HTTP_HEADER_OFFSET; (carat = (char)Ethernet::buffer[i_ethBuff]) != 0; i_ethBuff++) { if (carat == '\n') { // New line char = new string if (i_string < MAX_STRINGS - 1){ i_string++; i_char = 0; } else break; // Limite de memória do Arduino } else { if (i_char < MAX_STRING_LENGTH) { test[i_string][i_char] = carat; i_char++; } // otherwise discard the char (max length of string reached) } } } static void browser_callback (byte status, word off, word len) { Serial.println("Data sent"); //sentOK = 1; } countRegister is a variable and when it equals 1, it works great but, if he equals 2,for example, he only sends the second data to the server and ignore the first one. Anyone knows why is happening? PS.:As for right now, I'm forcing register[0],register[1] values as you can see in the code above,but the idea is that later this values come from an outsource.
The short of it is that browseurl works asynchronously. Have a look at http://forum.jeelabs.net/node/1477.html
Detecting end of the line in file stored in string variable
Here's the file I happen to analyze through php: #include <stdio.h> #include <stdlib.h> #include "subdir/file.h" #define STRUCT_PTR struct {int i;} * // This function does nothing useful. int func(int i, ...) { return i + i; } /* + + + + + + Main. + + + + + + + + + */ int main(void) { int i = 1; char s[10] = "- - - -"; i++; s[1] = 'b'; i += func(4); STRUCT_PTR t = malloc(sizeof(*t)); if (!t) { return EXIT_FAILURE; } t->i = 1 == 2 ? 3 : -5; return EXIT_SUCCESS; } // zZ After the last line-commentary there's end of file. Respectively, when I open it with and editor, there's not new empty line after that commentary. I store the content of this file to variable, like this $var = file_get_contents(path-to-file.c). Then I cycle it through: for($i = 0; isset($fileContent[$i]); $i++) And I count characters in commentaries, including "//", "/*", "*/", and I do also count end of the line character. Expected result is 89 and I am still getting only 88. I am pretty sure that this is because I am unable to detect end of the line, when there's no new line following. I test it like this if($fileContent[$i]==PHP_EOL), but I have also tried using different combos using \n, \r\n, etc. Thank you for your help in advance! EDIT: More of my code for($i = 0; isset($fileContent[$i]); $i++) { // ... some not so important conditions if($fileContent[$i] == '/' && !$inComment && !$inBComment) { if($fileContent[$i+1] == '/') { $inComment = true; $charCount += 2; $skip = true; continue; } } if($inComment) { if($fileContent[$i] == PHP_EOL) { $charCount++; $inComment = false; } else { $charCount++; } continue; }
You don't need to loop over the contents of every line do this. This one liner should do it for you. Note that this is only valid for one line comments. <?php //load file into array $fileContents = file('test.txt'); //init counter $charCount = 0; foreach ($fileContents as $fileContent) { //+count $charCount += (strpos(trim($fileContent),'//') === 0 )?strlen($fileContent):0; } //print echo $charCount; ?>
CRC 16 -DECT with poly x^16 + x^10 + x^8 + x^7 + x^3 + 1
believe me I have tried to code this, tried Google, and haven't had any luck. I'm trying to implement a CRC16 using this poly x^16 + x^10 + x^8 + x^7 + x^3 + 1 using the C language. Since I understand PHP better I'm trying to get a function going, but I'm not getting the right answer of 28713. This code is generating a CRC of 32713. function crc16($string,$crc=0) { for ( $x=0; $x<strlen( $string ); $x++ ) { $crc = $crc ^ ord( $string[$x] ); echo $crc.'<br />'; for ($y = 0; $y < 8 ; $y++) { if ( ($crc & 0x0001) == 0x0001 ) $crc = ( ($crc >> 1 ) ^ 0x10589 ); else $crc = $crc >> 1; } } return $crc; } echo 'CRC:'.crc16('10100011'); Please I beg anyone to give a hand with this..thanks in advance.
Some CRCs are defined to process the bits from each byte from MSB to LSB, and some are defined to process bits from LSB to MSB (the latter is generally the order which is described as "reflected" and uses a reversed polynomial). Your code puts new bits in at the LSB end of the CRC and shifts right, which is suitable for a reflected CRC, but CRC-16-DECT appears to be one of the non-reflected ones. Your input of "10100011" suggests binary, but is being processed as an 8-byte ASCII string. To see what happens when treating 10100011 as binary instead, and working from MSB first, here's a hand calculation (as 8 bits of input doesn't require very much effort): polynomial coefficients | | 10100010 <--- quotient (irrelevant) v __________ 10000010110001001 ) 10100011 <-------- input ^ 10000010110001001 ----------------- = 100001110001001 ^ 10000010110001001 ----------------- = 101110101101 ^ 10000010110001001 ----------------- remainder (CRC) -----> = 111000000101001 = 0x7029 = 28713 So treating the input as binary and working MSB first is the right thing to do. Here is some C code to do the job (as I'm not really into PHP, and ultimately you want C code anyway): #include <stdio.h> #include <stdint.h> static uint16_t crc16(const uint8_t *data, size_t len) { size_t i, j; uint16_t crc = 0; for (i = 0; i < len; i++) { crc ^= (data[i] << 8); /* data at top end, not bottom */ for (j = 0; j < 8; j++) { if ((crc & 0x8000) == 0x8000) /* top bit, not bottom */ crc = (crc << 1) ^ 0x0589; /* shift left, not right */ else crc <<= 1; /* shift left, not right */ } } return crc; } int main(void) { const uint8_t in[] = { 0xa3 }; /* = 10100011 in binary */ uint16_t crc = crc16(in, sizeof(in)); printf("%u (0x%x)\n", crc, crc); return 0; } Result: $ gcc -Wall -o crc16 crc16.c $ ./crc16 28713 (0x7029) $
Try changing 0x10589 to 0xA001: function crc16($string,$crc=0) { for ( $x=0; $x<strlen( $string ); $x++ ) { $crc = $crc ^ ord( $string[$x] ); for ($y = 0; $y < 8; $y++) { if ( ($crc & 0x0001) == 0x0001 ) $crc = ( ($crc >> 1 ) ^ 0xA001 ); else $crc = $crc >> 1; } } return $crc; }
This code works everytime, but I'm not exactly understanding what's going on. char *MakeCRC(char *BitString) { static char Res[17]; // CRC Result char CRC[16]; int i; char DoInvert; for (i=0; i<16; ++i) CRC[i] = 0; // Init before calculation for (i=0; i<strlen(BitString); ++i) { DoInvert = ('1'==BitString[i]) ^ CRC[15]; // XOR required? CRC[15] = CRC[14]; CRC[14] = CRC[13]; CRC[13] = CRC[12]; CRC[12] = CRC[11]; CRC[11] = CRC[10]; CRC[10] = CRC[9] ^ DoInvert; CRC[9] = CRC[8]; CRC[8] = CRC[7] ^ DoInvert; CRC[7] = CRC[6] ^ DoInvert; CRC[6] = CRC[5]; CRC[5] = CRC[4]; CRC[4] = CRC[3]; CRC[3] = CRC[2] ^ DoInvert; CRC[2] = CRC[1]; CRC[1] = CRC[0]; CRC[0] = DoInvert; } for (i=0; i<16; ++i) Res[15-i] = CRC[i] ? '1' : '0'; // Convert binary to ASCII Res[16] = 0; // Set string terminator return(Res); } // A simple test driver: #include <stdio.h> int main() { char *Data, *Result; // Declare two strings Data = "1101000101000111"; Result = MakeCRC(Data); // Calculate CRC printf("CRC of [%s] is [%s] with P=[10000010110001001]\n", Data, Result); return(0); }