How to check if data exists on server PHP [closed] - php

Question

Closed. This question needs details or clarity. It is not currently accepting answers.
Want to improve this question? Add details and clarify the problem by editing this post.
Closed 9 years ago.
Improve this question
I'm trying to send a string of numbers to the server and split each number. If the number exists on the database assign a "t" value and if it doesn't then assign "f" value.
But for some reason I get t's only.
<?php
# get phone from uid
include_once 'utils.php';
$phone = $_GET['phone'] or die("isRegistered: missing phone");
$response = "";
$phonearray = explode(":", $phone);
for ($i = 0; $i<sizeof($phonearray); $i++){
$result = findRow("phone", $phonearray[i], "user_device") or "true" ;
if($result == "true")
{
$response = $response."t".":";
$result = "";
}
else
{
$response = $response."f".":";
$result = "";
}
}
die($response);
?>

Answer 1

There's actually a couple problems here.
As mentioned in the other answers, you're mistakenly using 't' in both branches of your code.
You appear to be using the string "true" instead of the boolean true. While it may appear to work because of the way PHP converts values between types, you're probably actually intending to use true, and using the string instead can lead to unexpected behavior later.
I don't know what findRow() does, but by adding or true (or even or "true") to the end of it, $result will always be true.
You're using i to reference the $phonearray instead of $i. i will generate a PHP warning, and will be interpreted as "i" - instead of the value of the $i variable.
If you look at this part of your code:
$result = findRow("phone", $phonearray[i], "user_device") or "true" ;
if($result == "true")
{
$response = $response."t".":";
$result = "";
}
else
{
$response = $response."t".":";
$result = "";
}
You'll get better results by rewriting it like this:
$result = findRow("phone", $phonearray[$i], "user_device");
$response .= ($result ? 't' : 'f') . ':';
I'm guessing a bit as to what findRow() does since you didn't include anything about it - but I'm assuming it just returns a true/false value.
You'll notice that I've also simplified the entire if/else statement down to a couple lines by using the ternary operator as well.

Answer 2

if($result == "true")
{
$response = $response."t".":";
$result = "";
}
else
{
$response = $response."t".":";
$result = "";
}
change this part to
if($result == "true")
{
$response = $response."t".":";
$result = "";
}
else
{
$response = $response."f".":";
$result = "";
}

Answer 3

You have set "t" for both if and else condition.
and do check
if(isset($_GET['phone']))

Answer 4

if($result == "true")
{
$response = $response."t".":";
$result = "";
}
else
{
$response = $response."t".":";
$result = "";
}
change this part to
if($result == 'true')
{
$response = $response.'t:';
$result = '';
}
else
{
$response = $response.'f:';
$result = '';
}