Working with giant numbers in PHP - php
Morning Guys.
I'm looking for a way/extension, so that I can calculate FAST with really big numbers in PHP, e.g. multiplication with 50-digit numbers.
And please don't tell me, I shall use BC Math or GMP.
They were my second idea,
but both are so useless, when the result has more than 38 digits both just returning "false".
I allready tried writing an own calculation function, which is actually working, but I believe it's a bit to slow.
It's saving every digit of a number in an array, and calcs like I learned it in Elementary school.
it's working perfect only when the incoming numbers are arrays too.
cause elseway the computer will break them before he can save them.
Is there a way to make my function a bit faster, or does there exist a lib which really calcs with bignumbers?
function multiplicate($A, $B)
{
if (!is_array($A))
{
$A = preg_split("//", strval($A), -1, PREG_SPLIT_NO_EMPTY);
}
if (!is_array($B))
{
$B = preg_split("//", strval($B), -1, PREG_SPLIT_NO_EMPTY);
}
if ( $A[0]=='-')
{
array_splice($A, 0, 1);
$negA=-1;
}
else
{
$negA=1;
};
if ( $B[0]=='-')
{
array_splice($B, 0, 1);
$negB=-1;
}
else
{
$negB=1;
};
$l = 0;
$m = 0;
$Erg[0] = 0;
for ( $i=0; $i < count($A); $i++)
{
for ( $j=0; $j < count($B); $j++)
{
$ZwErg = preg_split("//", strval($A[$i]*$B[$j]), -1, PREG_SPLIT_NO_EMPTY);
if ($i==0&&$j==0&&count($ZwErg)==2)
{
$l = 1;
}
if (count($ZwErg)==2)
{
$m = -1;
}
for ( $k=0; $k < count($ZwErg); $k++)
{
$s = $i + $j + $l + $m + 1;
if (isset($Erg[$s]))
{
$Erg[$s] = intval($Erg[$s]) + intval($ZwErg[$k]);
for ( $n=$s; $n >= 0; $n--)
{
if (intval($Erg[$n])>9)
{
$Erg[$n-1] = intval($Erg[$n-1]) + 1 ;
$Erg[$n] = intval($Erg[$n] - 10);
}
};
}
else
{
$Erg[$s] = $ZwErg[$k];
}
$m = 0;
}
}
}
if ($Erg[0]==0)
{
array_splice($Erg,0,1);
}
if ($negA*$negB==-1)
{
array_splice($Erg,0,0,"-");
}
//$Erg = implode("", $Erg);
return $Erg;
}
.
$time_start = microtime(true);
require'mathlab.php';
$a=array(1,2,3,4,3,1,0,9,5,8,7,6,4,2,5,6,1,2,3,9,5,2,6,7,9,0,4,6,3,9,5,2,6,7,9,0,4,6,7,1,2,3,4,3,1,0,9,5,8,7,6,4,2,5,6,7,8,9,0,3,8,1,5,2,8,1,4,0,7,1,2,3,4,3,1,0,9,5,8,7,6,4,2,5,6,7,8,9,0,3,8,1,5,2,8,1,4,0,3,4,3,1,0,9,5,8,7,6,4,2,5,6,7,8,9,0,7,8,9,0); // 100-digits
$b=array(3,9,5,2,6,7,9,0,4,6,7,1,2,3,4,3,1,0,9,5,8,7,3,9,5,2,6,7,9,3,9,5,2,6,7,9,0,4,6,7,1,2,3,4,3,1,0,9,5,8,7,6,4,2,5,6,7,8,9,0,3,8,1,5,2,8,1,4,0,0,4,6,7,1,2,3,4,3,1,0,9,5,8,7,6,4,2,5,6,7,8,9,0,3,8,1,5,2,8,1,4,0,6,4,2,5,6,7,8,9,0,3,8,1,5,2,8,1,4,0); // 100-digits
$a2=123431095876425612395267904639526790467123431095876425678903815281407123431095876425678903815281403431095876425678907890;
$b2=395267904671234310958739526793952679046712343109587642567890381528140046712343109587642567890381528140642567890381528140;
$d=multiplicate($a, $b);
$time_end = microtime(true);
$time = $time_end - $time_start;
$erg= implode("", $d);
echo $erg; // returns 48788350638348981414888625840026024706504222587793349182466850334644805413224925671434030836485835140547446449665876539897036829747577622276768694829991017552834308659985345098432904112370002027411248553582029194707890154740774064503024600
echo $time; // returns 0.75173783302307
$erg3=bcmul($a2, $b2);
$erg4=bcmul(123431095876425612395267904639526790467123431095876425678903815281407123431095876425678903815281403431095876425678907890, 395267904671234310958739526793952679046712343109587642567890381528140046712343109587642567890381528140642567890381528140);
$erg2=gmp_mul($a2, $b2);
$erg5=gmp_mul(123431095876425612395267904639526790467123431095876425678903815281407123431095876425678903815281403431095876425678907890, 395267904671234310958739526793952679046712343109587642567890381528140046712343109587642567890381528140642567890381528140);
echo gmp_strval($erg2); // returns 0
echo gmp_strval($erg5); // returns 0
echo $erg3; // returns 0
echo $erg4; // returns 0
Use bcmath or GMP.
For example,
echo bcmul("123431095876425612395267904639526790467123431095876425678903815281407123431095876425678903815281403431095876425678907890",
"395267904671234310958739526793952679046712343109587642567890381528140046712343109587642567890381528140642567890381528140");
Gives the output:
48788350638348981414888625840026024706504222587793349182466850334644805413224925671434030836485835140547446449665876539897036829747577622276768694829991017552834308659985345098432904112370002027411248553582029194707890154740774064503024600
Related
Looking for opposite of pow() in PHP
I am working on mathematical problem where the formula is: A[i] * (-2) power of i where i=0,1,2,3,... A is an array having values 0 or 1 Input array: [0,1,1,0,0,1,0,1,1,1,0,1,0,1,1] Output is: 5730 Code $totalA = 0; foreach ($A as $i => $a) { $totalA += $a * pow(-2, $i); } This is correct. Now I am looking for its opposite like: Input is: 5730 Output will be: [0,1,1,0,0,1,0,1,1,1,0,1,0,1,1] I am not asking for the exact code but looking for some logic from where I should start. I tried to use log() method but that did not return the desired output.
You were not looking for exact code, but I found this problem too interesting. This works: function sign($n) { return ($n > 0) - ($n < 0); } $target = -2396; $i = 0; $currentSum = 0; // Look for max $i while (true) { $val = pow(-2, $i); $candidate = $currentSum + $val; if (abs($target) <= abs($candidate)) { // Found max $i break; } if (abs($target - $candidate) < abs($target - $currentSum)) { // We are getting closer $currentSum = $candidate; } $i++; } $result = []; for ($j = $i; 0 <= $j; $j--) { $val = pow(-2, $j); $border = $val / 4; if (sign($val) == sign($target) && abs($border) < abs($target)) { array_unshift($result, 1); $target -= $val; } else { array_unshift($result, 0); } } echo json_encode($result); First I look for the $i that gets me on or slightly above the $target. When found, I walk down and decide for each bit if it should be in the result.
How to output the arguments of a Function in the Function itself
<?php $l = 4000; function flip($h, $t) { if ($h + $t <= 29) { $a = mt_rand(0, 1); if ($a == 1) { flip($h + 1, $t); } else { flip($h, $t + 1); } } else { echo "$h,$t" . "</br>"; } } $ar = array( "test"); for ($i = 0; $i <= $l; $i++) { array_push($ar, flip(0, 0)); } ?> My code is supposed to give the number of tails and heads upon spinnings 30 times. And this process is done 4000 times. I want to store all the results of the 4000 times in an array using the above code. But I think the way I defined by flip is wrong. I didn't know how to store the value of the arguments of flip after it is done therefore I used an echo. When i run this code.. for some reason it is printing out all the answers like this : http://searchr.us/testing/ip.php instead of just making an array. I have pin pointed that the way I took the vfilanl values of flip wrong. Can someone tell me the difference between echo , print and how DO i use return. When i just use return(); after echo.It gives me an error. Please clarify my doubt on how I can output these values.
You should use something like this: <?php function flip($h, $t) { if ($h + $t > 29) return $h . ',' . $t; $a = mt_rand(0, 1); return $a == 1 ? flip($h + 1, $t) : flip($h, $t + 1); } $ar = array( "test"); $l = 4000; for ($i = 0; $i <= $l; ++$i) { array_push($ar, flip(0, 0)); } ?> Note that echo outputs to the client. But you want to decide what you get when you call flip, and that is done using return.
PHP Function To Get Character Number
How can I write a function that gives me number of the character that is passed to it For example, if the funciton name is GetCharacterNumber and I pass B to it then it should give me 2 GetCharacterNumber("A") // should print 1 GetCharacterNumber("C") // should print 3 GetCharacterNumber("Z") // should print 26 GetCharacterNumber("AA") // should print 27 GetCharacterNumber("AA") // should print 27 GetCharacterNumber("AC") // should print 29 Is it even possible to achieve this ?
There is a function called ord which gives you the ASCII number of the character. ord($chr) - ord('A') + 1 gives you the correct result for one character. For longer strings, you can use a loop. <?php function GetCharacterNumber($str) { $num = 0; for ($i = 0; $i < strlen($str); $i++) { $num = 26 * $num + ord($str[$i]) - 64; } return $num; } GetCharacterNumber("A"); //1 GetCharacterNumber("C"); //3 GetCharacterNumber("Z"); //26 GetCharacterNumber("AA"); //27 GetCharacterNumber("AC"); //29 GetCharacterNumber("BA"); //53 ?>
Not very efficient but gets the job done: function get_character_number($end) { $count = 1; $char = 'A'; $end = strtoupper($end); while ($char !== $end) { $count++; $char++; } return $count; } echo get_character_number('AA'); // 27 demo This works because when you got something like $char = 'A' and do $char++, it will change to 'B', then 'C', 'D', … 'Z', 'AA', 'AB' and so on. Note that this will become the slower the longer $end is. I would not recommend this for anything beyond 'ZZZZ' (475254 iterations) or if you need many lookups like that. An better performing alternative would be function get_character_number($string) { $number = 0; $string = strtoupper($string); $dictionary = array_combine(range('A', 'Z'), range(1, 26)); for ($pos = 0; isset($string[$pos]); $pos++) { $number += $dictionary[$string[$pos]] + $pos * 26 - $pos; } return $number; } echo get_character_number(''), PHP_EOL; // 0 echo get_character_number('Z'), PHP_EOL; // 26 echo get_character_number('AA'), PHP_EOL; // 27 demo
Use range and strpos: $letter = 'z'; $alphabet = range('a', 'z'); $position = strpos($alphabet, $letter); For double letters (eg zz) you'd probably need to create your own alphabet using a custom function: $alphabet = range('a', 'z'); $dictionary = range('a','z'); foreach($alphabet AS $a1){ foreach($alphabet AS $a2) { $dictionary[] = $a1 . $a2; } } Then use $dictionary in place of $alphabet.
Here is the full code that does what you want. Tested it and works perfectly for the examples you gave. define('BASE', 26); function singleOrd($chr) { if (strlen($chr) == 1) { return (ord($chr)-64); } else{ return 0; } } function multiOrd($string) { if (strlen($string) == 0) { return 0; } elseif (strlen($string) == 1) { return singleOrd($string); } else{ $sum = 0; for($i = strlen($string) - 1; $i >= 0; $i--) { $sum += singleOrd($string[$i]) * pow(BASE, $i); } } return $sum; }
I think ord should be a more efficient way to have your number : $string = strtolower($string); $result = 0; $length = strlen($string); foreach($string as $key=>$value){ $result = ($length -$key - 1)*(ord($value)-ord(a)+1); } and result would contain what you want.
What are better ways to insert element in sorted array in PHP
I've recently send my CV to one company that was hiring PHP developers. They send me back a task to solve, to mesure if I'm experienced enough. The task goes like that: You have an array with 10k unique elements, sorted descendant. Write function that generates this array and next write three different functions which inserts new element into array, in the way that after insert array still will be sorted descendant. Write some code to measure speed of those functions. You can't use PHP sorting functions. So I've wrote function to generate array and four functions to insert new element to array. /********** Generating array (because use of range() was to simple :)): *************/ function generateSortedArray($start = 300000, $elementsNum = 10000, $dev = 30){ $arr = array(); for($i = 1; $i <= $elementsNum; $i++){ $rand = mt_rand(1, $dev); $start -= $rand; $arr[] = $start; } return $arr; } /********************** Four insert functions: **************************/ // for loop, and array copying function insert1(&$arr, $elem){ if(empty($arr)){ $arr[] = $elem; return true; } $c = count($arr); $lastIndex = $c - 1; $tmp = array(); $inserted = false; for($i = 0; $i < $c; $i++){ if(!$inserted && $arr[$i] <= $elem){ $tmp[] = $elem; $inserted = true; } $tmp[] = $arr[$i]; if($lastIndex == $i && !$inserted) $tmp[] = $elem; } $arr = $tmp; return true; } // new element inserted at the end of array // and moved up until correct place function insert2(&$arr, $elem){ $c = count($arr); array_push($arr, $elem); for($i = $c; $i > 0; $i--){ if($arr[$i - 1] >= $arr[$i]) break; $tmp = $arr[$i - 1]; $arr[$i - 1] = $arr[$i]; $arr[$i] = $tmp; } return true; } // binary search for correct place + array_splice() to insert element function insert3(&$arr, $elem){ $startIndex = 0; $stopIndex = count($arr) - 1; $middle = 0; while($startIndex < $stopIndex){ $middle = ceil(($stopIndex + $startIndex) / 2); if($elem > $arr[$middle]){ $stopIndex = $middle - 1; }else if($elem <= $arr[$middle]){ $startIndex = $middle; } } $offset = $elem >= $arr[$startIndex] ? $startIndex : $startIndex + 1; array_splice($arr, $offset, 0, array($elem)); } // for loop to find correct place + array_splice() to insert function insert4(&$arr, $elem){ $c = count($arr); $inserted = false; for($i = 0; $i < $c; $i++){ if($elem >= $arr[$i]){ array_splice($arr, $i, 0, array($elem)); $inserted = true; break; } } if(!$inserted) $arr[] = $elem; return true; } /*********************** Speed tests: *************************/ // check if array is sorted descending function checkIfArrayCorrect($arr, $expectedCount = null){ $c = count($arr); if(isset($expectedCount) && $c != $expectedCount) return false; $correct = true; for($i = 0; $i < $c - 1; $i++){ if(!isset($arr[$i + 1]) || $arr[$i] < $arr[$i + 1]){ $correct = false; break; } } return $correct; } // claculates microtimetime diff function timeDiff($startTime){ $diff = microtime(true) - $startTime; return $diff; } // prints formatted execution time info function showTime($func, $time){ printf("Execution time of %s(): %01.7f s\n", $func, $time); } // generated elements num $elementsNum = 10000; // generate starting point $start = 300000; // generated elements random range 1 - $dev $dev = 50; echo "Generating array with descending order, $elementsNum elements, begining from $start\n"; $startTime = microtime(true); $arr = generateSortedArray($start, $elementsNum, $dev); showTime('generateSortedArray', timeDiff($startTime)); $step = 2; echo "Generating second array using range range(), $elementsNum elements, begining from $start, step $step\n"; $startTime = microtime(true); $arr2 = range($start, $start - $elementsNum * $step, $step); showTime('range', timeDiff($startTime)); echo "Checking if array is correct\n"; $startTime = microtime(true); $sorted = checkIfArrayCorrect($arr, $elementsNum); showTime('checkIfArrayCorrect', timeDiff($startTime)); if(!$sorted) die("Array is not in descending order!\n"); echo "Array OK\n"; $toInsert = array(); // number of elements to insert from every range $randElementNum = 20; // some ranges of elements to insert near begining, middle and end of generated array // start value => end value $ranges = array( 300000 => 280000, 160000 => 140000, 30000 => 0, ); foreach($ranges as $from => $to){ $values = array(); echo "Generating $randElementNum random elements from range [$from - $to] to insert\n"; while(count($values) < $randElementNum){ $values[mt_rand($from, $to)] = 1; } $toInsert = array_merge($toInsert, array_keys($values)); } // some elements to insert on begining and end of array array_push($toInsert, 310000); array_push($toInsert, -1000); echo "Generated elements: \n"; for($i = 0; $i < count($toInsert); $i++){ if($i > 0 && $i % 5 == 0) echo "\n"; printf("%8d, ", $toInsert[$i]); if($i == count($toInsert) - 1) echo "\n"; } // functions to test $toTest = array('insert1' => null, 'insert2' => null, 'insert3' => null, 'insert4' => null); foreach($toTest as $func => &$time){ echo "\n\n================== Testing speed of $func() ======================\n\n"; $tmpArr = $arr; $startTime = microtime(true); for($i = 0; $i < count($toInsert); $i++){ $func($tmpArr, $toInsert[$i]); } $time = timeDiff($startTime, 'checkIfArraySorted'); showTime($func, $time); echo "Checking if after using $func() array is still correct: \n"; if(!checkIfArrayCorrect($tmpArr, count($arr) + count($toInsert))){ echo "Array INCORRECT!\n\n"; }else{ echo "Array OK!\n\n"; } echo "Few elements from begining of array:\n"; print_r(array_slice($tmpArr, 0, 5)); echo "Few elements from end of array:\n"; print_r(array_slice($tmpArr, -5)); //echo "\n================== Finished testing $func() ======================\n\n"; } echo "\n\n================== Functions time summary ======================\n\n"; print_r($toTest); Results can be found here: http://ideone.com/1xQ3T Unfortunately I was rated only 13 points out of 30 for this task (don't know how it was calculated or what exactly was taken in account). I can only assume that's because there are better ways to insert new element into sorted array in PHP. I'm searching this topic for some time now but couldn't find anything good. Maby you know of better approach or some articles about that topic? Btw on my localhost (PHP 5.3.6-13ubuntu3.6 with Suhosin-Patch, AMD Athlon(tm) II X4 620) insert2() is fastest, but on ideone (PHP 5.2.11) insert3() is fastest. Any ideas why? I suppose that array_splice() is tuned up somehow :). //EDIT Yesterday I thought about it again, and figured out the better way to do inserts. If you only need sorted structure and a way to iterate over it and your primary concern is the speed of insert operation, than the best choise would be using SplMaxHeap class. In SplMaxHeap class inserts are damn fast :) I've modified my script to show how fast inserts are. Code is here: http://ideone.com/vfX98 (ideone has php 5.2 so there won't be SplMaxHeap class) On my localhost I get results like that: ================== Functions time summary ====================== insert1() => 0.5983521938 insert2() => 0.2605950832 insert3() => 0.3288729191 insert4() => 0.3288729191 SplMaxHeap::insert() => 0.0000801086
It may just be me, but maybe they were looking for readability and maintainability as well? I mean, you're naming your variables $arr, and $c and $middle, without even bothering to place proper documentation. Example: /** * generateSortedArray() Function to generate a descending sorted array * * #param int $start Beginning with this number * #param int $elementsNum Number of elements in array * #param int $dev Maximum difference between elements * #return array Sorted descending array. */ function generateSortedArray($start = 300000, $elementsNum = 10000, $dev = 30) { $arr = array(); #Variable definition for ($i = 1; $i <= $elementsNum; $i++) { $rand = mt_rand(1, $dev); #Generate a random number $start -= $rand; #Substract from initial value $arr[] = $start; #Push to array } return $arr; }
Writing merge sort in PHP
I have tried to write a basic merge sort in PHP involving a small array, yet the problem is it takes about a minute or so to execute, and returns: Fatal error: Allowed memory size of 536870912 bytes exhausted (tried to allocate 35 bytes) in /Users/web/www/merge.php on line 39 Does anyone have an idea where the code might be going wrong (if at all)? I've been staring at this for a good hour now. <?php $array = array(8,1,2,5,6,7); print_array($array); merge_sort($array); print_array($array); function merge_sort(&$list){ if( count($list) <= 1 ){ return $list; } $left = array(); $right = array(); $middle = (int) ( count($list)/2 ); // Make left for( $i=0; $i < $middle; $i++ ){ $left[] = $list[$i]; } // Make right for( $i = $middle; $i < count($list); $i++ ){ $right[] = $list[$i]; } // Merge sort left & right merge_sort($left); merge_sort($right); // Merge left & right return merge($left, $right); } function merge(&$left, &$right){ $result = array(); while(count($left) > 0 || count(right) > 0){ if(count($left) > 0 && count(right) > 0){ if($left[0] <= $right[0]){ $result[] = array_shift($left); } else { $result[] = array_shift($right); } } elseif (count($left) > 0){ $result[] = array_shift($left); } elseif (count($right) > 0){ $result[] = array_shift($right); } } print_array($result);exit; return $result; } function print_array($array){ echo "<pre>"; print_r($array); echo "<br/>"; echo "</pre>"; } ?>
In your merge function, you call count on right instead of $right. PHP assumes this is a string constant (at least in 5.3.9) and when casted into an array that always has one element. So count(right) is always one, and you never exit the first merge.
Try this approach. Instead of shifting it, slice. Also, for in while loop for the merge function, you need to do an and && comparison instead of || function mergeSort($array) { if(count($array) == 1 ) { return $array; } $mid = count($array) / 2; $left = array_slice($array, 0, $mid); $right = array_slice($array, $mid); $left = mergeSort($left); $right = mergeSort($right); return merge($left, $right); } function merge($left, $right) { $res = array(); while (count($left) > 0 && count($right) > 0) { if($left[0] > $right[0]) { $res[] = $right[0]; $right = array_slice($right , 1); } else { $res[] = $left[0]; $left = array_slice($left, 1); } } while (count($left) > 0) { $res[] = $left[0]; $left = array_slice($left, 1); } while (count($right) > 0) { $res[] = $right[0]; $right = array_slice($right, 1); } return $res; }
Have a look at this, the algorithm is already implemented, using array_push and array splice instead of just array_shift. http://www.codecodex.com/wiki/Merge_sort#PHP
I implement merge sort this way function mergeSort($Array) { $len = count($Array); if($len==1){ return $Array; } $mid = (int)$len / 2; $left = mergeSort(array_slice($Array, 0, $mid)); $right = mergeSort(array_slice($Array, $mid)); return merge($left, $right); } function merge($left, $right) { $combined = []; $totalLeft = count($left); $totalRight = count($right); $rightIndex = $leftIndex=0; while ($leftIndex < $totalLeft && $rightIndex < $totalRight) { if ($left[$leftIndex] > $right[$rightIndex]) { $combined[]=$right[$rightIndex]; $rightIndex++; }else { $combined[] =$left[$leftIndex]; $leftIndex++; } } while($leftIndex<$totalLeft){ $combined[]=$left[$leftIndex]; $leftIndex++; } while ($rightIndex<$totalRight){ $combined[] =$right[$rightIndex]; $rightIndex++; } return $combined; }
Here is the class in PHP to implement the Merge Sort - <?php class mergeSort{ public $arr; public function __construct($arr){ $this->arr = $arr; } public function mSort($l,$r){ if($l===null || $r===null){ return false; } if ($l < $r) { // Same as ($l+$r)/2, but avoids overflow for large $l and $r $m = $l+floor(($r-$l)/2); // Sort first and second halves $this->mSort($l, $m); $this->mSort($m+1, $r); $this->merge($l, $m, $r); } } // Merges two subarrays of $this->arr[]. First subarray is $this->arr[$l..$m]. Second subarray is $this->arr[$m+1..$r] public function merge($l, $m, $r) { if($l===null || $m===null || $r===null){ return false; } $n1 = $m - $l + 1; $n2 = $r - $m; /* create temp arrays */ $L=array(); $R=array(); /* Copy data to temp arrays $L[] and $R[] */ for ($i = 0; $i < $n1; $i++) $L[$i] = $this->arr[$l + $i]; for ($j = 0; $j < $n2; $j++) $R[$j] = $this->arr[$m + 1+ $j]; /* Merge the temp arrays back into $this->arr[$l..$r]*/ $i = 0; // Initial index of first subarray $j = 0; // Initial index of second subarray $k = $l; // Initial index of merged subarray while ($i < $n1 && $j < $n2) { if($L[$i] <= $R[$j]) { $this->arr[$k] = $L[$i]; $i++; } else { $this->arr[$k] = $R[$j]; $j++; } $k++; } /* Copy the remaining elements of $L[], if there are any */ while($i < $n1) { $this->arr[$k] = $L[$i]; $i++; $k++; } /* Copy the remaining elements of $R[], if there are any */ while($j < $n2) { $this->arr[$k] = $R[$j]; $j++; $k++; } } } $arr = array(38, 27, 43, 5, 9, 91, 12); $obj = new mergeSort($arr); $obj->mSort(0,6); print_r($obj->arr); ?>
I was looking for a optimized Mergesort algorithm in PHP. There are 5 algorithms in the answers, so I tested those, and mine too. Using PHP 7.2.7, these are the times: Sorting 1000 random numbers: Avanche 1 0.0396 seconds Avanche 2 0.0347 seconds Kartik 0.0291 seconds Kripa 0.0282 seconds Samuel 0.0247 seconds Mine 0.0144 seconds Sorting 10 random numbers: Avanche 1 0.000222 seconds Kartik 0.000216 seconds Kripa 0.000159 seconds Avanche 2 0.000144 seconds Samuel 0.000128 seconds Mine 0.000098 seconds So, although I encourage to whom read it to make it faster (that was I was looking for, and I believe it can be done), I let you my implementation too, cause seems to be faster than the other answers: //This function needs start and end limits function mergeSortRec(&$a,$start,$end){ if($start<$end){ $center=($start+$end)>>1; //Binary right shift is like divide by 2 mergeSortRec($a, $start, $center); mergeSortRec($a, $center+1, $end); //Mixing the 2 halfs $aux=array(); $left=$start; $right=$center; //Main loop while($left<$center && $right<=$end){ if($a[$left]<$a[$right]){ $aux[]=$a[$left++]; }else{ $aux[]=$a[$right++]; } } //Copy the rest of the first half while($left<$center) $aux[]=$a[$left++]; //Copy the rest of the second half while($right<=$end) $aux[]=$a[$right++]; //Copy the aux array to the main array foreach($aux as $v) $a[$start++]=$v; } } //This is the function easier to call function mergeSort(&$a) { mergeSortRec($a,0,count($a)-1); } If you post a new answer, let me a comment to test it and add it. Edit: I did some new optimizations, for those looking for a better implementation.
Your merge sort accepts a list by reference function merge_sort(&$list) So you need to assign it the new merged and sorted list. So instead of return merge($left, $right); do $list = $this->merge($left, $right); That should do it, just remove the exit and fix the count variable
MergeSort in PHP <?php class Solution { function mergeSort(&$arr) { if(count($arr) > 1) { $mid = floor(count($arr)/2); $left = array_slice($arr, 0, $mid); $right = array_slice($arr, $mid); $this->mergeSort($left); $this->mergeSort($right); // Merge the results. $i = $j = $k = 0; while(($i < count($left)) && ($j < count($right))) { if($left[$i] < $right[$j]) { $arr[$k] = $left[$i]; $i++; } else { $arr[$k] = $right[$j]; $j++; } $k++; } while($i < count($left)) { $arr[$k] = $left[$i]; $i++; $k++; } while($j < count($right)) { $arr[$k] = $right[$j]; $j++; $k++; } } } } $s = new Solution(); $tmp = [12, 7, 11, 13, 5, 6, 7]; $s->mergeSort($tmp); print_r($tmp);