php | more effective function [closed] - php

Question

Closed. This question does not meet Stack Overflow guidelines. It is not currently accepting answers.
This question does not appear to be about programming within the scope defined in the help center.
Closed 9 years ago.
Improve this question
I have a function and it works. Please check below:
public static function checkAccessLevel($user, $level) {
public static function checkLevel($user, $level) {
if ($level == "1") {
if (!$user->usertype == 1) {
return array(
'error' => 'Please login before', 'errortype' => 0
);
}
} else if ($level == "2") {
if (!$user->usertype == 2) {
return array(
'error' => 'Please login before', 'errortype' => 0
);
}
} else if ($level == "1,2") {
if (!$user->usertype == 1 || !$user->usertype == 2) {
return array(
'error' => 'Please login before', 'errortype' => 0
);
}
} else {
return array(
'error' => 'Please login before', 'errortype' => 0
);
}
}
I'm looking the way for code optimization. Is it possible to rewrite this function?

Answer 1

$level is always comma separated, just break it and check:
public static function checkLevel($user, $level)
{
$level = explode(',', $level);
if(!in_array($user->usertype, $level))
return array(
'error' => 'Please login before',
'errortype' => 0
);
}
and better yet, throw an Exception or return a boolean.

Answer 2

public static function checkLevel($user, $level)
{
if (($level == "1" && ! $user->usertype == 1) ||
($level == "2" && ! $user->usertype == 2) ||
($level == "1,2" && ! in_array($user->usertype, array(1, 2))) ||
! in_array($level, array("1", "2", "1,2"))) {
return array(
'error' => 'Please login before', 'errortype' => 0
);
}
}

Answer 3

First of all consider using switch, it should be more readable.
Then you may group your conditions, instead of:
} else if ($level == "1,2") {
if (!$user->usertype == 1 || !$user->usertype == 2) {
group them together:
(($level == "1,2") && (!$user->usertype == 1 || !$user->usertype == 2))
Then you may use temporary variable $result:
$result = array('Please login...
and return it at the end, instead of using return keyword in every step, it should help you in debugging.
Also I suggest to read Martin Fowlers book about refactoring which will give you many good advice.

Answer 4

You could use a switch statement instead of an if statement, like so:
public static function checkLevel($user, $level) {
$result = array();
switch($level) {
case '1':
if( $user->usertype == 1) {
$result = array(
'error' => 'Please login before', 'errortype' => 0
);
}
break;
// More cases for each level.
default:
$result = array(
'error' => 'Please login before', 'errortype' => 0
);
}
return $result;
}