what did i do is creating this vies for delete function according to its trainee_id.see the screenshot.
Controller segment is like this
public function admin_destroy($trainee_id)
{
UserFeedbackController::where('trainee_id','=',$trainee_id)->delete();
return back();
}
Route like this
Route::get('DeleteCertificates/{trainee_id?}', 'UserFeedbackController#admin_destroy')->where('trainee_id', '(.*)');;
linked button in the view as following this
<td>
<a class="btn btn-danger" href="DeleteCertificates/{{ $item->trainee_id }}">Delete</a>
</td>
here is the error.
can anyone suggest me why this getting error.
you are calling the controller name in place of model name, guess the modelname is
UserFeedback
so use this
UserFeedback::where('trainee_id','=',$trainee_id)->delete();
Related
I'm working with Laravel 8 to develop my forum project, and I wanted to add some like functionality to question that has been asked on forum by users.
So here is a form on question.blade.php:
<form action="{{ route('questions.likes', $show->id) }}" method="POST">
#csrf
<button class="btn">
<i class="fas fa-thumbs-up"></i> <span>{{ $show->likes->count() }}</span>
</button>
</form>
And then at LikeController, I added this:
public function store(Question $id, Request $request)
{
$id->likes()->create([
'user_id' => $_REQUEST->user()->id,
]);
return back();
}
But now I get this error:
Call to a member function user() on array
Which is referring to this line:
'user_id' => $_REQUEST->user()->id,
So what is going wrong here? I need to pass the user id who pressed on like button in order to update likes table. How can I solve this issue?
I would really appreciate if you share any idea or suggestion about this with me...
Thanks in advance.
replace 'user_id' => $_REQUEST->user()->id;
with 'user_id' => $request->user();
edit : reason to the error
$_REQUEST is an associative array that by default contains the contents of $_GET, $_POST and $_COOKIE.this belongs to core PHP, not to the Laravel. that array doesn't have connection with laravel user() object
so that why the Call to a member function user() on array thrown.
$request is instance of lluminate\Http\Request this object have access to current authenticated user
I need to delete booking by ID in my sub event id
Route::delete('event/{id}/booking/{id}', 'bookingController#destroy');
My Controller
public function destroy($id)
{
booking::destroy($booking->id);
return redirect('event')->with('flash_message', 'ลบข้อมูลการสำรองที่นั่งเรียบร้อย');
}
My from Method Delete
<form method="POST" action="{{ url('event/' . $event->id .'/booking/' . $booking->id) }}" accept-charset="UTF-8" style="display:inline">
{{ method_field('DELETE') }}
{{ csrf_field() }}
<button type="submit" class="btn btn-danger btn-sm" title="Delete event" onclick="return confirm("Confirm delete?")"><i class="fa fa-trash-o" aria-hidden="true"></i>ยกเลิกการจอง</button>
</form>
Your route has two variables (event_id) and (booking_id), yet your method only has one ($id)
Using your existing route (which is not tbh adhering to how eloquent works)
web.php
Route::delete('event/{event_id}/booking/{booking_id}', 'bookingController#destroy')->name('booking.destroy');
blade
action = "{{ route('booking.destroy', $event_id, $booking_id) }}"
controller
public function destroy ($booking_id, $event_id)
You might want to take a look at laravel relationships here:
https://laravel.com/docs/6.x/eloquent-relationships
Will make your life much easier, thus eloquent will pass an instance and your destroy method will look like this
public function destroy (Booking $booking)
{
$event = $booking->event();
// Do something with related event
// or vice versa
}
Are the IDs two separate IDs? Or do they share the same ID?
If they are two separate IDs, then you need to give them two explicitly different names, e.g. booking_id and event_id and then you would be able to access them in the Controller like you want.
Route::delete('event/{event_id}/booking/{booking_id}', 'bookingController#destroy');
Then in your controller you can do
public function destroy($event_id, $booking_id)
{
...
}
If I recall correctly, the parameters in the controller method do not need to be named the exact same as the ones in the route (although it'd make your life easier). The parameters are passed in order, so you could do
//$A = event_id, $B = booking_id
public function destroy($A, $B)
{
...
}
I am sort of new to the Laravel framework and I am building just a simple blog. I can create a blog, show a blog and show a overview of all blogs. Now I would like to delete a blog. So, I have created a delete button in my view with a route link which will pass also the id of the article. Then, in my routes file I specify a delete request and a controller method. In the method I find the id and try to delete the row with the id I specified in the route/view.
This doesn't work. Instead of activate the destroy/delete method it shows the article instead of deleting it and activates the show method instead of the delete method. Can somebody help me out, What do I wrong?
View.blade.php
<a href="{{route('nieuws.destroy', ['id' => $blog->id])}}" onclick="return confirm('Weet je dit zeker?')">
<i class="fa fa-trash"></i>
</a>
Route
Route::group(['middleware' => 'auth'], function () {
Route::get('/aanvragen', 'aanvragenController#index')->name('aanvragen.index');
Route::get('/logout' , 'Auth\LoginController#logout')->name('logout');
Route::get('/nieuws/toevoegen', 'blogController#create')->name('blogs.add');
Route::post('/nieuws/store', 'blogController#store')->name('nieuws.store');
Route::delete('/nieuws/{id}', 'blogController#destroy')->name('nieuws.destroy');
});
Route::get('/nieuws', 'blogController#index')->name('blogs.index');
Route::get('/nieuws/{blog}', 'blogController#show')->name('blogs.show');
Controller methods
Delete/Destroy
public function destroy($id) {
$blog = Blog::find($id);
$blog->delete();
return redirect('/nieuws');
}
Show
public function show(Blog $blog) {
dd('show');
return view('blogs.show', compact('blog'));
}
A delete() route requires you to POST your data.
HTML forms only supports GET and POST, other methods like DELETE, PUT, etc are not supported, that's why Laravel uses the _method to spoof methods which are not supported by HTML forms.
You do not want use GET in these cases, since someone can send a user the url (http://yoursite.com/blog/delete/1) in an IM or via email. The user clicks and the blog is gone.
Define your route as it would be when using resource controllers, so:
Route::delete('/nieuws/{id}', 'blogController#destroy')->name('nieuws.destroy');
And either use a form with the delete method:
// apply some inline form styles
<form method="POST" action="{{ route('nieuws.destroy', [$blog->id]) }}">
{{ csrf_field() }}
{{ method_field('DELETE') }}
<button type="submit">Delete</button>
</form>
Or do some javascript magic as the link SR_ posted in his comment on your OP.
One more thing, add some sort of validation in your destroy action. Right now when you provide a non-existing id or something else, you will get a 500 error, instead you want to have a 404.
public function destroy($id)
{
$blog = Blog::findOrFail($id);
$blog->delete();
return redirect('/nieuws');
}
I think you need to update your destroy function like:
public function destroy($id) {
$blog = DB::table('blog')->where('id',$id)->delete();
return redirect('/nieuws');
}
And update your view code like:
<a href="{{route('nieuws.destroy', [$blog->id])}}" onclick="return confirm('Weet je dit zeker?')">
<i class="fa fa-trash"></i>
</a>
Hope this work for you!
I'm also new to Laravel but I made it work through this way:
(I use 'Article' as the model's name and the resource "method" in the route stands for a bunch of useful routes including the route you wrote)
Controller:
public function destroy($id){
Article::find($id)->delete();
//$article = Article::find($id);
return redirect()->back()->withErrors('Successfully deleted!');
}
Route:
Route::resource('article','ArticleController');
However, I think the problem lies in the default definition of database's name of your model. Laravel will assume that you have a database named blogs since you have a model named "blog". Are you having the database's name right?
To use DELETE HTTP Verb, your form should consists of the POST method and settings the method_field('DELETE')
Example:
<form method="POST" action="{{ route('xxx.destroy', $xxx->id) }}">
{{ csrf_field }}
{{ method_field('DELETE') }}
</form>
As mentioned in the title I get the error "Property [id] does not exist on this collection instance." Only when I run the code online here are my relevant codes.
1-EmployeeController (browser tells me that the error is here the second line)
public function show(Employee $employee)
{
$employee = Employee::find ($employee);
$edocument = EDocument::where ('employee_id',$employee->id)->first();
return view ('employee.show')->withEmployee($employee)->withEdocument($edocument);
}
2-show.blade.php
<div class="jumbotron">
<h1>{{$employee->name}} ({{$employee->position}})</h1>
#if (isset($edocument))
Go To Employee Database Page
#else
<p class="lead bg-danger">Employee documents are not uploaded</p>
#endif
Create Employee Contract
if anyone can explain to me this error in more details that would be great also. thanks
ps.. this is my first laravel project (;
You use route model binding in your controller method to get the Employee model. But you also run a find, which would fail since you're passing the model instead of the id. Do as one of the codes shown below and don't mix them.
Do this if you want to use route model binding.
public function show(Employee $employee)
{
$edocument = EDocument::where ('employee_id', $employee->id)->first();
return view ('employee.show')->with(compact('employee', 'edocument'));
}
Do this if you want to pass the employee id and fetch the model in controller.
public function show($employee)
{
$employee = Employee::find($employee);
$edocument = EDocument::where ('employee_id', $employee->id)->first();
return view ('employee.show')->with(compact('employee', 'edocument'));
}
Maybe this can help you. Why don't you pass the information in the controller using -
return view('employee.show', ['employee' => $employee, 'edocument'=>$edocument]);
It worked for me. (Do not have to change anything in the show.blade .php)
I am trying to delete a category by clicking on a button
Blade:
<td class="center"><span class="glyphicon glyphicon-trash"></span></td>
Route:
Route::get('/deletecat/{name}','CategoryController#delete');
Controller:
public function delete($name)
{
category::find($name)->delete();
return Redirect::route('managecategory');
}
but I am getting an error while clicking on a button that
Call to a member function delete() on a non-object
Any help appreciated.
The ::find($id) method expects $id to be a number, the primary key of the row you want to find.
If you want to delete a row by name, you should use the following code:
category::where('name', $name)->delete();
The error is obviously because of the returned NON-OBJECT.
::find($name) returns an empty object or null
This is because the search was empty.
Make sure name is the primary key in order to use find.
Otherwise:
use ::where('name', $name)->delete();
or:
::where('name','=', $name)->delete();
*I pointed = because if you ever need to search different than = use >= <> and so on...
Secondly, it is not very important to use destroy. It is recommended but not a must-have!
In your view:
it has to be a form to submit a POST request like below:
<form action="/deletecat/{{$data->id}}" method="post">
#csrf
#method('DELETE')
<input type="submit" value="delete " >
</form>
Because this is POST Request has to use csrf and delete action.
In your route, it has be with delete() method,followwing with the controller.
Route::delete('/deletecat/{name}', 'CategoryController#destory');
In the controller:
public function destory($name)
{
category::find($name)->delete();
return Redirect::route('managecategory');
}
This is how laravel name format role: