cannot reference variable name "id" more than once - php

I need to delete booking by ID in my sub event id
Route::delete('event/{id}/booking/{id}', 'bookingController#destroy');
My Controller
public function destroy($id)
{
booking::destroy($booking->id);
return redirect('event')->with('flash_message', 'ลบข้อมูลการสำรองที่นั่งเรียบร้อย');
}
My from Method Delete
<form method="POST" action="{{ url('event/' . $event->id .'/booking/' . $booking->id) }}" accept-charset="UTF-8" style="display:inline">
{{ method_field('DELETE') }}
{{ csrf_field() }}
<button type="submit" class="btn btn-danger btn-sm" title="Delete event" onclick="return confirm("Confirm delete?")"><i class="fa fa-trash-o" aria-hidden="true"></i>ยกเลิกการจอง</button>
</form>

Your route has two variables (event_id) and (booking_id), yet your method only has one ($id)
Using your existing route (which is not tbh adhering to how eloquent works)
web.php
Route::delete('event/{event_id}/booking/{booking_id}', 'bookingController#destroy')->name('booking.destroy');
blade
action = "{{ route('booking.destroy', $event_id, $booking_id) }}"
controller
public function destroy ($booking_id, $event_id)
You might want to take a look at laravel relationships here:
https://laravel.com/docs/6.x/eloquent-relationships
Will make your life much easier, thus eloquent will pass an instance and your destroy method will look like this
public function destroy (Booking $booking)
{
$event = $booking->event();
// Do something with related event
// or vice versa
}

Are the IDs two separate IDs? Or do they share the same ID?
If they are two separate IDs, then you need to give them two explicitly different names, e.g. booking_id and event_id and then you would be able to access them in the Controller like you want.
Route::delete('event/{event_id}/booking/{booking_id}', 'bookingController#destroy');
Then in your controller you can do
public function destroy($event_id, $booking_id)
{
...
}
If I recall correctly, the parameters in the controller method do not need to be named the exact same as the ones in the route (although it'd make your life easier). The parameters are passed in order, so you could do
//$A = event_id, $B = booking_id
public function destroy($A, $B)
{
...
}

Related

Route resource destroy not working laravel

I have a user_transaction table and I am trying to delete a record in the table but I am not successful.
UserTransaction.php
protected $table = 'user_transaction';
blade
<form action="{{ route('transactions.destroy', $transaction->id) }}" method="post" >
#method('delete')
#csrf
<button type="submit" class="btn btn-default p-0">
<i class="ft-trash-2 text-grey font-medium-5 font-weight-normal"></i>
</button>
</form>
web.php
Route::resource('transactions', 'Admin\TransactionController');
TransactionController.php
public function destroy(UserTransaction $userTransaction)
{
dd($userTransaction->id);
$userTransaction->delete();
return redirect()->route('transactions.index');
}
This code show null
The likely cause of this is a naming mismatch between your resource route parameter and the name of the variable used in your resource controller for route model binding.
By default resource routes use the singlar of the resource you provide in the route definition as the route parameter. So in your example:
Route::resource('transactions', 'Admin\TransactionController');
The above will produce some routes like the following:
GET|HEAD | /transactions/{transaction}
DELETE | /transactions/{transaction}
GET|HEAD | /transactions/{transaction}/edit
For route model binding to work, the route parameter name and the name of the variable used in your controller need to match.
So what you need to do is change the name of the variable used in your controller:
public function destroy(UserTransaction $transaction)
{
dd($transaction->id);
$transaction->delete();
return redirect()->route('transactions.index');
}

Property [id] does not exist on this collection in Form

I designed form to save data in Laravel
and this problem shows me the following error
Property [id] does not exist on this collection instance.
This is my Code
Controller
public function create ()
{
$post = Post::all();
return view ("post.create",compact('post'));
}
view create.blade.php
<form action="{{url()->action ('PostController#store', ['id'=>$post->id])}}" method="POST">
<input type="text" name="title" placeholder="Write Title">
<input type="text" name="body" placeholder="Write Body">
<input type="submit" value="Submit" name="submit">
</form>
I know the problem is here, but I don't know what I can do
'PostController#store', ['id'=>$post->id])}}" method="POST"
This will return the collection
$post = Post::all();
Instead, pass one object to the view by using
$post = Post::first();
or if u want to check particular post or any other condition you can use where clause to it..
eg: $post = Post::where('id',$user_id)->first(); // It will return single row...It will solve your problem
The problem is that you are sending a collection of Post models to your view. The $post variable contains a collection of Post models, which means that the collection will not have an id because it is a collection, not a single Post.
This:
$post = Post::all();
returns a collection.
Because this is a create method, you may wish to new up a Post model:
$post = new Post();
and add a few things to it and save it before sending to the view to get an id, OR, probably more useful: you can open the form without form-model binding since you don't actually have a Post model created yet -- just remove the ['id'=>$post->id] part since there is no post to have an id at the time the form is created.
You can make it look cleaner for the route.
web.php
Route::post('/myform/store', 'PostController#store')->name('post.store');
In your view, you can use the route name you just created.
<form action="{{ route('post.store', ['id' => $post->id]) }}" method="post">
But since you don't have column of 'id' in your Post then it returns the error you getting. Try creating a column 'id' first to resolve your problem.
I agree with #Watercayman on using model-binding instead, it's quick and makes the code more readable (and understandable too). Since Laravel quickly matches 'id' with unique id in the database. Take a look here for route parameters (how you can pass your data through URLs) and how to access your parameter here.
Using model binding will return you a collection.
public function store(Post $post)
Your $post variable is a collection so if you want to access your 'id' column you will do $post->id.

Delete data from the database with Laravel 5.4

I am sort of new to the Laravel framework and I am building just a simple blog. I can create a blog, show a blog and show a overview of all blogs. Now I would like to delete a blog. So, I have created a delete button in my view with a route link which will pass also the id of the article. Then, in my routes file I specify a delete request and a controller method. In the method I find the id and try to delete the row with the id I specified in the route/view.
This doesn't work. Instead of activate the destroy/delete method it shows the article instead of deleting it and activates the show method instead of the delete method. Can somebody help me out, What do I wrong?
View.blade.php
<a href="{{route('nieuws.destroy', ['id' => $blog->id])}}" onclick="return confirm('Weet je dit zeker?')">
<i class="fa fa-trash"></i>
</a>
Route
Route::group(['middleware' => 'auth'], function () {
Route::get('/aanvragen', 'aanvragenController#index')->name('aanvragen.index');
Route::get('/logout' , 'Auth\LoginController#logout')->name('logout');
Route::get('/nieuws/toevoegen', 'blogController#create')->name('blogs.add');
Route::post('/nieuws/store', 'blogController#store')->name('nieuws.store');
Route::delete('/nieuws/{id}', 'blogController#destroy')->name('nieuws.destroy');
});
Route::get('/nieuws', 'blogController#index')->name('blogs.index');
Route::get('/nieuws/{blog}', 'blogController#show')->name('blogs.show');
Controller methods
Delete/Destroy
public function destroy($id) {
$blog = Blog::find($id);
$blog->delete();
return redirect('/nieuws');
}
Show
public function show(Blog $blog) {
dd('show');
return view('blogs.show', compact('blog'));
}
A delete() route requires you to POST your data.
HTML forms only supports GET and POST, other methods like DELETE, PUT, etc are not supported, that's why Laravel uses the _method to spoof methods which are not supported by HTML forms.
You do not want use GET in these cases, since someone can send a user the url (http://yoursite.com/blog/delete/1) in an IM or via email. The user clicks and the blog is gone.
Define your route as it would be when using resource controllers, so:
Route::delete('/nieuws/{id}', 'blogController#destroy')->name('nieuws.destroy');
And either use a form with the delete method:
// apply some inline form styles
<form method="POST" action="{{ route('nieuws.destroy', [$blog->id]) }}">
{{ csrf_field() }}
{{ method_field('DELETE') }}
<button type="submit">Delete</button>
</form>
Or do some javascript magic as the link SR_ posted in his comment on your OP.
One more thing, add some sort of validation in your destroy action. Right now when you provide a non-existing id or something else, you will get a 500 error, instead you want to have a 404.
public function destroy($id)
{
$blog = Blog::findOrFail($id);
$blog->delete();
return redirect('/nieuws');
}
I think you need to update your destroy function like:
public function destroy($id) {
$blog = DB::table('blog')->where('id',$id)->delete();
return redirect('/nieuws');
}
And update your view code like:
<a href="{{route('nieuws.destroy', [$blog->id])}}" onclick="return confirm('Weet je dit zeker?')">
<i class="fa fa-trash"></i>
</a>
Hope this work for you!
I'm also new to Laravel but I made it work through this way:
(I use 'Article' as the model's name and the resource "method" in the route stands for a bunch of useful routes including the route you wrote)
Controller:
public function destroy($id){
Article::find($id)->delete();
//$article = Article::find($id);
return redirect()->back()->withErrors('Successfully deleted!');
}
Route:
Route::resource('article','ArticleController');
However, I think the problem lies in the default definition of database's name of your model. Laravel will assume that you have a database named blogs since you have a model named "blog". Are you having the database's name right?
To use DELETE HTTP Verb, your form should consists of the POST method and settings the method_field('DELETE')
Example:
<form method="POST" action="{{ route('xxx.destroy', $xxx->id) }}">
{{ csrf_field }}
{{ method_field('DELETE') }}
</form>

Laravel Method [where] does not exist error

what did i do is creating this vies for delete function according to its trainee_id.see the screenshot.
Controller segment is like this
public function admin_destroy($trainee_id)
{
UserFeedbackController::where('trainee_id','=',$trainee_id)->delete();
return back();
}
Route like this
Route::get('DeleteCertificates/{trainee_id?}', 'UserFeedbackController#admin_destroy')->where('trainee_id', '(.*)');;
linked button in the view as following this
<td>
<a class="btn btn-danger" href="DeleteCertificates/{{ $item->trainee_id }}">Delete</a>
</td>
here is the error.
can anyone suggest me why this getting error.
you are calling the controller name in place of model name, guess the modelname is
UserFeedback
so use this
UserFeedback::where('trainee_id','=',$trainee_id)->delete();

Laravel 5.1 Delete a row from database

I am trying to delete a category by clicking on a button
Blade:
<td class="center"><span class="glyphicon glyphicon-trash"></span></td>
Route:
Route::get('/deletecat/{name}','CategoryController#delete');
Controller:
public function delete($name)
{
category::find($name)->delete();
return Redirect::route('managecategory');
}
but I am getting an error while clicking on a button that
Call to a member function delete() on a non-object
Any help appreciated.
The ::find($id) method expects $id to be a number, the primary key of the row you want to find.
If you want to delete a row by name, you should use the following code:
category::where('name', $name)->delete();
The error is obviously because of the returned NON-OBJECT.
::find($name) returns an empty object or null
This is because the search was empty.
Make sure name is the primary key in order to use find.
Otherwise:
use ::where('name', $name)->delete();
or:
::where('name','=', $name)->delete();
*I pointed = because if you ever need to search different than = use >= <> and so on...
Secondly, it is not very important to use destroy. It is recommended but not a must-have!
In your view:
it has to be a form to submit a POST request like below:
<form action="/deletecat/{{$data->id}}" method="post">
#csrf
#method('DELETE')
<input type="submit" value="delete " >
</form>
Because this is POST Request has to use csrf and delete action.
In your route, it has be with delete() method,followwing with the controller.
Route::delete('/deletecat/{name}', 'CategoryController#destory');
In the controller:
public function destory($name)
{
category::find($name)->delete();
return Redirect::route('managecategory');
}
This is how laravel name format role:

Categories