Greeting Message Not Change PHP - php

Question

I'm Write code for greeting message using php. and its correct. but not changing messages. only one message shown "Good morning". there is another way to write code for greeting message or. can i changes in my code and how to do? please help.
<?php
function greeting_msg()
{
$hour = date('h');
if ($hour >= 20) {
echo "Good Night!";
} elseif ($hour > 17) {
echo "Good Evening!";
} elseif ($hour > 11) {
echo "Good Afternoon!";
} elseif ($hour < 12) {
echo "Good Morning!";
}
}
?>

Answer 1

Related to the documentation of the PHP date function, your code is not correct.
date('H'); // 24 hours with leading zeros
date('h'); // 12 hours with leading zeros
date('G'); // 24 without leading zeros
So your code is ending up with values up to twelve and it 's correct, that the 'Good Morning!' message is displayed.
Next you have to check the value of your $hour variable. Just dump the value with code looking something like this ...
echo "<pre>";
var_dump($hour);
echo "</pre>";
As long as the PHP date() function is returning strings as a result of the given format, you can run into several problems.
date('h'); // could be '03' ('03' != 3)
date('H'); // could also be '03' ('03' != 3)
date('G'); // results into '3' (3 == 3)
Then look at your if/else conditions. Does the expected value fit in your conditions? Guess the value is 20.
The value 20 would fit your first three conditions. The first condition is executed and so you 'll get the expected result 'Good night!'.
Just test your code this way.

Answer 2

First you need to change H instead of h to get 24 hour i.e
date('H'); // 24 hours
date('h'); // 12 hours
then you need to add few more condtions to get correct messages
$hour = date('H');
if ($hour > 5 && $hour < 10) {
echo 'Good Morning';
} elseif ($hour > 11 && $hour < 17) {
echo 'Good Afternoon';
} elseif ($hour > 17 && $hour < 20) {
echo 'Good Evening';
} else {
echo 'Good Night';
}
die;

Answer 3

I've made small testing of your code and here is what we have
function greeting_msg($hour)
{
$hour = $hour ?: date('H');
if ($hour >= 20) {
return "Good Night!";
} elseif ($hour > 17) {
return "Good Evening!";
} elseif ($hour > 11) {
return "Good Afternoon!";
} elseif ($hour < 12) {
return "Good Morning!";
}
}
$hoursRange = range(1, 24); // contain range between 1 to 24
foreach ($hoursRange as $range) {
echo sprintf('For %d message is: %s <br>', $range, greeting_msg($range));
}
Output in your case is
For 1 message is: Good Morning!
For 2 message is: Good Morning!
For 3 message is: Good Morning!
For 4 message is: Good Morning!
For 5 message is: Good Morning!
For 6 message is: Good Morning!
For 7 message is: Good Morning!
For 8 message is: Good Morning!
For 9 message is: Good Morning!
For 10 message is: Good Morning!
For 11 message is: Good Morning!
For 12 message is: Good Afternoon!
For 13 message is: Good Afternoon!
For 14 message is: Good Afternoon!
For 15 message is: Good Afternoon!
For 16 message is: Good Afternoon!
For 17 message is: Good Afternoon!
For 18 message is: Good Evening!
For 19 message is: Good Evening!
For 20 message is: Good Night!
For 21 message is: Good Night!
For 22 message is: Good Night!
For 23 message is: Good Night!
For 24 message is: Good Night!
Which mean that your system is saying "Good morning" starting from 01:00, which isn't true. I've made some minor changed to your conditions:
function greeting_msg()
{
$hour = date('H');
if ($hour >= 20 || $hour < 5) {
return "Good Night!";
} elseif ($hour > 17) {
return "Good Evening!";
} elseif ($hour > 11) {
return "Good Afternoon!";
} else {
return "Good Morning!";
}
}
I don't know is 05:00 is Morning for somebody, but I've set it :) And now range from 20:00 to 05:00 is showing "Good Night".
Also, don't forget that server time can have different timezone from yours.

Answer 4

The difference between date('h') and date('H') is that one is using the 24-hour format (H) and one is using the 12-hour format (h). So, when you do date('h'), you will always get values from 0-12.
From the date manual,
| Format | Description | Values |
|--------|--------------------------------------------------|---------------|
| h | 12-hour format of an hour with leading zeros | 01 through 12 |
| H | 24-hour format of an hour with leading zeros | 00 through 23 |
This means that the behavior you are describing is correct, as date('h') will be no more than 12, and you are checking for date('h') < 12, a condition that will always be true.
Using date('H'), and some minor adjustments is shown below (we echo the result of the function, not inside it, and some logical changes to simplify readability).
function greeting_msg() {
$hour = date('H');
if ($hour > 20 || $hour < 5) {
return "Good night";
} elseif ($hour > 17) {
return "Good evening";
} elseif ($hour > 12) {
return "Good afternoon";
} else {
return "Good morning";
}
}
echo greeting_msg();
Test of all hours where we mimic the 24 hours at https://3v4l.org/B8qC0
PHP.net on date()

Answer 5

public function greeting_msg() {
date_default_timezone_set('Europe/Brussels');
$hour = date('H');
if ($hour >= 04 && $hour < 11) {
$greeting = "Goedenmorgen";
} elseif ($hour == 11) {
$greeting = "Goedemiddag";
} elseif ($hour >= 11 && $hour <= 17) {
$greeting = "Goedemiddag";
} elseif ($hour >= 17 && $hour <= 23) {
$greeting = "Goedenavond";
} else {
$greeting = "Goedennacht";
}
return $greeting;
}