Problem when uploading and saving image in database - php

Question

Hello guys and ladies,
I am trying to upload and save images in a database. My code is working, but when I test it then after three or four times the image will save partially like this:
In my code I can save up to 12 images (if uploaded). And i'm testing with 4 images.
What am I doing wrong? Is it a memory problem? And if it is..what is causing it?
thank you for helping.
My code is:
//save up to 12 images in database
for($i=1;$i<=12;$i++){
$fileName = $_FILES['image'.$i]['name'];
if ($fileName){
try{
list($origWidth, $origHeight, $type) = getimagesize($_FILES['image'.$i]['tmp_name']);
$temp_name = "tempupload/".$fileName;
//make thumbnail to save in database
//resize the image to 200px and save as/in $temp_name (see resizeImage function)
resizeImage($_FILES['foto'.$i]['tmp_name'], $temp_name, 200, 200);
//retrieve saved image to put a watermark on it
switch(strtolower(image_type_to_mime_type($type)))
{
case 'image/jpeg':
$im2 = #imagecreatefromjpeg($temp_name);
break;
case 'image/png':
$im2 = #imagecreatefrompng($temp_name);
break;
}
//put watermark
$watermark = imagecreatefrompng('../assets/images/logo/watermark.png');
$marge_right = 10;
$marge_bottom = 10;
$sx = imagesx($watermark);
$sy = imagesy($watermark);
imagecopy($im2, $watermark, imagesx($im2) - $sx - $marge_right, imagesy($im2) - $sy - $marge_bottom, 0, 0, imagesx($watermark), imagesy($watermark));
//save image with watermark
switch(strtolower(image_type_to_mime_type($type)))
{
case 'image/jpeg':
imagejpeg($im2, $temp_name);
break;
case 'image/png':
imagepng($im2, $temp_name);
break;
}
//open saved temp image
$saved_temp = fopen($temp_name,"rb");
//addslashes to image to save in database as BLOB
$image = addslashes(fread($saved_temp ,filesize($temp_name)));
fclose($saved_temp );
//End thumbnail
//Next part is to save the image in database in 1200px if user want this.
//this is used so that the user can download and use the image afterwards
$downloadimage="";
if(($_POST['image'.$i.'_Save']!="no") && ($_SESSION['package']!="A")){
//if width or height are smaller 700 us original width or height
$w = ($origWidth > 1200)?1200:$origWidth;
$h = ($origHeight > 1200)?1200:$origHeight;
if(($origWidth > 1200) || ($origHeight > 1200)){
//use same $temp_name to save memory????
resizeImage($_FILES['image'.$i]['tmp_name'], $temp_name, $w, $h,100);
}else{
//if image is to small, then move and save as $temp_name
move_uploaded_file($_FILES['image'.$i]["tmp_name"],$temp_name);
}
//put watermark
if(($_SESSION['package']=="B")){
// Get dimensions and type of $temp_name.
list($origWidth, $origHeight, $type) = getimagesize($temp_name);
switch(strtolower(image_type_to_mime_type($type)))
{
case 'image/jpeg':
$im2 = #imagecreatefromjpeg($temp_name);
break;
case 'image/png':
$im2 = #imagecreatefrompng($temp_name);
break;
}
imagecopy($im2, $watermark, imagesx($im2) - $sx - $marge_right, imagesy($im2) - $sy - $marge_bottom, 0, 0, imagesx($watermark), imagesy($watermark));
switch(strtolower(image_type_to_mime_type($type)))
{
case 'image/jpeg':
imagejpeg($im2, $temp_name);
break;
case 'image/png':
imagepng($im2, $temp_name);
break;
}
}
$saved_temp = fopen($temp_name,"rb");
$downloadimage = addslashes(fread($saved_temp ,filesize($temp_name)));
fclose($saved_temp );
}
//End making downloadimage
//SQL to save images in database
if(empty($downloadimage)){
$sql = "INSERT INTO tb_images(image,strange_id) VALUES (:image,:strange_id)";
$st = $conn->prepare($sql);
}else{
$sql = "INSERT INTO tb_images(image,strange_id,downloadimage,type) VALUES (:image,:strange_id,:downloadimage,:type)";
$st = $conn->prepare($sql);
$st->bindValue( ":downloadimage", $downloadimage, PDO::PARAM_LOB );
$st->bindValue( ":type", strtolower(image_type_to_mime_type($type)), PDO::PARAM_STR );
}
$st->bindValue( ":image", $image, PDO::PARAM_LOB );
$st->bindValue( ":strange_id", $strange_id, PDO::PARAM_INT );
$st->execute();
imagedestroy($watermark);
unlink($temp_name);
imagedestroy($im2);
}
catch (\Exception $e){
echo e;
}
}
}
the resize function
/**
* Resize image - preserve ratio of width and height.
* #param string $sourceImage path to source JPEG/PNG image
* #param string $targetImage path to final JPEG/PNG image file
* #param int $maxWidth maximum width of final image (value 0 - width is optional)
* #param int $maxHeight maximum height of final image (value 0 - height is optional)
* #param int $quality quality of final image (0-100)
* #return bool
*/
function resizeImage($sourceImage, $targetImage, $maxWidth, $maxHeight, $quality = 80)
{
$isValid = #getimagesize($sourceImage);
if (!$isValid)
{
return false;
}
// Get dimensions and type of source image.
list($origWidth, $origHeight, $type) = getimagesize($sourceImage);
if ($maxWidth == 0)
{
$maxWidth = $origWidth;
}
if ($maxHeight == 0)
{
$maxHeight = $origHeight;
}
// Calculate ratio of desired maximum sizes and original sizes.
$widthRatio = $maxWidth / $origWidth;
$heightRatio = $maxHeight / $origHeight;
// Ratio used for calculating new image dimensions.
$ratio = min($widthRatio, $heightRatio);
// Calculate new image dimensions.
$newWidth = (int)$origWidth * $ratio;
$newHeight = (int)$origHeight * $ratio;
// Create final image with new dimensions.
$newImage = imagecreatetruecolor($newWidth, $newHeight);
// Obtain image from given source file.
switch(strtolower(image_type_to_mime_type($type)))
{
case 'image/jpeg':
$image = #imagecreatefromjpeg($sourceImage);
if (!$image)
{
return false;
}
imagecopyresampled($newImage, $image, 0, 0, 0, 0, $newWidth, $newHeight, $origWidth, $origHeight);
if(imagejpeg($newImage,$targetImage,$quality))
{
// Free up the memory.
imagedestroy($image);
imagedestroy($newImage);
return true;
}
break;
case 'image/png':
$image = #imagecreatefrompng($sourceImage);
if (!$image)
{
return false;
}
imagecopyresampled($newImage, $image, 0, 0, 0, 0, $newWidth, $newHeight, $origWidth, $origHeight);
if(imagepng($newImage,$targetImage, floor($quality / 10)))
{
// Free up the memory.
imagedestroy($image);
imagedestroy($newImage);
return true;
}
break;
default:
return false;
}
}

Answer 1

Oke... after much testing... this is the solution of my own problem :)
first of all this line...
resizeImage($_FILES['image'.$i]['tmp_name'], $temp_name, $w, $h,100);
Setting up quality 100% for PNG was a problem. I don't know why, but what I did is just replace this:
imagepng($newImage,$targetImage, floor($quality / 10))
with:
imagepng($newImage,$targetImage)
And I did it also for the JPEG.
Then the second problem was in my database. BLOB had to be LONG BLOB.
But now I am not storing the images in the database anymore. I am saving them in a folder. Not because of the LONG BLOB issue, but just because it is faster and less work to do.