What is wrong with this code? - php

Question

Why is it that when I view the month of November 2010 it also views the month of 2009? Can anyone help me?
<?php include("db.php");
$query = mysql_query("SELECT distinct YEAR(local_date) as year FROM tbl_localnews order by local_date desc");
while ($row = mysql_fetch_array($query)) {
//$row = array_unique($r);
$unique_year = $row['year'];
echo($unique_year)."<br>";
$query2 = mysql_query("select distinct monthname(local_date) as month from tbl_localnews where local_date like '$unique_year%' order by local_date desc");
while ($r2 = mysql_fetch_array($query2)) {
//$row2 = array_unique($r2);
$unique_month = $r2['month'];
print("<a href='news.php?month=$unique_month'&year=$unique_year>News for $unique_month</a><br>");
//echo($unique_month);
}
}
?>
This is my display
<?php
$year = $_REQUEST['year'];
$last_date = "";
$result = mysql_query("SELECT *,YEAR(local_date) as year FROM tbl_localnews where year(local_date)='".$year."' ORDER BY local_date DESC ");
//echo '<h1>'.$month.'</h1>';
if (mysql_num_rows($result)) {
while ($row = mysql_fetch_array($result)) {
if ($row['local_date'] != $last_date) {
print("<h2>News for ".date('F j, Y', strtotime($row['local_date']))."</h2>");
$last_date = $row['local_date'];
}
print("<p><b>".$row['local_title']."</b></p>");
print("<p>".$row['local_desc']."</p>");
// print("<p><b>".date('F j, Y',strtotime($row['local_date']))."</b></p>");
//print("<p><b>".$row['local_title']."</b></p>");
//print("<p>".$row['local_desc']."</p>");
}
mysql_free_result($result);
}
?>

Answer 1

I take it that you're seeing something like
2010<br><a href='news.php?month=November&year=2010'>News for November</a><br>
2009<br><a href='news.php?month=September&year=2009'>News for September</a><br>
in the output of your first example? This is because you're looping through each year and for each year, you're retrieving the months:
$query = mysql_query("SELECT distinct YEAR(local_date) as year FROM tbl_localnews order by local_date desc");
while($row = mysql_fetch_array($query)) { // loop through each year
$unique_year = $row['year'];
echo($unique_year)."<br>";
/* get the months for current year */
$query2 = mysql_query("select distinct monthname(local_date) as month from tbl_localnews where local_date like '$unique_year%' order by local_date desc");
while($r2 = mysql_fetch_array($query2)) { // loop through each month for the current year
$unique_month = $r2['month'];
print("<a href='news.php?month=$unique_month'&year=$unique_year>News for $unique_month</a><br>");
}
}
if you have 2 records with unique year values in your tbl_localnews table you're going to end up with 2 lines in your output. If you just want 1 record, append LIMIT 1 to the end of your query.
I managed to get the following to work for your display page:
<?php
include("db.php");
$year = $_REQUEST['year'];
$month = $_REQUEST['month'];
$last_date = "";
$result = mysql_query("SELECT *, YEAR(local_date) as year FROM tbl_localnews where YEAR(local_date)=".$year." AND monthname(local_date) = '".$month."' ORDER BY local_date DESC ");
if (mysql_num_rows($result) != 0) {
while ($row = mysql_fetch_array($result)) {
if ($row['local_date'] != $last_date) {
print("<h2>News for ".date('F j, Y', strtotime($row['local_date']))."</h2>");
$last_date = $row['local_date'];
}
print("<p><b>".$row['local_title']."</b></p>");
print("<p>".$row['local_desc']."</p>");
}
}
mysql_free_result($result);
?>