suddenly my site show new warning -
The relevant code:
printf ("<input type='text' name='C_Comment' value='" . $myComment . "' >");
The warning I get:
Warning: printf() function.printf: Too few arguments
probably because $myComment is null.
I know I Can fix it if I first test if the value is null, and only then conctenate it. but is there a simpler way?
Why did not I get this warning before?
Thanks,
Atara
EDIT: sorry, wrong title. The problem was that $myComment was not NULL, it contained special character.
No, you get that warning because you don't give enough arguments to printf; probably $myComment contained printf placeholders like %s.
Use echo instead if you don't want to use printf's formatting. You can also rewrite your printf call:
printf ("<input type='text' name='C_Comment' value='%s'>",
$myComment);
Make sure you've escaped special chars in $myComment (see htmlspecialchars).
Instead of using printf just use echo:
echo "<input type='text' name='C_Comment' value='" . $myComment . "' >";
printf is a function used for formatting a string with given values. You have only supplied one argument to the function, so it is throwing that error in your face.
If you simply wish to print the text on the page, use echo (or just remove the f and use print) with the current string. Or you can do this:
printf("<input type='text' name='C_Comment' value='%s' />", $my_comment);
Here's the PHP.net Docs page for printf(), and you can also view related functions in the See Also section.
Add this before the prinf call if you have a default value (which is not empty):
$myComment = ($myComment == null) ? 'yourdefaultvalue' : $myComment;
Of course, an echo would do fine also (and than an empty value is no issue anymore):
<input type="text" name="C_Comment" value="<?=myComment?>" />
Related
Is it possible to add a value to a dynamically created input field?
Im trying something like this: echo "<input value="$row['test']">" but that gives me a syntax error. It has to be in my php file since im calling it via ajax and want to keep my html and php seperate.
Im getting content via ajax and I need to set many field names as there are records in the database.
You can do it like this:
echo '<input value="' . $row['test'] . '">';
Alternatively escape the " (not recommended if not needed, because it is hardly readable):
echo "<input value=\"" . $row['test'] . "\">";
Otherwise you’re mixing quotation marks, which is a syntax error. The . is to combine strings with variables (in this case).
You can also Use:
<input value="<?php echo htmlspecialchars($row['test']); ?>" >
OR
echo "<input name='test' value=".$row['test'].">";
OR
echo "<input name='fred' value='{$row['test']}'>";
Reference
When using certain php values within a quoted string, such as the array syntax in the question, you should either escape from the quotes or encapsulate the variable in curly braces. Also, as the string was quoted with double quotes you should use single quotes around attributes and values.
echo "<input name='fred' value='{$row['test']}'>";
<input type="text" name="post_title" class="form-control" value="<?php
if(isset($post_title))echo $post_title;
?>">
If you want to add it into the HTML
I'm loading a variable from a database like:
$adres = $row['adres']; //(= "Hoge Filterweg")
Then using it in a echo like:
echo input type='text' name='adres' value='{$adres}'
It displays on the form only the first part of the adress ( "Hoge"), but not the whole adress.
What could I do now?
Single quotes surrounding the inline variable like value='{$adres}' dit the trick.
thanks
You need double quotes to pass params with space.
This code should help you:
echo "<input type=\"text\" name=\"adres\" value=\"{$adres}\" />"
What I have is this:
function add_email_form () {
echo "<form class=\"email-me-form\" id=\"initialize\" action=\"<?php echo $_SERVER[PHP_SELF] ?>\" method=\"post\" name=\"contact_me\">\n";
}
How do I make this syntactically correct?
Don't use double quotes unless you need to. Use single quotes, '. That way, you don't have to escape anything except control characters like the \n, and in that case, do drop to double quotes. So the above would be:
echo '<form class="email-me-form" id="intialize" action="'.$_SERVER['PHP_SELF'].'"
method="post" name="contact_me">'."\n";
(newline added to I don't cause a horizontal scrollbar)
You don't need to do htmlspecialchars() looks like what you want.
You don't need to (and in fact, cannot) call "<?php echo?>" inside a PHP statement. Only when you're outside of PHP does that work. In this case, just concatenate with ..
And as stated in the comments, you should quote array keys when they're strings, as otherwise PHP will throw a warning and could potentially be confused.
Something like so:
echo "<form class=\"email-me-form\" id=\"initialize\" action=\"",
htmlspecialchars($_SERVER['PHP_SELF']),
"\" method=\"post\" name=\"contact_me\">\n";
function add_email_form () {
echo "<form class=\"email-me-form\" id=\"initialize\" action=\"" . $_SERVER[PHP_SELF] . "\" method=\"post\" name=\"contact_me\">\n";
}
I try to show this string : «let's go» in a the value of an input tag
i wrote:
$chaine="let's go";
echo "<input type=text name=test value='".$chaine."'>";
result: let
What can i do to show the correct string in this case ?
use htmlspecialchars
echo "<input type=text name=test value='".htmlspecialchars($chaine, ENT_QUOTES)."'>";
You can look at htmlentities()
htmlentities($chaine, ENT_QUOTES) ;
This produces
<input type=text name=test value='let's go'>
You can see, that for HTML (--> your Browser) the value ends after "let". Everything after that is invalid (but ignored). Escape
$chaine = "let\'s go";
However, in HTML double quotes are prefered and omitting the quotes is also no good style
$chaine="let's go";
echo '<input type="text" name="test" value="'.$chaine.'">';
In this case you must escape every double quote.
Basically I'm developing a (very) simple search engine. You can enter a search term and you are taken to the results page - which works fine. However on the results page, I have a button that will take you to the next 10 results: where $term is the $_POST['term'] value.
echo "<input type='hidden' name='term' value='" . $term . "'>";
This causes the following problem with the term is for example "aidan's".
When the next 10 button is clicked, the term becomes aidan\ and no further results are found.
I am not doing anything to $term.
I usually use Java, but am required to use PHP for this uni assignment!
Any help would be greatly appreciated.
It could be your PHP that escapes your data, check out http://www.php.net/manual/en/info.configuration.php#ini.magic-quotes-gpc and / or http://php.net/manual/en/function.addslashes.php these should help you to identify the porblem
Try looking after addslashes() et stripslashes()
http://php.net/manual/en/function.addslashes.php
Regarding your issue, I think you should try to add something like this :
$search = stripslashes($_POST['term']);
If you use double quotes, you don't have to break your string when using a variable. You can also use various options, such as those mentioned already or htmlentities() or urlencode(). I would use the later, just cuz. So you would end up with:
$term = urlencode($term);
echo "<input type='hidden' name='term' value=\"$term\">";
You need to htmlspecialchars() every single bit of data you output to your page. A set-up like yours is the reason that so many XSS vulnerabilities exist around the world, and you should not contribute to them.
echo "<input type='hidden' name='term' value='" . htmlspecialchars($term) . "'>";
Once you have that, you will need no obscure addslashes/quote escaping/whatever anymore.
To make that easier throughout your code, define
function h($s) { htmlspecialchars($s); }
echo "<input type='hidden' name='term' value='" . h($term) . "'>";
The function you are looking for is htmlspecialchars(). However to make it work, you must use quotation marks to wrap the parameter.
Plus, if there are slashes involved, the stripslashes() function may be needed.
So:
$term = htmlspecialchars( stripslashes( $term ) );
echo '<input type="text" name="term" value="' . $term . '" >';
Always use GET method for the search, not POST.
Either turn magic quotes off or strip slashes manually
Use htmllspecialchars with ENT_QUOTES parameter to encode form's field value.
Consider to print out HTML as is, not using PHP echo, to get rid of all this quotes craze
Most important part. If you quote your term for the database search, don't use quoted variable in your form.
so
if (isset($_GET['term'])) {
if (get_magic_quotes_gpc()) $_GET['term'] = stripslashes($_GET['term']);
//$term=mysql_real_escape_string($_GET['term']);
//perform search here.
//
$term = htmlspecialchars($_GET['term'],ENT_QUOTES); //from $_GET again
?>
<input type="hidden" name="term" value="<?php echo $term?>">
<?
}
I think the easiest way is not to put $term as a hidden field at all. For pagination, you can keep memory of the searched term in the session.