php - usage nested loops and case - php

Question

First of all - excuse me if my rudimentary PHP skills has pushed me into asking something which might be basic or trivial, but I have searched the site without results (maybe because i do not know the technical term for such a thing ..)
I have a nested for each loop , but based on simple variables ($e) , I would need to either use the whole loop (2 nested parts) OR use only one (the inner).
$a = array(); //some array ...
$c = array(); //some other array ...
$e = 'yes' // or 'no'
if ($a) {
foreach ($a as $b) {
$a_1[] = 'something_quite_long'; //that would affects $c if used
foreach ( $c as $d ) {
//do_something_very long...
}
}
}
so right now I have resolved this by using switch $e: and case - but that has moer than duplicated the length of my code , because what I did was made one case as the whole nested loop, and the other case - the only inner loop (which is loooong..)
I am sure there is some ninja-technique to use in such a case without simply copying and pasting the whole code in a "case" - but I have no idea how .
Anyone ?
NOTE : I know I could presumably use an external function, but the problem is that in the very long second (inner) loop - there are one or two minor cases where the verbal output (HTML) would change slightly ..
Edit I - Due to unclarity from comments , here is the code (with much reduced loops - the actual loop is much longer) - although not relevant to the question. the code is wordpress related..
function o99_get_image_size_links($title='',$single,$recieved_id) {
/* If not viewing an image attachment page, return. */
/* Set up an empty array for the links. */
$links = array();
/* Get the intermediate image sizes and add the full size to the array. */
$sizes = get_intermediate_image_sizes();
$sizes[] = 'full';
global $post;
switch ($single) {
case 'FALSE':
// this will do to all images attached to a post ..
$attachments = get_children( array('post_parent' => $post->ID, 'post_status' => 'inherit', 'post_type' => 'attachment','post_mime_type' => $mime, 'order' => 'ASC', 'orderby' => 'menu_order ID', 'posts_per_page'=>$limit) );
/* Loop through each of the image sizes. */
if ($attachments) {
foreach ($attachments as $att) {
$links[] = '<br>' . get_the_title($att->ID) .' || '. basename ( get_attached_file( $att->ID ) ).' || '. $att->post_name .' || ' /*. wp_get_attachment_image( $att->ID, 'tooltip' ).' || ' .'<br/>'*/ ; // k99 add
if ($title) {
$links[] = '<br><b>' . $title . '</b></br>';
}
foreach ( $sizes as $size ) {
/* Get the image source, width, height, and whether it's intermediate. */
$image = wp_get_attachment_image_src( $att->ID, $size );
/* Add the link to the array if there's an image and if $is_intermediate (4th array value) is true or full size. */
if ( !empty( $image ) && ( true == $image[3] || 'full' == $size ) )
$links[] = "</br><a class='image-size-link_{$image[1]}×{$image[2]}' href='{$image[0]}'>{$image[1]} × {$image[2]}</a>";
}
}
}
break;
//case for single image ..
case 'TRUE':
$links[] = '<br>' . get_the_title($recieved_id) .' || '. basename ( get_attached_file( $recieved_id ) ).' || '. $att->post_name .' || ' /*. wp_get_attachment_image( $att->ID, 'tooltip' ).' || ' .'<br/>'*/ ; // k99 add
if ($title) {
$links[] = '<br><b>' . $title . '</b></br>';
}
foreach ( $sizes as $size ) {
/* Get the image source, width, height, and whether it's intermediate. */
$image = wp_get_attachment_image_src( $recieved_id, $size );
/* Add the link to the array if there's an image and if $is_intermediate (4th array value) is true or full size. */
if ( !empty( $image ) && ( true == $image[3] || 'full' == $size ) )
$links[] = "</br><a class='image-size-link_{$image[1]}×{$image[2]}' href='{$image[0]}'>{$image[1]} × {$image[2]}</a>";
}
break;
}
/* Join the links in a string and return. */
return join( '<span class="sep"> /</span> ', $links );
}

Answer 1

I have so many issues with your code .. but this is to give you an idea how to minimized your code
Issues
Use Of global global $post;
$mime and $limit not declared
basename ( get_attached_file( $recieved_id ) ).' || '. $att->post_name .' || ' outside the loop that defines foreach ($attachments as $att)
$recieved_id var argument and $post->ID via post ????
etc
There is no way your script can work with this error .. so i'll just give you a guide on how to improve your function
function k99_get_image_size_links($title = '', $single , $recieved_id , $mime =null , $limit = null) {
$links = array();
$sizes = get_intermediate_image_sizes();
$sizes[] = 'full';
$pad = function ($ID) use(&$links,$sizes,$title) {
$links[] = '<br>' . get_the_title($ID) . ' || ' . basename(get_attached_file($ID)) . ' || ' . $title . ' || ' ;
empty($title) OR $links[] = sprintf('<br><b>%s</b></br>',$title);
foreach ( $sizes as $size ) {
$image = wp_get_attachment_image_src($ID, $size);
if (! empty($image) && (true == $image[3] || 'full' == $size))
$links[] = sprintf('</br><a class="image-size-link_%s×%s" href="%s">%1$s × %2$s</a>',$image[1],$image[2],$image[0]);
}
};
if ($single === true) {
$pad($recieved_id);
} else {
$attachments = get_children(array('post_parent' => $recieved_id,'post_status' => 'inherit','post_type' => 'attachment',
'post_mime_type' => $mime,'order' => 'ASC','orderby' => 'menu_order ID','posts_per_page' => $limit));
if ($attachments) {
foreach ( $attachments as $att ) {
$pad($att->ID);
}
}
}
return join('<span class="sep"> /</span> ', $links);
}
Please Not the above code is not tested just to show you how you can use Closure remove duplication in your code

Answer 2

Some notes:
if ($a) {
foreach ($a as $b) {
As $a is an array and only an array evaluates true in the if, you don't need the if at all. foreach will do zero iterations on an empty array, so the if is superfluous.
$d = 'yes' // or 'no'
...
foreach ( $c as $d ) {
^^^
You are overwriting the $d variable here. That might cause your problem. Let's clean the code an review:
$a = array(); //some array ...
$c = array(); //some other array ...
$e = 'yes' // or 'no'
foreach ($a as $b)
{
$a_1[] = 'something_quite_long'; //that would affects $c if used
foreach ($c as $d)
{
// do_something_very long...
}
}
If you now give the variables better names, the looping should have become more clear so less places to do errors.

Answer 3

You can break out of a foreach loop with the break; command which skips out of the loop and carries on with the next step which in your code is the next iteration of the outer loop. Also you are overwriting $d in each iteration of the inner loop here foreach ($c as $d)