handle syntax error, unexpected T_IF in PHP - php

Question

I need to create a search of string in an XML file on all nodes.
---catalog.xml---
<?xml version="1.0" encoding="ISO-8859-1"?>
<Catalog>
<Category>
<Name>Biscuit</Name>
<Location>
<Id>Butter</Id>
<Description>The butter biscuit cost $10 per pack</Description>
</Location>
<Location>
<Id>Chocolate</Id>
<Description>The chocolate biscuit cost $20 per pack</Description>
</Location>
</Category>
<Category>
<Name>Cake</Name>
<Location>
<Id>Cup</Id>
<Description>This is a cup cake</Description>
</Location>
<Location>
<Id>Slice</Id>
<Description>This is a slice cake</Description>
</Location>
</Category>
</Catalog>
---search.php---
<?php
$catalog = simplexml_load_file("catalog.xml");
$category = $catalog->Category;
$location = $category->Location;
foreach($location->Description as $desc)
{
$string = string($desc);
$find = 'chocolate';
$result = strpos($string, $find)
if ($result !== false)
{
echo $result;
}
else
{
echo "No Result";
}
}
?>
The error I received is:
Parse error: syntax error, unexpected T_IF on line 14
Since there is "chocolate" at node and Node, I need to display both node result.
----New Amended Code / 20 Nov 2012---
<?php
$catalog = simplexml_load_file("catalog.xml");
$find = "chocolate";
$lcFind = strtolower($find);
$ll = implode('', range('a', 'z'));
$ul = strtoupper($ll);
$xpath_result = $catalog->xpath("//*[contains(translate(text(), '$ul','$ll'),'$lcFind')]");
if ($xpath_result) {
foreach ($xpath_result as $res) {
$category = $catalog->Category;
$name = $category->Name;
$loc = $category->Location;
$id = $loc->Id;
echo "Category: ", $name, "<br />";
echo "ID: ", $id, "<br />";
echo "Description :", $res, "<br />";
}
}
else {
echo "No matching descriptions found for word '<i>$find</i>'<br />";
}
?>
Result (Wrong):
Category: Biscuit
ID: Butter //This should be "Chocolate"
Description :Chocolate //This should be the description for "Chocolate"
Category: Biscuit
ID: Butter
Description :The chocolate biscuit cost $20 per pack

Answer 1

It should be...
$result = strpos($string, $find);
You should finish your statements with semicolons in PHP. And it'd probably be quite a nice idea using IDE (or even a text editor) with PHP syntax check.
... Yet there's only the beginning of the problem (and I'm not talking about non-existing string function here). See, with this code you're trying to search for some term only in descriptions of the first location of the first category. If that's actually the task, ok, but somehow I feel your original intent is better expressed with this:
$found = false;
foreach ($catalog->Category as $category) {
foreach($category->Location as $location) {
$description = "{$location->Description}";
$result = strpos($description, $find);
if ($result !== FALSE) {
echo "Word '<i>$find</i>' found in <b>$description</b> at position " . ($result + 1) . '.<br />';
$found = true;
}
}
}
if (! $found) {
echo "No matching descriptions found for word '<i>$find</i>'<br />";
}
And even this can be optimized with XPath - especially if you actually don't need to echo the position:
$xpath_result = $catalog->xpath("//Description[contains(text(),'$find')]");
if ($xpath_result) {
foreach ($xpath_result as $res) {
echo "Word '<i>$find</i>' found in <b>$res</b><br />";
}
}
else {
echo "No matching descriptions found for word '<i>$find</i>'<br />";
}
... or, for case-insensitive search:
$lcFind = strtolower($find);
$ll = implode('', range('a', 'z'));
$ul = strtoupper($ll);
$xpath_result = $catalog->xpath("//*[contains(translate(text(), '$ul', '$ll'),'$lcFind')]");
... // the rest of code is the same