php and mysql counting amount - php

Question

Im trying to display the amount of a certain pokemon that is in the game by the name of the pokemon and by the type, ( there is two types normal and shiny ) I want it to only grab one type hard to explain... right now its grabing both types and I don't know why here's my code :/
$sql23 = "
SELECT * FROM user_pokemon
WHERE belongsto='". $_SESSION['username']."'AND (slot='1')
";
$result = mysql_query("
SELECT * FROM user_pokemon
WHERE belongsto='". $_SESSION{'username'}."'AND (slot='1')
");
while($row = mysql_fetch_array($result))
{
$sql = "SELECT * FROM pokemon WHERE name='".$row['pokemon']."'";
$result = mysql_query($sql) or die(mysql_error());
$battle_get = mysql_fetch_array($result);
$count = mysql_query("
SELECT count(*) FROM user_pokemon WHERE pokemon='".$row['pokemon']."
'AND type='".$row['type']."'
");
$count2 = mysql_fetch_array($count);
I honestly don't understand why it doesn't work, any help would be appreciated :)
$row['pokemon'] is the name of the pokemon
$row['type'] is the type of the pokemon (shiny, normal, ect..)
user_pokemon table as asked:
Field Type Null Default Comments
-----------------------------------------------------------
id int(11) No
hp int(55) No 30
pokemon varchar(50) No
belongsto varchar(50) No
exp int(50) No 500
item varchar(50) No No Item
nickname varchar(50) No No Nickname
move1 varchar(50) No Ember
move2 varchar(50) No Ember
move3 varchar(50) No Ember
move4 varchar(50) No Ember
slot int(50) No
level int(90) No 5
time_stamp timestamp No CURRENT_TIMESTAMP
gender varchar(25) No Male
type varchar(55) No Normal Type: normal/shiny etc
safari_zone int(10) No 0

Answer 1

One of the things I regularly see on StackOverflow is lack of code formatting. In my view fixing this is a great way to make your code much more readable both to yourself (aids learning) and to others (aids your readers here). It additionally reduces the need for horizontal scrolling, allowing you to place several editors side-by-side on your screen.
Here is your code with suggested code formatting:
$sql23 = "
SELECT
*
FROM
user_pokemon
WHERE
belongsto = '{$_SESSION['username']}'
AND (slot = '1')
";
$result = mysql_query($sql23) or die(mysql_error());
while($row = mysql_fetch_array($result))
{
$sql = "
SELECT * FROM pokemon WHERE name = '{$row['pokemon']}'
";
$result = mysql_query($sql) or die(mysql_error());
$battle_get = mysql_fetch_array($result);
$count = mysql_query("
SELECT
COUNT(*)
FROM
user_pokemon
WHERE
pokemon='{$row['pokemon']}'
AND type='{$row['type']}'
");
$count2 = mysql_fetch_array($count);
}
This helped indicate that your while was missing a closing brace, and that the variable $sql23 wasn't actually used. Also note that you can use array values inline in double-quoted strings, by wrapping them in braces.
As noted in the comments, you should upgrade to PDO or mysqli. Also, be careful about injecting values directly into the SQL if they have come from the user, as this can lead to SQL injection vulnerabilities. Look into query parameterisation, or at least untainting, to ensure your code is safe.