FOREACH and UPDATE mysql not working - php

Question

I have a select query followed by a an update query inside a foreach loop.
I can get the data from the select and I use it as json to draw a chart, but for the other table that should be updated with the same data from select, the specified filed become 0 sometimes 1 or 2 !!
I tried to use a select for update and it OK (update .... (select ....)) but inside foreach it doesn't work.
I tried also to use other columns but the same result, always I get 0.
Any idea please ?
Many thanks in advance
this is my code
public function actionGetSensorsDataLive($beamId) {
header('Content-Type: application/json; charset="UTF-8"');
$sensorsIds = Sensor::model()->findAllBySql('SELECT sensor_id FROM sensor where
node_id="' . $beamId . '" and sensor_name = "I" ;');
foreach ($sensorsIds as $s) {
$sResult = array();
$modelSensor = SensorInfo2::model()->findBySql('SELECT * FROM information_sensor
where sensor_id= "' . $s['sensor_id'] . '"');
$sResult = array(($modelSensor->information_sensor_time),
($modelSensor->information_sensor_value));
/////////////// update////////////////
// for every information_sensor_time that I get from the previous query
// I want
// to update a row in another table //
foreach ($modelSensor as $up) {
$connection = yii::app()->db;
$sql = 'UPDATE last_point SET last_point_time = "' .
$up['information_sensor_time'] . '"
WHERE sensor_id= "' . $s['sensor_id'] . '" ';
$command = $connection->createCommand($sql);
$command->execute();
}
/////update end///////
}
echo json_encode($sResult);
Yii::app()->end();
}

Answer 1

$sensorsIds=Sensor::model()->findAllBySql('SELECT sensor_id FROM lead where
node_id="'.$beamId.'" and sensor_name = "I" ;' );
Remove ;
$sensorsIds=Sensor::model()->findAllBySql('SELECT sensor_id FROM lead where
node_id="'.$beamId.'" and sensor_name = "I"' );
Now try this.

Answer 2

You are using findBySql()` which only returns one record and then doing a foreach on tha makes no sense. so cheng the line
$modelSensor = SensorInfo2::model()->findBySql('SELECT * FROM information_sensor
where sensor_id= "' . $s['sensor_id'] . '"');
to
$modelSensor = SensorInfo2::model()->findAllBySql('SELECT * FROM information_sensor
where sensor_id= "' . $s['sensor_id'] . '"');
And you shoud use querybuilder which is far secure as suggested by Alex

Answer 3

finally I used this code
foreach ($sensors as $sensor) {
$lastPointId = 1;
$lastPoint = LastPoint::model()->findByPk($lastPointId);
$lastPoint->last_point_info = $sensor->information_time;
if ( ! $lastPoint->save()) {
throw new CException('Unable to save last point.');
}
}
Thanks for all