Correct format of PHP if block [duplicate] - php

Question

This question already has answers here:
PHP logical AND operator error [closed]
(5 answers)
Closed 9 years ago.
Complete PHP noob here with an error returning because of a big nested if block. The error varies as I change the code, but it is always to do with the if statement. What is the correct way to do this statement?
Here is the incorrect if block:
if(!empty($_GET['x2'])) and (!empty($_GET['x'])) and (!empty($_GET['num']))
{
$xsqrd = $_GET['x2'];
$x = $_GET['x'];
$num = $_GET['num'];
if(($xsqrd*2)==0.0)
{
print $errdivzero;
}
else if(sqrt(pow($x,2)-(4*$xsqrd*$num)))
{
print $errsqrtmin1;
}
else
{
$ans1 = (-$x)+(sqrt(pow($x,2)-(4*$xsqrd*$num)))/(2*$xsqrd);
$ans2 = (-$x)-(sqrt(pow($x,2)-(4*$xsqrd*$num)))/(2*$xsqrd);
}
}

Answer 1

if(!empty($_GET['x2']) && !empty($_GET['x']) && !empty($_GET['num']))
{
$xsqrd = $_GET['x2'];
$x = $_GET['x'];
$num = $_GET['num'];
if(($xsqrd*2)==0.0)
{
print $errdivzero;
}
else if(sqrt(pow($x,2)-(4*$xsqrd*$num)))
{
print $errsqrtmin1;
}
else
{
$ans1 = (-$x)+(sqrt(pow($x,2)-(4*$xsqrd*$num)))/(2*$xsqrd);
$ans2 = (-$x)-(sqrt(pow($x,2)-(4*$xsqrd*$num)))/(2*$xsqrd);
}
}
You have extra ( in if condition and also you declared and which is not php function. you need to replace and with &&.
Now it's working fine without any error message.

Answer 2

if(!empty($_GET['x2']) && (!empty($_GET['x']) && (!empty($_GET['num']))
// ^ extra bracket ^ extra bracket
{
$xsqrd = $_GET['x2'];
$x = $_GET['x'];
$num = $_GET['num'];
if(($xsqrd*2)==0.0)
{
print $errdivzero;
}
else if(sqrt(pow($x,2)-(4*$xsqrd*$num)))
{
print $errsqrtmin1;
}
else
{
$ans1 = (-$x)+(sqrt(pow($x,2)-(4*$xsqrd*$num)))/(2*$xsqrd);
$ans2 = (-$x)-(sqrt(pow($x,2)-(4*$xsqrd*$num)))/(2*$xsqrd);
}
}
You had extra closing brackets at the position highlighted above. Also replace and with &&

Answer 3

Well let's check your brackets:
if(!empty($_GET['x2'])) and (!empty($_GET['x'])) and (!empty($_GET['num']))
^ ^
The second highlighted bracket closes the if statement - this will cause an error, you should remove unnecessary brackets like so::
if(!empty($_GET['x2']) and !empty($_GET['x']) and !empty($_GET['num']))
In future you should carefully check that for each opening bracket the closing bracket is where you expect it to be, and don't go overboard with the number of brackets.