What's wrong with this PHP PDO statement for SQL insert? - php

Question

I've already got username, password and other variables stored, but I keep getting an error "Invalid parameter number: number of bound variables does not match number of tokens" in this line:
$database->query(
'INSERT INTO users_inactive(verCode, username, password, email, date, type)
VALUES (:vercode, :username, :password, :email, :date, :type)',
array(
':vercode' => $verCode,
':username' => $username,
':password' => $password,
':email' => $email,
':date' => $date,
':type'=>'customer')
);
Is there anything wrong with it? I've made sure each of these columns is available in my user_inactive table.
This is the $database wrapper function:
public function query($query, $bind = null, $fetch = 'FETCH_ASSOC') {
/* Prepare the query statement */
$this->statement = $this->pdo->prepare($query);
/* Bind each value supplied from $bind */
if($bind != null) {
foreach($bind as $select => $value) {
/* For each type of value give the appropriate param */
if(is_int($value)) {
$param = PDO::PARAM_INT;
} elseif(is_bool($value)) {
$param = PDO::PARAM_BOOL;
} elseif(is_null($value)) {
$param = PDO::PARAM_NULL;
} elseif(is_string($value)) {
$param = PDO::PARAM_STR;
} else {
$param = FALSE;
}
/* Bid value */
if($param) {
$this->statement->bindValue($select, $value, $param);
}
}
}
/* Execute Query & check for any errors */
if(!$this->statement->execute()){
$result = array(
1 => 'false',
2 => '<b>[DATABASE] Error - Query:</b> There was an error in sql syntax',
);
return $result;
}
/* Return all content */
if($fetch == 'FETCH_ASSOC') {
$result = $this->statement->fetch(PDO::FETCH_ASSOC);
} elseif($fetch == 'FETCH_BOTH') {
$result = $this->statement->fetch(PDO::FETCH_BOTH);
} elseif($fetch == 'FETCH_LAZY') {
$result = $this->statement->fetch(PDO::FETCH_LAZY);
} elseif($fetch == 'FETCH_OBJ') {
$result = $this->statement->fetch(PDO::FETCH_OBJ);
} elseif($fetch == 'fetchAll') {
$result = $this->statement->fetchAll();
}
return $result;
}
}
Taken from Tutis Login.

Answer 1

Just some clues,You are probably missing some colons. Check out here
PHP Mysql PDO number of bound variables does not match number of tokens
Or probably there is some case sensitive going on on your colons

Answer 2

The error seems to be in your wrapper function. PDO::PARAM_NULL == 0, so this value does not pass through
if($param) {
...
}
So you do not call bindValue() for NULL values. Instead, use:
if ($param !== FALSE) {
...
}
EDIT - reading again your code, this would be better code of the foreach() block, producing less cryptic error messages in the future :)
foreach($bind as $select => $value) {
/* For each type of value give the appropriate param */
if(is_int($value)) {
$param = PDO::PARAM_INT;
} elseif(is_bool($value)) {
$param = PDO::PARAM_BOOL;
} elseif(is_null($value)) {
$param = PDO::PARAM_NULL;
} elseif(is_string($value)) {
$param = PDO::PARAM_STR;
} else {
// Report error about invalid type and return from the function
...
}
// we should bind every value from $bind array, unconditionally!
$this->statement->bindValue($select, $value, $param);
}

Answer 3

Give this a shot:
<?php
$sql = $database->prepare(
'INSERT INTO users_inactive(verCode, username, password, email, date, type)
VALUES (:vercode, :username, :password, :email, :date, :type)');
$sql->execute(array(
'vercode' => $verCode,
'username' => $username,
'password' => $password,
'email' => $email,
'date' => $date,
'type'=>'customer')
);