page not displaying correctly - php

Question

I have the code below. It runs fine until the last point. It seems to just just off and stop displaying the rest of the page after the // Close Main while loop comment and I cannot seem to work out why.
<?php
//show everything
error_reporting(E_ALL);
//using php.ini and ini_set()
ini_set('error_reporting', E_ALL);
require_once('header.tpl');
$my_id = '19';
mysql_connect("localhost","*********","*********") or die (mysql_error());
mysql_select_db("*********") or die (mysql_error());
?>
<!-- Navbar/popouts/notloggedin end -->
<script language="javascript" type="text/javascript">
function toggleChecks(field) {
if (document.myform.toggleAll.checked == true){
for (i = 0; i < field.length; i++) {
field[i].checked = true;
}
} else {
for (i = 0; i < field.length; i++) {
field[i].checked = false;
}
}
}
$(document).ready(function() {
$(".toggle").click(function () {
if ($(this).next().is(":hidden")) {
$(".hiddenDiv").hide();
$(this).next().slideDown("fast");
} else {
$(this).next().hide();
}
});
});
function markAsRead(msgID) {
$.post("markAsRead.php",{ messageid:msgID, ownerid:<?php echo $my_id; ?> } ,function(data) {
$('#subj_line_'+msgID).addClass('msgRead');
// alert(data); // This line was just for testing returned data from the PHP file, it is not required for marking messages as read
});
}
</script>
<style type="text/css">
.hiddenDiv {
display:none
}
#pmFormProcessGif {
display:none
}
.msgDefault {
font-weight:bold;
}
.msgRead {
font-weight:100;
color:#666;
}
</style>
<div class="container">
<div class="row">
<!-- /Welcome text -->
<div class="span12">
<div class="navbar navbar-inverse" style="position: static;">
<div class="navbar-inner">
<div class="container"><a class="btn btn-navbar" data-toggle="collapse" data-target=".navbar-inverse-collapse"><span class="icon-bar"></span> <span class="icon-bar"></span><span class="icon-bar"></span></a>
<div class="nav-collapse collapse navbar-inverse-collapse">
<ul class="nav">
<li>Inbox</li>
<li>Sent</li>
<li>Deleted</li>
<form class="navbar-search pull-left" action="">
<input type="text" id="inbox_search" class="search-query span2" placeholder="Search Emails" />
</form>
</ul>
<ul class="nav pull-right">
<li><i class="icon-file icon-white"></i></li>
<li class="dropdown"> <i class="icon-wrench icon-white"></i>
<ul class="dropdown-menu">
<li>Create New Folder</li>
<li>Message Templates</li>
</ul>
</li>
</ul>
</div>
</div>
</div>
<!-- /navbar-inner -->
</div>
</div>
</div>
<div class="row">
<div class="span12">
<table class="fulltable">
<tr>
<td class="fulltable_topbar" colspan="2"></td>
</tr>
<tr>
<td class="fulltable_title"><div></div></td>
</tr>
<tr>
<td class="fulltable_content" style="padding-top:10px"><div>
<!-- START THE PM FORM AND DISPLAY LIST -->
<form name="myform" action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post" enctype="multipart/form-data">
<table width="94%" border="0" align="center" cellpadding="4">
<tr>
<td width="3%" align="right" valign="bottom"><img src="images/crookedArrow.png" width="16" height="17" alt="Develop PHP Private Messages" /></td>
<td width="97%" valign="top"><input type="submit" name="deleteBtn" class="btn btn-small btn-invese" id="deleteBtn" value="Delete" />
<span id="jsbox" style="display:none"></span></td>
</tr>
</table>
<table width="96%" border="0" align="center" cellpadding="4" style="background-image:url(images/headerStrip.jpg); background-repeat:repeat-x; border: #999 1px solid;">
<tr>
<td width="4%" valign="top"><input name="toggleAll" id="toggleAll" type="checkbox" onclick="toggleChecks(document.myform.cb)" /></td>
<td width="20%" valign="top">From</td>
<td width="58%" valign="top"><span class="style2">Subject</span></td>
<td width="18%" valign="top">Date</td>
</tr>
</table>
<?php
///////////End take away///////////////////////
// SQL to gather their entire PM list
$sql = mysql_query("SELECT * FROM private_messages WHERE to_id='$my_id' AND recipientDelete='0' ORDER BY id DESC LIMIT 100");
while($row = mysql_fetch_array($sql) **or die(mysql_error())**){ <error was the or die!
$date = strftime("%b %d, %Y",strtotime($row['time_sent']));
if($row['opened'] == "0"){
$textWeight = 'msgDefault';
} else {
$textWeight = 'msgRead';
}
$fr_id = $row['from_id'];
// SQL - Collect username for sender inside loop
$ret = mysql_query("SELECT id, username FROM members WHERE id='$fr_id' LIMIT 1");
while($raw = mysql_fetch_array($ret)){ $Sid = $raw['id']; $Sname = $raw['username']; }
?>
<table width="96%" border="0" align="center" cellpadding="4">
<tr>
<td width="4%" valign="top"><input type="checkbox" name="cb<?php echo $row['id']; ?>" id="cb" value="<?php echo $row['id']; ?>" /></td>
<td width="20%" valign="top"><?php echo $Sname; ?></td>
<td width="58%" valign="top"><span class="toggle" style="padding:3px;"> <a class="<?php echo $textWeight; ?>" id="subj_line_<?php echo $row['id']; ?>" style="cursor:pointer;" onclick="markAsRead(<?php echo $row['id']; ?>)"><?php echo stripslashes($row['subject']); ?></a> </span>
<div class="hiddenDiv"> <br />
<?php echo stripslashes(wordwrap(nl2br($row['message']), 54, "\n", true)); ?> <br />
<br />
REPLY<br />
</div></td>
<td width="18%" valign="top"><span style="font-size:10px;"><?php echo $date; ?></span></td>
</tr>
</table>
<hr style="margin-left:20px; margin-right:20px;" />
<?php
}// Close Main while loop
?>
</form>
<!-- END THE PM FORM AND DISPLAY LIST --> </div></td>
</tr>
<tr>
<td class="fulltable_bottom" colspan="2"></td>
</tr>
</table>
</div>
</div>
</body>
</br>
</br>
<?php require_once('footer.tpl'); ?>

Answer 1

why the ; after } (please remove)
} // Close Main while loop
same error here:
if($row['opened'] == "0"){
$textWeight = 'msgDefault';
} else {
$textWeight = 'msgRead';
};

Answer 2

You added some semicolons ; (which are not needed) after both of your loop closin curly braces }
};
$fr_id = $row['from_id'];
Should be
}
$fr_id = $row['from_id'];
And also
};// Close Main while loop
Has to be
}// Close Main while loop

Answer 3

just a heads up. While your bug seems to have been cleanly solved, I would suggest getting an IDE that can detect these types of issues. This way you won't spend the rest of your career looking for semi-colons. This is a link to Aptana, which is a code editor that has a lot of built in error detecting. Basically red lines pop up under lines that contain basic errors, things like a missing ; or ). Good luck dude.
http://www.aptana.com/

Answer 4

$sql = mysql_query("SELECT * FROM private_messages WHERE to_id='$my_id' AND recipientDelete='0' ORDER BY id DESC LIMIT 100");
while($row = mysql_fetch_array($sql) **or die(mysql_error())**){ <error was the or die!
the error is above :)