Foreach loop not [closed] - php

Question

Closed. This question does not meet Stack Overflow guidelines. It is not currently accepting answers.
Questions asking for code must demonstrate a minimal understanding of the problem being solved. Include attempted solutions, why they didn't work, and the expected results. See also: Stack Overflow question checklist
Closed 9 years ago.
Improve this question
$inputarray=array("username", "password");
foreach($inputarray as $inputkey);
if(isset($_POST[$inputkey]) && !empty($_POST[$inputkey]))
{
$inputname=$inputkey;
$inputresult=$_POST[$inputkey];
$$inputname=$inputresult;
}
else
{
die("You have to fill both fields.");
}
$username isn't being defined, only $password. Anyone know what's wrong?

Answer 1

It's just a typo:
foreach($inputarray as $inputkey);
You included a semicolon at the end of that line, so the foreach statement runs, then ends, and then the if clause executes on the last value that the foreach statement left in $inputkey.
Try:
foreach($inputarray as $inputkey)
{
if(isset($_POST[$inputkey]) && !empty($_POST[$inputkey]))
{
$inputname=$inputkey;
$inputresult=$_POST[$inputkey];
$$inputname=$inputresult;
}
else
{
die("You have to fill both fields.");
}
}

Answer 2

Error is probably due to the ; at the end the foreach line. This will cause the foreach line to run leaving to completion, but not run any other statements as there is no enclosure that follows it. Once completed the value of $inputkey will be "password" which is why you are only getting data from "password"
Try:
$inputarray=array("username", "password");
foreach($inputarray as $inputkey) {
if(isset($_POST[$inputkey]) && !empty($_POST[$inputkey])) {
$inputname=$inputkey;
$inputresult=$_POST[$inputkey];
$$inputname=$inputresult;
} else {
die("You have to fill both fields.");
}
} //endforeach

Answer 3

Variable variables are a code smell that you're making things hard on yourself. Instead of doing that, at this stage, and for the specific purposes of a login page, I would make life as simple, readable, and uncomplicated as you can.
Just do this:
$username = #$_POST['username']; // Just about the only place where using # is ok.
$password = #$_POST['password'];
if(!trim($username) || !trim($password)){
die("You have to fill both fields.");
}
A login form is not a place to innovate or make your code complicated. For a little added abstraction, you could put that information into a simple login validation function so that you can modify the criteria down the line (e.g. username must be longer than 1 character, or whatever).
But from looking at your code, you're making a CLASSIC MISTAKE:
DO NOT ROLL YOUR OWN LOGIN SYSTEM THE FIRST TIME AROUND.
Reuse an expert's login code and learn from that. Write other things in custom php, but borrow someone else's time tested login code for database parameterization, error checking, and abstraction. Writing your own login system is playing with fire.

Answer 4

It looks like you're assigning the string name $inputkey to the value. Also you were creating dynamic variables that you might never have found in your code.
$inputarray=array("username", "password");
foreach($inputarray as $inputkey=>$inputvalue);
if(isset($_POST[$inputkey]) && !empty($_POST[$inputkey]))
{
$inputname=$inputkey;
$inputresult=$_POST[$inputkey];
$inputname=$inputresult;
}
else
{
die("You have to fill both fields.");
}