Pagination next previous multiplied - php

Question

Please forgive me if i make some mistake in english its not my native language.
To the point. This is my pagination code:
if (!isset($_GET["page"])) $_GET["page"] = 1;
if (sizeof($dirs) + sizeof($files) > $thumbs_pr_page)
{
$page_navigation .= "$label_page ";
for ($i=1; $i <= ceil((sizeof($files) + sizeof($dirs)) / $thumbs_pr_page); $i++)
{
if ($_GET["page"] == $i)
$page_navigation .= "$i";
else
$page_navigation .= "<a href='?dir=" . $_GET["dir"] . "&page=" . ($i) . "'>" . $i . "</a>";
$page_navigation .= "<a href='?dir=" . $_GET["dir"] . "&page=" . ($i-1) . "'> Previous </a>";
$page_navigation .= "<a href='?dir=" . $_GET["dir"] . "&page=" . ($i+1) . "'> Next </a>";
if ($i != ceil((sizeof($files) + sizeof($dirs)) / $thumbs_pr_page)) $page_navigation .= " | ";
}
}
Any ideas where is the problem ? The next/ previous button is mutliplied. But it should be only on the left side should be previous and on the right side next. I am only learning php now and its hard for me. Here you can see it how it looks: http://tinypic.com/view.php?pic=2djl3m&s=5 and it should be like this: http://tinypic.com/view.php?pic=2eeli54&s=5

Answer 1

You need to move the next and previous button out of your for-loop. Previous at front, next after it. Next and Previous dont need to depend on $i - they should depend on the currently loaded page, only.
if (!isset($_GET["page"])) $_GET["page"] = 1;
if (sizeof($dirs) + sizeof($files) > $thumbs_pr_page)
{
$page_navigation .= "$label_page ";
$page_navigation .= "<a href='?dir=" . $_GET["dir"] . "&page=" . ($_GET["page"]-1) . "'> Previous </a>";
for ($i=1; $i <= ceil((sizeof($files) + sizeof($dirs)) / $thumbs_pr_page); $i++)
{
if ($_GET["page"] == $i)
$page_navigation .= "$i";
else
$page_navigation .= "<a href='?dir=" . $_GET["dir"] . "&page=" . ($i) . "'>" . $i . "</a>";
if ($i != ceil((sizeof($files) + sizeof($dirs)) / $thumbs_pr_page)) $page_navigation .= " | ";
}
$page_navigation .= "<a href='?dir=" . $_GET["dir"] . "&page=" . ($_GET["page"]+1) . "'> Next </a>";
}
But you should also "catch" 0 and n+1 pages (then no Previous / Next Button is required)

Answer 2

Problem is in your for loop. You are checking if $_GET['page'] == $i and if not you are concatenating links to $page_navigation
$page_navigation .= "<a href='?dir=" . $_GET["dir"] . "&page=" . ($i) . "'>" . $i . "</a>";
$page_navigation .= "<a href='?dir=" . $_GET["dir"] . "&page=" . ($i-1) . "'> Previous </a>";
$page_navigation .= "<a href='?dir=" . $_GET["dir"] . "&page=" . ($i+1) . "'> Next </a>";
This will generate Next / Previous link for each iteration where $_GET['page'] == $i is not true (which is always except once). Since you need them only once (relative to current $_GET['page']) you need to move them outside the loop.

Answer 3

First of all, please try and put brackets in the after the else, because, the last two statements in the else will not be a part of the else clause, which will cause the Previous and Next to be a part of the for(;;;) instead of the else, and that is causing it to maybe repeat the Previous and Next.
if ($_GET["page"] == $i)
$page_navigation .= "$i";
else{
$page_navigation .= "<a href='?dir=" . $_GET["dir"] . "&page=" . ($i) . "'>" . $i . "</a>";
$page_navigation .= "<a href='?dir=" . $_GET["dir"] . "&page=" . ($i-1) . "'> Previous </a>";
$page_navigation .= "<a href='?dir=" . $_GET["dir"] . "&page=" . ($i+1) . "'> Next </a>";
}