How to validate my contact form? - php

I used this code to connect my contact form to mysql but the problem is I don't know how to validate each item like the name has to be fill or the email should be valid so it will not bother me later when I take care all of it, here is my code :can you help me :
<?php
$con=mysqli_connect("example.com","peter","abc123","my_db");
// Check connection
if (mysqli_connect_errno())
{
echo "Failed to connect to MySQL: " . mysqli_connect_error();
}
$sql="INSERT INTO Persons (FirstName, LastName, Age)
VALUES
('$_POST[firstname]','$_POST[lastname]','$_POST[age]')";
if (!mysqli_query($con,$sql))
{
die('Error: ' . mysqli_error($con));
}
echo "1 record added";
mysqli_close($con);
?>

You should have client side validation (e.g using jquery)
and in your php you can try like this:
if(!empty($_POST['lastname']) && !empty($_POST['age']) && !empty($_POST['firstname']) && filter_var($_POST['email'], FILTER_VALIDATE_EMAIL)) {
$con=mysqli_connect("example.com","peter","abc123","my_db");
// Check connection
if (mysqli_connect_errno())
{
echo "Failed to connect to MySQL: " . mysqli_connect_error();
}
$sql="INSERT INTO Persons (FirstName, LastName, Age)
VALUES
('mysqli_real_escape_string($con,$_POST[firstname])','mysqli_real_escape_string($con,$_POST[lastname])','mysqli_real_escape_string($con,$_POST[age])')";
if (!mysqli_query($con,$sql))
{
die('Error: ' . mysqli_error($con));
}
echo "1 record added";
mysqli_close($con);
}
You can validate email in php like this:
filter_var($emailAddress, FILTER_VALIDATE_EMAIL)
php filter

For proper validation of a form, some aspects have to be taken into account, to help filter an excess of garbage input. My approach is this:
First of all, check the minimum lenght of the text. This way, you decrease the risk of getting meaningless input. Secondly, check the maximum lenght of the text; you don't want someone flooding your database with a ton of text just for fun. And thirdly, you should use regular expressions to check proper formats for the different fields (a postal code, a phone number, an e-mail) and very important, allow only characters that are required in that field, to avoid or minimize the risk of someone sending miserable cross-site injections thru the input.
Here an orientative example:
function validate_form() {
$errors = array();
// El nombre del usuario es necesario
if (! strlen(trim($_POST['user_name']))) {
$errors[] = 'The username is required.';
}
// El nombre del usuario no debe contener caracteres problemáticos
if (preg_match('#[^a-zA-Z0-9_\- ]#', trim($_POST['user_name']))) {
$errors[] = 'The username cannot contain invalid characters.';
}
// El nombre del usuario no debe tener menos de 3 caracteres
if (strlen(trim($_POST['user_name'])) < 3) {
$errors[] = 'The username cannot have less than 3 characters long.';
}
// El nombre del usuario no debe tener más de 24 caracteres
if (strlen(trim($_POST['user_name'])) > 24) {
$errors[] = 'The username cannot have more than 24 characters long.';
}
// La contraseña es necesaria
if (! strlen(trim($_POST['password']))) {
$errors[] = 'The password is required.';
}
// La contraseña no debe contener caracteres problemáticos
if (preg_match('#[^a-zA-Z0-9_\-]#', trim($_POST['password']))) {
$errors[] = 'The password cannot contain invalid characters.';
}
// La contraseña no debe tener menos de 6 caracteres
if (strlen(trim($_POST['password'])) < 6) {
$errors[] = 'The password cannot have less than 6 characters long.';
}
// La contraseña no debe tener más de 12 caracteres
if (strlen(trim($_POST['password'])) > 12) {
$errors[] = 'The password cannot have more than 12 characters long.';
}
// La contraseña debe contener letras y números
if (! preg_match('/([a-zA-Z][0-9]|[0-9][a-zA-Z])+/', trim($_POST['password']))) {
$errors[] = 'The password must contain letters and numbers.';
}
// Password y Password Check deben ser iguales
if ($_POST['password'] != $_POST['password_check']) {
$errors[] = 'Password and Password Check do not match.';
}
// El correo electrónico es necesario
if (! strlen(trim($_POST['e_mail']))) {
$errors[] = 'The e-mail is required.';
}
// El correo electrónico no debe contener caracteres problemáticos
if (preg_match('/[^a-zA-Z0-9_\-#\.]/', trim($_POST['e_mail']))) {
$errors[] = 'The e-mail cannot contain invalid characters.';
}
// El correo electrónico no debe tener más de 64 caracteres
if (strlen(trim($_POST['e_mail'])) > 64) {
$errors[] = 'The e-mail cannot have more than 64 characters long.';
}
// El correo electrónico debe tener un formato correcto
if (! preg_match('/[^#\s]{3,}#([-a-z0-9]{3,}\.)+[a-z]{2,}/', trim($_POST['e_mail']))) {
$errors[] = 'The e-mail must have a valid format.';
}
// El país seleccionado debe ser válido
if (! array_key_exists($_POST['country'], $GLOBALS['countries'])) {
$errors[] = 'Please select a valid country.';
}
// La ciudad es necesaria
if (! strlen(trim($_POST['city']))) {
$errors[] = 'The city is required.';
}
// La ciudad no debe contener caracteres problemáticos
if (preg_match('#[^a-zA-Z\- ]#', trim($_POST['city']))) {
$errors[] = 'The city cannot contain invalid characters.';
}
// La ciudad no debe tener menos de 3 caracteres
if (strlen(trim($_POST['city'])) < 3) {
$errors[] = 'The city cannot have less than 3 characters long.';
}
// La ciudad no debe tener más de 64 caracteres
if (strlen(trim($_POST['city'])) > 64) {
$errors[] = 'The city cannot have more than 64 characters long.';
}
// El mes seleccionado debe ser válido
if (! array_key_exists($_POST['month'], $GLOBALS['months'])) {
$errors[] = 'Please select a valid month.';
}
// El día seleccionado debe ser válido
if (! array_key_exists($_POST['day'], $GLOBALS['days'])) {
$errors[] = 'Please select a valid day.';
}
// El año seleccionado debe ser válido
if (! array_key_exists($_POST['year'], $GLOBALS['years'])) {
$errors[] = 'Please select a valid year.';
}
// El nombre real del usuario es necesario
if (! strlen(trim($_POST['real_name']))) {
$errors[] = 'Your real name is required.';
}
// El nombre real del usuario no debe contener caracteres problemáticos
if (preg_match('#[^a-zA-Z\- ]#', trim($_POST['real_name']))) {
$errors[] = 'Your real name cannot contain invalid characters.';
}
// El nombre real del usuario debe tener menos de 3 caracteres
if (strlen(trim($_POST['real_name'])) < 3) {
$errors[] = 'Your real name cannot have less than 3 characters long.';
}
// El nombre real del usuario no debe tener más de 64 caracteres
if (strlen(trim($_POST['real_name'])) > 64) {
$errors[] = 'Your real name cannot have more than 64 characters long.';
}
// El número CAPTCHA introducido debe ser correcto
$captcha_num_1 = substr($_POST['captcha'], 0, 1);
$captcha_num_2 = substr($_POST['captcha'], 1, 1);
$captcha_num_3 = substr($_POST['captcha'], 2, 1);
$captcha_num_4 = substr($_POST['captcha'], 3, 1);
$captcha_num_5 = substr($_POST['captcha'], 4, 1);
if (($_SESSION['num1'] != crypt($captcha_num_1, $_SESSION['num1'])) ||
($_SESSION['num2'] != crypt($captcha_num_2, $_SESSION['num2'])) ||
($_SESSION['num3'] != crypt($captcha_num_3, $_SESSION['num3'])) ||
($_SESSION['num4'] != crypt($captcha_num_4, $_SESSION['num4'])) || ($_SESSION['num5'] != crypt($captcha_num_5, $_SESSION['num5']))) {
$errors[] = 'The CAPTCHA number entered is not correct.';
}
// El nombre de usuario y la dirección de e-mail deben ser únicos en la base de datos
global $db;
$sql = 'SELECT user_name, e_mail FROM users';
$q = mysqli_query($db, $sql);
if (mysqli_num_rows($q) > 0) {
while ($users = mysqli_fetch_object($q)) {
if ($users->user_name == $_POST['user_name']) {
$errors[] = 'This username already exists in the database. Please use a different one.';
}
if ($users->e_mail == $_POST['e_mail']) {
$errors[] = 'This e-mail address already exists in the database. Please use a different one.';
}
}
}
// Si hay errores, resetear el CAPTCHA
if (is_array($errors)) { reset_captcha();
}
return $errors;
}

Please find the following answer
<?php
$con=mysqli_connect("example.com","peter","abc123","my_db");
//Check connection
if (mysqli_connect_errno())
{
echo "Failed to connect to MySQL: " . mysqli_connect_error();
}
$c=0;
if($_POST['firstname']=="")
{
$msg='Please enter firstname';
$c++;
}
if($_POST['lastname']=="")
{
$msg1='Please enter lastname';
$c++;
}
if($_POST['age']=="")
{
$msg2='Please enter age';
$c++;
}
if($c==0)
{
$sql="INSERT INTO Persons (FirstName, LastName, Age)
VALUES
('$_POST[firstname]','$_POST[lastname]','$_POST[age]')";
if (!mysqli_query($con,$sql))
{
die('Error: ' . mysqli_error($con));
}
echo "1 record added";
}
mysqli_close($con);
?>
Print $msg,$msg1,$msg2 in respective places

Related

PHP | Input control statements do not do the job

I don't understand why I have implemented control instructions in my form that don't work, every time they record in the database all the behaviors that I don't want.
/*ERRORI*/
$nome_obbligatorio = "";
$errore_nome = "";
$cognome_obbligatorio = "";
$errore_cognome = "";
$password_obbligatoria = "";
$due_psw_non_coincidono = "";
$password_err_min_8_caratteri = "";
$password_err_min_8_max_20_caratteri = "";
$errore_password = "";
$citta_obbligatorio = "";
$errore_citta = "";
$cap_obbligatorio = "";
$errore_cap = "";
$errore_cap_caratteri_speciali = "";
$telefono_obbligatorio = "";
$errore_telefono = "";
$iban_obbligatorio = "";
$iban_err_min_27_caratteri = "";
/*FINE ERRORI*/
if(isset($_POST['submit'])) {
/*CAMPI FORM*/
$nome = $connessione->real_escape_string($_POST['nome']);
$cognome = $connessione->real_escape_string($_POST['cognome']);
$password = $connessione->real_escape_string($_POST['password']);
$citta = $connessione->real_escape_string($_POST['citta']);
$cap = $connessione->real_escape_string($_POST['cap']);
$telefono = $connessione->real_escape_string($_POST['telefono']);
$iban = $connessione->real_escape_string($_POST['iban']);
$email = $connessione->real_escape_string($_POST['email']);
$confermaPassword = $connessione->real_escape_string($_POST['confermaPassword']);
$indirizzo = $connessione->real_escape_string($_POST['indirizzo']);
$indirizzo_txt = $connessione->real_escape_string($_POST['indirizzo_txt']);
$civico = $connessione->real_escape_string($_POST['civico']);
$codice_fiscale = $connessione->real_escape_string($_POST['codice_fiscale']);
$categoria_richiesta = $connessione->real_escape_string($_POST['categoria_richiesta']);
/*FINE CAMPI FORM*/
/*----------------------------------------------------*/
if (empty($_POST["nome"])) {
$nome_obbligatorio = "Nome è un campo obbligatorio";
} else {
if (!preg_match("~[0-9]+~", $nome)) {
$errore_nome = "Il nome non può contenere numeri";
}
}
if (empty($_POST["cognome"])) {
$cognome_obbligatorio = "Cognome è un campo obbligatorio";
} else {
if (!preg_match("~[0-9]+~", $cognome)) {
$errore_cognome = "Il cognome non può contenere numeri";
}
}
if (empty($_POST["password"])) {
$password_obbligatoria = "Password è un campo obbligatorio";
} else {
if( strlen($password ) < 8 )
{
$password_err_min_8_caratteri .= "La Password deve contenere almeno 8 caratteri";
}
if( strlen($password ) > 20 )
{
$password_err_min_8_max_20_caratteri .= "La Password può essere composta da 8 fino a 20 caratteri";
}
if( !preg_match("A(?=[-_a-zA-Z0-9]*?[A-Z])(?=[-_a-zA-Z0-9]*?[a-z])(?=[-_a-zA-Z0-9]*?[0-9])[-_a-zA-Z0-9]{6,}z", $password ) )
{
$errore_password .= "La Password deve contenere almeno una lettera maiuscola una minuscola e un numero";
}
}
if (empty($_POST["citta"])) {
$citta_obbligatorio = "Città è un campo obbligatorio";
} else {
if (!preg_match("#\W+#", $citta)) {
$errore_citta = "Città non può contenere caratteri speciali";
}
}
if (empty($_POST["cap"])) {
$citta_obbligatorio = "CAP è un campo obbligatorio";
} else {
if(!preg_match("#[a-z]+#", $cap ))
{
$errore_cap .= "Il CAP non può contenere lettere";
}
if( !preg_match("#\W+#", $cap ) )
{
$errore_cap_caratteri_speciali .= "Il CAP non può contenere caratteri speciali";
}
}
if (empty($_POST["telefono"])) {
$telefono_obbligatorio = "Telefono è un campo obbligatorio";
} else {
if( !preg_match("#[a-z]+#", $telefono ) )
{
$errore_telefono .= "Il telefono non può contenere lettere";
}
}
if (empty($_POST["iban"])) {
$iban_obbligatorio = "IBAN è un campo obbligatorio";
} else {
if( strlen($password ) < 27 )
{
$iban_err_min_27_caratteri .= "L' IBAN deve contenere almeno 27 caratteri";
}
}
if ($password != $confermaPassword)
$due_psw_non_coincidono = "Le due password non coincidono!";
$CONTROLLA = mysqli_query($connessione,"SELECT email FROM collaboratori WHERE email='$email'");
$SE_IL_RISULTATO_IMMESSO=mysqli_num_rows($CONTROLLA);
if($SE_IL_RISULTATO_IMMESSO==0)
{
$hash = password_hash($password, PASSWORD_BCRYPT);
$connessione->query("INSERT INTO collaboratori
(
nome,
cognome,
email,
password,
citta,
indirizzo,
indirizzo_txt,
civico,
cap,
telefono,
codice_fiscale,
iban,
categoria_richiesta
)
VALUES
(
'$nome',
'$cognome',
'$email',
'$hash',
'$citta',
'$indirizzo',
'$indirizzo_txt',
'$civico',
'$cap',
'$telefono',
'$codice_fiscale',
'$iban'
)");
header("location: index.php?col_reg=Y");
}
else
{
$indirizzo_email_gia_registrato = 'Indirizzo email, già registrato' ;
}
}
for example the field 'nome' and 'cognome', the controls seem non-existent
I can't understand why they fail every time,thanks in advance for your support.
The problem is that you set your error variables, but do not check them before you send the query. You have to write some if() statement before sending the SQL query checking if there were any errors before. One way to do this is to use an array and fill it with error messages:
$errors = array();
if (/*name is invalid */) {
$errors[] = 'Your name is invalid.';
}
if (/*city is invalid */) {
$errors[] = 'Your city is invalid.';
}
if (/*email already used */) {
$errors[] = 'The email address is already being used.';
}
//...
// check if there were any validation errors above.
if (count($errors) > 0) {
// deal with error messages like showing them with 'echo' and `foreach`
} else {
// all fine, send the query.
}

CI3.0 passing variable between controller and module

I have this method:
public function signup_validation() {
//definizioni setting per email di conferma
$emailsetting = array('mailtype' => 'html' );
$emailfrom = 'misure#lagiumentabardata.netsons.org';
$emailsubject ='Conferma registrazione';
$this->load->library('form_validation');
$this->form_validation->set_rules('email','Email','required|trim|valid_email|is_unique[user.email]'); //check se la mail è davvero una mail valida e se esiste gia nel database $this->form_validation->set_rules('password','Password','required|trim'); $this->form_validation->set_rules('cpassword','Conferma Password','required|trim|matches[password]');
$this->form_validation->set_message('is_unique','email già esistente nel nostro database'); //override messaggio di errore
//check se il form è valido allora passa altrimenti ritorna al form. if ($this->form_validation->run() == true) {
//generare key
$key = sha1(uniqid());
//inviare una mail all'utente
$this->load->library('email', $emailsetting); //caricamento libreria
$this->load->model('model_users'); //caricamento modello per il controllo del db utente
$this->email->from($emailfrom,'La Giumenta Bardata');
$this->email->to($this->input->post('email'));
$this->email->subject($emailsubject);
$emailmessage = "<h1>ciao mondo</h1>
<a href='".base_url()."signup/register_user/$key'>click qui</a>"; //fare riferimento alla funzione register_user
$this->email->message($emailmessage);
//controllo scrittura dell'utente nel db
if ($this->model_users->add_temp_user($key) == true) { //passaggio chiave al modello che si occupa di aggiungerlo al DB
//invio email utente
if ($this->email->send() == true) {
echo "email inviata correttamente";
} else { echo "errore nell'invio stronzo";}
} else { echo "problemi nell'inserimento del db"; }
} else {
echo '<script>alert("TU NON PUOI PASSARE!");</script>';
$this->registrazione(); } }
In a signup.php controller.
First of all I don't understand why if I move $emailmessage variable where I set all the variables ($emailsetting, $emailfrom etc.) I get an error that the $emailmessage variable is undefined -.-
but, the real problem is that i can't pass the $key variable to a module:
public function add_temp_user($key){
$data = array('email' => $this->input->post('email'),
'nome' => $this->input->post('nome'),
'cognome' => $this->input->post('cognome'),
'password' => md5($this->input->post('password')),
'userkey'=>$key
);
$query = $this->db->insert('temp_users',$data); //generazione query
//check se la query è stata eseguita correttamente
if ($query) {
return true;
} else {
return false;
}
}
How can I pass a variable from a controller to a module? I try everything, from set the $key as public to set the __construct and nothing work...when the app needs to call the model I have an Undefined $key variable..
Thanks for help
You can move $emailmessage = up where the other things are set. But the line $key = sha1(uniqid()); must come before those assignments.
I tested this as best I could without having your database. Seems to work. $key makes it to the model anyway.
Notice that I build the link <a href=... a little differently, making better use of Codeigniter's abilities.
public function signup_validation()
{
//generare key
$key = sha1(uniqid());
//definizioni setting per email di conferma
$emailsetting = array('mailtype' => 'html');
$emailfrom = 'misure#lagiumentabardata.netsons.org';
$emailsubject = 'Conferma registrazione';
$emailmessage = "<h1>ciao mondo</h1>
<a href='".base_url("signup/register_user/$key")."'>click qui</a>"; //fare riferimento alla funzione register_user
$this->load->library('form_validation');
$this->form_validation->set_rules('email', 'Email', 'required|trim|valid_email|is_unique[user.email]'); //check se la mail è davvero una mail valida e se esiste gia nel database $this->form_validation->set_rules('password','Password','required|trim'); $this->form_validation->set_rules('cpassword','Conferma Password','required|trim|matches[password]');
$this->form_validation->set_message('is_unique', 'email già esistente nel nostro database'); //override messaggio di errore
//check se il form è valido allora passa altrimenti ritorna al form. if ($this->form_validation->run() == true) {
//inviare una mail all'utente
$this->load->library('email', $emailsetting); //caricamento libreria
$this->load->model('model_users'); //caricamento modello per il controllo del db utente
//use chaining here, much more efficient
$this->email
->from($emailfrom, 'La Giumenta Bardata')
->to($this->input->post('email'))
->subject($emailsubject)
->message($emailmessage);
//controllo scrittura dell'utente nel db
if($this->model_users->add_temp_user($key))
{ //passaggio chiave al modello che si occupa di aggiungerlo al DB
//invio email utente
if($this->email->send() == true)
{
echo "email inviata correttamente";
}
else
{
echo "errore nell'invio stronzo";
}
}
else
{
echo "problemi nell'inserimento del db";
}
//these lines are not connected to anything as you have them in your question.
// So I have commented them out
//else {
// echo '<script>alert("TU NON PUOI PASSARE!");</script>';
// $this->registrazione(); }
}
Here's the model function.
I capture the inputs like this input->post(NULL, TRUE); because it grabs all the inputs at once. That eliminates multiple calls to input->. With the second argument=TRUE the inputs are sanitized.
Because db->insert() returns either true or false there is no need for the if/then statement.
public function add_temp_user($key)
{
$posted = $this->input->post(NULL, TRUE);
$data = array('email' => $posted('email'),
'nome' => $posted('nome'),
'cognome' => $posted('cognome'),
'password' => md5($posted('password')),
'userkey' => $key
);
//tornare successo o il fallimento di ricerca
return $this->db->insert('temp_users', $data); //generazione query
}

cant show up my image php from a DB

the problem is when it does return the binary file, pls help me
<!DOCTYPE html>
<html>
<head>
<title>Tienda Online</title>
<FORM action="upload_imagen.php" enctype="multipart/form-data" method="POST">
<input type="file" name="imagen"> Buscar imagen
<input type="submit" value="Buscar">
</FORM>
<div id="visualizar">
</div>
<form action="mostrar_imagen.php" method="POST">
<input type="text" name="valor" >
<input type="submit" value="mostrar">
</form>
</html>
upload_imagen.php this file upload an image and does storage in a DB
<?php
// Conexion a la base de datos
require "db_model.php";
class upload extends db_model {
function whatever() {
// Comprobamos si ha ocurrido un error.
if (!isset($_FILES["imagen"]) || $_FILES["imagen"]["error"] > 0) {
echo "Ha ocurrido un error.";
} else {
var_dump($_FILES["imagen"]);
// Verificamos si el tipo de archivo es un tipo de imagen permitido.
// y que el tamaño del archivo no exceda los 16MB
$permitidos = array("image/jpg", "image/jpeg", "image/gif", "image/png");
$limite_kb = 16384;
if (in_array($_FILES['imagen']['type'], $permitidos) && $_FILES['imagen']['size'] <= $limite_kb * 1024) {
// Archivo temporal
$imagen_temporal = $_FILES['imagen']['tmp_name'];
// Tipo de archivo
$tipo = $_FILES['imagen']['type'];
// Leemos el contenido del archivo temporal en binario.
$fp = fopen($imagen_temporal, 'r+b');
$data = fread($fp, filesize($imagen_temporal));
fclose($fp);
//Podríamos utilizar también la siguiente instrucción en lugar de las 3 anteriores.
// $data=file_get_contents($imagen_temporal);
// Escapamos los caracteres para que se puedan almacenar en la base de datos correctamente.
$data = mysql_real_escape_string($data);
// Insertamos en la base de datos.
$this->query ="INSERT INTO imagenes (imagen, tipo_imagen) VALUES ('$data', '$tipo')";
$resultado = $this->execute_query();
if ($resultado) {
echo "El archivo ha sido copiado exitosamente.";
} else {
echo "Ocurrió algun error al copiar el archivo.";
}
} else {
echo "Formato de archivo no permitido o excede el tamaño límite de $limite_kb Kbytes.";
}
}
}
}
$obj = new upload();
$obj->whatever();
?>
mostrar_imagen.php this section retrives the image in binary format, then i want to show it, so i read that i need a header and send it the type of image it is for example .jpg, .gif but i dont know if a i have an error
<?php
require 'db_model.php';
class mostrar extends db_model {
function __construct()
{
$id = $_POST['valor'];
$this->query = "SELECT imagen, tipo_imagen
FROM imagenes
WHERE imagen_id=$id";
$datos = $this->execute_query_as();
$imagen = $datos['imagen']; // Datos binarios de la imagen.
$tipo = $datos['tipo_imagen']; // Mime Type de la imagen.
// Mandamos las cabeceras al navegador indicando el tipo de datos que vamos a enviar.
---- > my problem is here, i guess
header("Content-type: image/jpg");
echo $imagen;
// A continuación enviamos el contenido binario de la imagen.
}
}
$obj = new mostrar();
?>
db_model.php
<?php
/**
* clase de la base de datos
*/
include_once('config.php');
class db_model
{
private $db_host = "localhost";
private $db_user = "root";
private $db_pass = "";
protected $db_name = "tienda_cartas";
protected $query;
protected $rows = array();
private $conection;
private function open_conection()
{
$this->conection = new mysqli($this->db_host,$this->db_user,$this->db_pass,$this->db_name);
if ($this->conection->connect_errno) {
echo "error al conectar";
die();
} else {
echo "conectado";
}
}
private function close_conection() {
$this->conection->close();
}
protected function execute_query() {
$this->open_conection();
$result = $this->conection->query($this->query);
if(!$result){
echo "no se pudo ejecutar el sql";
}
$this->close_conection();
return $result;
header("location:index.php");
}
protected function execute_query_as() {
$this->open_conection();
$result = $this->conection->query($this->query);
if(!$result){
echo "no se pudo ejecutar el sql";
}
$array_as = $result->fetch_assoc();
if(!$array_as){
echo "no hay incidencias";
die();
}
$this->close_conection();
return $array_as;
}
}
?>
This could be your problem:
$data = mysql_real_escape_string($data);
In your classes you use mysqli_* functions, but this one belongs to the deprecated mysql_* functions. When you call it it will automatically try to open a new database connection with mysql_connect(), which will fail because it doesn't have any information about your host. mysql_real_escape_string() will then return false:
Warning: mysql_real_escape_string(): A link to the server could not be established in test.php on line 2
bool(false)
Just remove the line, escaping binary data will most probably ruin it anyway. Instead you should use prepared statements to prevent SQL injections.

update php database with data of two

I have two tables where I need to display text in a table corresponding to the users of the users table.
So I did this:
$email = $_SESSION['email'];
$select = mysql_query("SELECT t.id, t.id_textos, t.userTitleSite, t.userTextSobre, t.userTextContatos, t.userTextMaisInfos FROM vms_textos t INNER JOIN vms_users u ON (t.id = u.id) LIMIT 1") or print (mysql_error());
while($res_select = mysql_fetch_array($select)){
$userTitleSite = $res_select["userTitleSite"];
$userTextSobre = $res_select["userTextSobre"];
$userTextContatos = $res_select["userTextContatos"];
$userTextMaisInfos = $res_select["userTextMaisInfos"];
$id = $res_select["id"];
and working.
Now i need to update this information straight from the INPUTS..
but I can not do because my field UPDATE must be wrong because it always resets everything after that grip on SUBMIT.
This is the code I'm using. Please see what is wrong:
$query=mysql_query("UPDATE vms_textos SET userTitleSite='$userTitleSite', userTextSobre='$userTextSobre', userTextContatos='$userTextContatos', userTextMaisInfos='$userTextMaisInfos' WHERE t.id=u.id");
Thanks!
[EDIT]
ALL IMPORTANT CODE:
// INCLUDES.PHP
// Starts
ob_start();
session_start();
// Globais
$startaction="";
// Ação
if(isset($_GET["acao"])){
$acao=$_GET["acao"];
$startaction=1;
}
// Conexão com o banco de dados
$conectar=new DB;
$conectar=$conectar->conectar();
// Metodos de Cadastro
if($startaction == 1){
if($acao == "cadastrar"){
$usuario=$_POST["usuario"];
$nome=$_POST["nome"];
$sobrenome=$_POST["sobrenome"];
$telefone=$_POST["telefone"];
$email=$_POST["email"];
$senha=$_POST["senha"];
if(empty($usuario) || empty($nome) || empty($sobrenome) || empty($telefone) || empty($email) || empty($senha)){
$msg="Preencha todos os campos!";
}
// Todos os campos preenchidos
else {
// Email válido
if(filter_var($email,FILTER_VALIDATE_EMAIL)){
// Senha inválida
if(strlen($senha) < 8){
$msg="As senhas devem conter no mínimo oito caracteres!";
}
// Senha válida
else {
// Executa a classe de cadastro
$conectar=new Cadastro;
echo "<div class=\"flash\">";
$conectar=$conectar->cadastrar($usuario, $nome, $sobrenome, $telefone, $email, $senha);
echo "</div>";
}
}
// Email invalido
else{
$msg="Digite seu e-mail corretamente!";
}
}
}
}
// Método de Login
if($startaction == 1){
if($acao == "logar"){
// Dados
$email=addslashes($_POST["email"]);
$senha=addslashes(sha1($_POST["senha"].""));
if(empty($email) || empty($senha)){
$msg="Preencha todos os campos!";
} else{
if(!filter_var($email,FILTER_VALIDATE_EMAIL)){
$msg="Digite seu e-mail corretamente!";
} else {
// Executa a busca pelo usuário
$login=new Login;
echo "<div class=\"flash\">";
$login=$login->logar($email, $senha);
echo "</div>";
}
}
}
}
// Método de Checar usuário
if(isset($_SESSION["email"]) && isset($_SESSION["senha"])){
$logado=1;
$nivel=$_SESSION["nivel"];
}
// LOGIN.PHP -- CLASSE DE LOGIN
class Login {
public function logar($email, $senha){
$buscar=mysql_query("SELECT * FROM vms_users WHERE email='$email' AND senha='$senha' LIMIT 1");
if(mysql_num_rows($buscar) == 1){
$dados=mysql_fetch_array($buscar);
if($dados["status"] == 1){
$_SESSION["email"]=$dados["email"];
$_SESSION["senha"]=$dados["senha"];
$_SESSION["nivel"]=$dados["nivel"];
setcookie("logado",1);
$log=1;
} else{
$flash="Usuário bloqueado! Entre em contato conosco!";
}
}
if(isset($log)){
$flash="Você foi logado com sucesso!";
} else{
if(empty($flash)){
$flash="Ops, digite seu e-mail e sua senha corretamente!";
}
}
echo $flash;
}
}
// CADASTRO.PHP -- CLASSE DE CADASTRO
class Cadastro{
public function cadastrar($usuario, $nome, $sobrenome, $telefone, $email, $senha){
// Tratamento das variaveis
$usuario=ucwords(strtolower($usuario));
$nome=ucwords(strtolower($nome));
$sobrenome=ucwords(strtolower($sobrenome));
$telefone=ucwords(strtolower($telefone));
$email=ucwords(strtolower($email));
$senha=sha1($senha."");
// Inserção no banco de dados
$validaremail=mysql_query("SELECT * FROM vms_users WHERE email='$email' OR usuario='$usuario'");
$contar=mysql_num_rows($validaremail);
if($contar == 0){
$insert=mysql_query("INSERT INTO vms_users(usuario, nome, sobrenome, telefone, email, senha, nivel, status) VALUES('$usuario','$nome','$sobrenome','$telefone','$email','$senha','1','0')");
} else{
$flash="Desculpe, mas já existe um usuário cadastrado com este e-mail em nosso sistema!";
}
if(isset($insert)){
// Cadatro ok
$flash="Cadastro realizado com sucesso, aguarde nossa aprovação!";
} else{
if(empty($flash)){
$flash="Ops, houve um erro em nosso sistema!";
}
}
// Retorno para o usuário
echo $flash;
}
}
$query=mysql_query("UPDATE vms_textos SET t.userTitleSite='$userTitleSite' WHERE t.id='u.id'");
$query=mysql_query("UPDATE vms_textos SET userTitleSite='$userTitleSite' WHERE t.id=u.id");
what field do u want to update in db? SET that particular field in mysql_query(). i mentioned here.. try like this if u set all fields then all fields are updated..

Unable to edit ints

I'm building an admin panel in PHP. I'm new to PHP and I can't get my edit page to work as I need it to. I can edit the name, but 2 values which represent "Active User" and "Access Level" are set to 0 and I can't change it from 0 on my edit page, only from PhpmyAdmin..
<?php
// Inserir o registo na BD
include_once ('config1.php');
// Estabelecer a ligação à BD
$connection = new mysqli('localhost', 'root', '123456', 'admin1');
//Verificar se a ligação foi estabelecida com sucesso
if (mysqli_connect_errno() ) {
echo "</h2>Erro no acesso a BD</h2>" . mysqli_connect_error();
exit();
}
// Validar se os campos do formulário foram preenchidos pelo utilizador
// Verificar se "username" foi enviado
if (isset($_POST['iusername']) == FALSE) {
echo ("Erro de submissão");
exit();
} else {
$username = trim($_POST['iusername']);
}
if (isset($_POST['inome']) == FALSE) {
echo ("Erro de submissão");
exit();
} else {
$nome = trim($_POST['inome']);
}
if (isset($_POST['inivel']) == FALSE) {
echo ("Erro de submissão");
exit();
} else {
$apelido = trim($_POST['inivel']);
}
if (isset($_POST['iativo']) == FALSE) {
echo ("Erro de submissão");
exit();
} else {
$telefone = trim($_POST['iativo']);
}
if (isset($_POST['iemail']) == FALSE) {
echo ("Erro de submissão");
exit();
} else {
$email = trim($_POST['iemail']);
}
if (isset($_POST['ipass']) == FALSE) {
echo ("Erro de submissão");
exit();
} else {
$pass = trim($_POST['ipass']);
}
if (isset($_POST['irpass']) == FALSE) {
echo ("Erro de submissão");
exit();
} else {
$repass = trim($_POST['irpass']);
}
// Função de validação do email (chamada mais abaixo no código)
function isValidEmail($email){
return #eregi("^[_a-z0-9-]+(\.[_a-z0-9-]+)*#[a-z0-9-]+(\.[a-z0-9-]+)*(\.[a-z] {2,3})", $email);
// Validar se o nº de caracteres do "username" está entre 4 e 12
if (strlen($username) < 4 || strlen($username) > 12) {
$erro = true;
$msgerro .= "<p>erro: \"username\" deve conter entre 4 e 12 caracteres</p>";
}
// Validar se o nome tem entre 3 e 40 caracteres
if (strlen($nome) < 3 || strlen($nome) > 40) {
//echo (strlen($nome));
$erro = true;
$msgerro .= "<p>erro: \"nome\" deve conter entre 3 a 40 caracteres</p>";
}
// Validação das passwords
$mudapass = false;
if (strlen($password) == 0 && strlen($rpassword) == 0) {
$mudapass = false;
} else {
$mudapass = true;
}
// 2.2. Validar o tamanho da password
if (strlen($password) < 4 || strlen($password)> 16) {
$erro = true;
$msgerro .= "<p>erro: \"password\" deve conter entre 4 a 16 caracteres</p>";
}
}
// 3. Validar se as duas passwords correspondem
if ($password != $rpassword) {
$erro = true;
$msgerro .= "<p>\"passwords\" não correspondem</p>";
}
// validação de email
// Chama a nova função "isValidEmail"
if (isValidEmail($email) == false) {
$erro = true;
$msgerro .= "<p>email inválido</p>";
}
// Final das validações (avisa caso algum erro seja detectado)
if ($erro) {
echo "<p>Formulário submetido com erros</p>";
echo $msgerro;
echo "<br>";
// Desenha 2 botões "Corrigir" e "Listar"
echo "<a class='ains' href='javascript:history.go(-1)' title='Volta à página anterior'>Corrigir </a>";
echo "<br/>";
echo "<a class='ains' href='lista.php'>Listar</a>";
exit();
}
if($password != $rpassword){
echo "ERRO: PASSWORDS SAO DIFERENTES";
}
$sql= "UPDATE usuarios SET
nome = '$nome';
email = '$email';
nivel = '$nivel';
ativo = '$ativo';
WHERE
usuario = '$username'";
if ($mudapass == TRUE) {
$sql = "UPDATE usuarios SET nome = '$nome',
password = '$password',
email = '$email',
nivel = '$nivel',
ativo = '$ativo', WHERE usuario = '$username'";
}
if ($mudapass == FALSE) {
$sql = "UPDATE usuarios SET
nome = '$nome',
email = '$email',
nivel = '$nivel',
ativo = '$ativo'
WHERE
usuario = '$username'";
}
$connection->query($sql);
// Lista users depois de actualizar
header("location:lista.php");
?>
It looks like a naming problem. Two of your variables don't seem to follow the same convention as the rest of them, and unless I'm missing some extra processing before the query, then you should change these two lines:
$apelido = trim($_POST['inivel']);
// ...several lines later
$telefone = trim($_POST['iativo']);
to this:
$nivel = trim($_POST['inivel']);
// ...several lines later
$ativo = trim($_POST['iativo']);

Categories