Why is this 1 image showing an infinite number of times? - php

Question

$pgroup = $Sys->db->query("SELECT dj_photo_group.photo_group, dj_photo.name FROM dj_photo_group, dj_photo WHERE dj_photo_group.photo_group = dj_photo.img_group ORDER BY dj_photo.img_group DESC");
while($photo = $pgroup->fetch_object()) {
echo '<div class="photo_head">' . ucfirst($photo->photo_group) . '</div>';
echo '<div class="photo_sub">';
while($photo->name) {
echo '<img src="photogallery/' . $photo->photo_group . '/' . $photo->name . '" />';
}
echo '</div>';
}
This is showing the same 1 image over and over again. I have 3 groups: Wedding, 5points and Misc that have 2 images each. It only shows Weddings with 1 image infinite number of times.
What am I doing wrong and how can I fix it?

Answer 1

$photo->name is always true. So if you use it in a while loop, you're essentially saying:
while(true){
// do this
}
Remember, while loops will keep going as long as the condition specified is true.
You should really be using an if statement instead.
if($photo->name){
// do this
}

Answer 2

while($photo->name) will repeat until $photo->name is false. Because in the loop there is nothing that will change it, it will always be true, and so the loop continues forever.
Like Nishant said, you want to replace it with an if statement.

Answer 3

while($photo->name) is entering into infinite loop as the condition is always true. You should put an end condition to this while loop or otherwise you can go for if condition also
if($photo->name)

Answer 4

Try this.. this solution will provide you your desired layout....
$pgroup1 = $Sys->db->query("SELECT dj_photo_group FROM photo_group GROUP BY dj_photo_group");
while ($photo1 = $pgroup1->fetch_object())
{
echo '<div class="photo_head">' . ucfirst($photo1->dj_photo_group) . '</div>';
echo '<div class="photo_sub">';
$pgroup2 = $Sys->db->query("SELECT name FROM dj_photo WHERE img_group = '$photo1->dj_photo_group'");
while ($photo2 = $pgroup2->fetch_object())
{
echo '<img src="photogallery/' . $photo1->dj_photo_group . '/' . $photo2->name . '" />';
}
echo '</div>';
}