remove last character after concatenating string output by for loop? - php

$holder = '';
foreach($fields as $key){
$holder .= $key.', ';
}
echo $holder;
I have the code above, it outputs "a, b, c, "
I want to remove the comma after c.
I tried substr and it is not working.
any help?

That's not how it's done.
$holder = join(', ', $fields)

You can use implode() to join all array elements together :
<?php
$holder = implode(', ', $fields);
echo $holder;
?>

You can use substr like this
$holder = '';
foreach($fields as $key){
$holder .= $key.', ';
}
$newholder=substr($holder, 0, -1);
echo $newholder;

Related

Array value from variable

Could somebody explaind me ***why array count is not 2
$value = '"305", "112", ';
//remove last comma and space
echo $value = rtrim($value, ', ');
echo '<br>';
$value = array($value);
echo $array_length = count($value); //***
You should use explode function to get array like the following code :
$value = '"305", "112"';
$value = rtrim($value, ', ');
echo '<br>';
$value = explode(',',$value);
echo $array_length = count($value);
you can use explode() to get it.
$value = '"305", "112", ';
//remove last comma and space
echo $value = rtrim($value, ', ');
echo '<br>';
$value = explode(',',$value);
echo $array_length = count($value);
you can also do this if you want to create an array from that these type of strings and do array count.
$arr = array_filter(array_map('trim', str_getcsv($value)));
print_r($arr);
echo count($arr);
when you are creating an array with array($value), the entire value of $value counted as a single element of an array. Thats why you are getting count($value) not equal to 2.

Implode and Explode Array then wrap it inside a sample data

I have a string that looks like this:
$str = "Col1, Col2, Col3";
My question is how can I make it look like this
FORMAT(SUM('Col1'),2),FORMAT(SUM('Col2'),2),FORMAT(SUM('Col3'),2)
I am trying to use implode and explode but it's not working for me.
Here is my attempt:
$sample = "Col1, Col2, Col3";
$test = explode(",", $sample);
$test = "'" . implode("', FORMAT(SUM('", $test) . "), 2";
$sample = "Col1,Col2,Col3";
$test= explode(',',$sample);
$_test = '';
foreach($test as $t){
$_test .= "FORMAT(SUM('$t'),2),";
}
$_test = rtrim($_test,',');
I dont know if you can achiev this using explode, but you for sure can using a foreach loop.
$sample = 'Col1,Col2,Col3';
$result = '';
$parts = explode(',', $sample);
foreach ($parts as $part) {
$result .= 'FORMAT(SUM(' . $part . '), 2)';
$result .= (end($parts) !== $part) ? ', ' : '';
}
This runs over each part of the exploded array and adds the desired string plus a comma if its not the last element.
You can also use array_walk to achieve the requested result:
$sample = 'Col1,Col2,Col3';
$parts = explode(',', $sample);
$str = '';
array_walk($parts, function ($element) use (&$str) {
$str .= 'FORMAT(SUM(' . $element . '), 2), ';
});
$result = rtrim($str, ', ');

Removing last comma in the foreach query in php mysql

Im using a foreach loop to echo out some values from my database and seperating each of them by commas but last comma how we can remove
echo $string='"paymentmethods":';
echo $string='"Bank":[';
$sql2 = "SELECT * FROM paymentmethods where cid=587 ";
$query = $this->db->query($sql2);
foreach ($query->result() as $row){
echo '{';
echo $string = 'accname:'.$row->acc.',' ;
echo $string = 'country:'.$row->IBAN.',' ;
echo $string = 'Iban:'.$row->Bankname.',' ;
echo $string = 'Bankname:'.$row->Bankname.',' ;
echo $string = '},';
}
echo $string = '],';
"paymentmethods":"Bank":[{accname:0034430430012,country:AE690240002520511717801,Iban:ARABIC BANK NAME,Bankname:ARABIC BANK NAME,},{accname:0506796049,country:DE690240002520511717801,Iban:ARABIC BANK NAME,Bankname:ARABIC BANK NAME,},]
Here see the comma is repeating after the name ends. and also after the end of brackets
The comma is there because you have written it in your code. Change the lines to this :
// same as above
echo $string = 'Bankname:'.$row->Bankname. ;
echo $string = '}';
}
echo $string = ']';
a common way to do this is to do this way :
$sep = '';
$result = '';
foreach($myarray as $value) {
$result .= $sep.$value;
$sep = ',';
}
this way, you don't have a beginning or ending comma.
But as comments say, you are doing a "json_encode" by yourself... you should use json_encode / decode instead.

How to remove "," in foreach()?

I have a code php
foreach ($cities as $city) {
echo substr($city->name . ", ", 0, -2);
}
result is: a, b, c, d, e,
How to remove "," in foreach()
Exactly: a, b, c, d, e
You could achieve the same with less code, by using the implode function.
$comma_separated = implode(',', $cities);
Should give you exactly what you want.
$str = '';
foreach ($cities as $city){
$str .= "$city, ";
}
$str = rtrim($str, " ,");
In this context you can not remove the last comma without additional tags.
You have two other options:
1. Use the standard for loop:
for ($i=0; $i < count($cities)-1; $i++) {
echo $cities[$i]->name . ", ";
}
echo $cities(count($cities)-1)->name;
2. Create a result string in the foreach, remove the last character and than print it.
Just do :-
echo implode(',', $cites);
That will give you your desired output.
I just noticed from your code that $cities is an object not an array, sorry:-
foreach($cities as $city){
$cityNames[] = $city->name;
}
echo implode(',', $cityNames);
http://www.php.net/implode
$first = true;
foreach ($cities as $city) {
if( !$first ){
echo ', ';
}else{
$first = false;
}
echo $city->name;
}
Change it a bit to something like:
$first = TRUE;
foreach ( $cities as $city )
{
if ( !$first )
{
echo( "," );
}
$first = FALSE;
echo( $city->name );
}
Use rtrim after the foreach():
$city->name = rtrim($city->name,',');
Method 1 :
$index = 0;
foreach ($cities as $city) {
$index++;
echo $city->name . ($index == count($cities)?"":",");
}
Method 2:
$str = "";
foreach ($cities as $city) {
$str .= $city->name . ",";
}
$str = substr_replace($str ,"",-1);
echo $str;

Create a comma-separated string from a single column of an array of objects

I'm using a foreach loop to echo out some values from my database, I need to strip the last comma from the last loop if that makes sense.
My loop is just simple, as below
foreach($results as $result){
echo $result->name.',';
}
Which echos out
result,result,result,result,
I just need to kill that pesky last comma.
Better:
$resultstr = array();
foreach ($results as $result) {
$resultstr[] = $result->name;
}
echo implode(",",$resultstr);
1. Concat to string but add | before
$s = '';
foreach ($results as $result) {
if ($s) $s .= '|';
$s .= $result->name;
}
echo $s;
2. Echo | only if not last item
$s = '';
$n = count($results);
foreach ($results as $i => $result) {
$s .= $result->name;
if (($i+1) != $n) $s .= '|';
}
echo $s;
3. Load to array and then implode
$s = array();
foreach ($results as $result) {
$s[] = $result->name;
}
echo implode('|', $s);
4. Concat to string then cut last | (or rtrim it)
$s = '';
foreach ($results as $result) {
$s .= $result->name . '|';
}
echo substr($s, 0, -1); # or # echo rtrim($s, '|');
5. Concat string using array_map()
echo implode('|', array_map(function($result) { return $result->name; }, $results));
$result_names = '';
foreach($results as $result){
$result_names .= $result->name.',';
}
echo rtrim($result_names, ',');
I've been having the same issue with this similar problem recently. I fixed it by using an increment variable $i, initializing it to 0, then having it increment inside the foreach loop. Within that loop place an if, else, with the echo statement including a comma if the $i counter is less than the sizeof() operator of your array/variable.
I don't know if this would fix your issue per se, but it helped me with mine. I realize this question is years-old, but hopefully this will help someone else. I'm fairly new to PHP so I didn't quite understand a lot of the Answers that were given before me, though they were quite insightful, particularly the implode one.
$i=0;
foreach ($results as $result) {
$i++;
if(sizeof($results) > $i) {
echo $result . ", ";
} else {
echo $result;
}
}
In modern PHP, array_column() will allow you to isolate a column of data within an array of objects.
Code: (Demo)
$results = [
(object)['name' => 'A'],
(object)['name' => 'B'],
(object)['name' => 'C']
];
echo implode(',', array_column($results, 'name'));
Output:
A,B,C
That said, since you are iterating a result set, then you may be better served by calling a CONCAT() function in your sql, so that the values are already joined in the single value result set.
If you are processing a collection in Laravel, you can pluck() and implode():
$collection->pluck('name')->implode(',')
$arraySize = count($results);
for($i=0; $i<$arraySize; $i++)
{
$comma = ($i<$arraySize) ? ", " : "";
echo $results[$i]->name.$comma;
}
Not as pretty, but also works:
$first=true;
foreach($results as $result){
if(!$first) { echo ', '; }
$first=false;
echo $result->name;
}
Another smart way is:
foreach($results as $result){
echo ($passed ? ',' : '') . $result->name;
$passed = true;
}
In this case at first loop $passed is NULL and , doesn't print.
I know this is an old thread, but this came up recently and I thought I'd share my alternate, cleaner way of dealing with it, using next().
$array = array("A thing", "A whatsit", "eighty flange oscillators");
foreach( $array as $value ){
echo $value;
$nxt = next($array);
if($nxt) echo ", "; // commas between each item in the list
else echo ". And that's it."; // no comma after the last item.
}
// outputs:
// A thing, A whatsit, eighty flange oscillators. And that's it.
play with it here
I have to do this alot because I'm always trying to feed numbers in to jplot, I find its easier to put the comma in the front of the loop like so:
foreach($arrayitem as $k){ $string = $string.",".$k;
}
and then chop off the first character (the comma) using substr, it helps if you know a guestimate of long your string will be, I'm not sure what the limit on substr max character is.
echo substr($a,1,10000000);
hope this helps.
$a[0] = 'John Doe';
$a[1] = 'Jason statham';
$a[2] = 'Thomas Anderson';
$size = count($a);
foreach($a as $key=>$name){
$result .= $name;
if($size > $key+1) $result .=', ';
}
echo $result;
<?php
$return = array(any array)
$len = count($return);
$str = '';
$i = 1;
foreach($return as $key=>$value)
{
$str .= '<a href='.$value['cat_url'].'>'.$value['cat_title'].'</a>';
if($len > $i)
{
$str .= ',';
$i = $i+1;
}
}
echo $str;
?>
<?php
$i = 1;
$count = count( $results );
foreach( $results as $result ) {
echo $result->name;
if ( $i < $count ) echo ", ";
++$i;
}
?>
This is what I normally do, add a comma before the item rather than after, while ignoring the first loop.
$i = 0;
$string = '';
foreach($array as $item){
$string .= ($i++ ? ',' : '').$item;
}
First get all the output by using output buffering. Then, trim the comma and display it. So, do it like this:
ob_start();
foreach($results as $result)
{
echo $result->name.',';
}
$output = ob_get_clean();
echo rtrim($output, ',');
The output buffering method helps if the inside loop is very big (and OP is posting here just for brevity), then using OB is easier without changing the internals of the loop.

Categories