php Undefined index when I dont use a redundant if statement - php

Question

I have a multidimensional array that I want to access and change one of the values from an integer to a string using a helper function. The code below works but if I remove the if statement which I dont really need it gives me a Undefined index error on the helper code
$stories = multidimensional array in this format
array(1) {
[0]=> array(4)
{
["code"]=> string(1) "2"
["user_name"]=> string(4) "Dave"
["name"]=> string(11) "project one"
["sample_id"]=> string(1) "2"
}
}
to access the array I am using
foreach($stories as $key => $subarray) {
if(array_key_exists('code', $subarray)){
//if($stories[$key]['code'] > 0){
$stories[$key]['code'] = task_priority_text($stories[$key]['code']);
//};
}
}
Commenting the code in this way throws the error while uncommenting gives a clean result.
Here is the helper function which I have used elsewhere and works well
if ( ! function_exists('task_priority_text'))
{
function task_priority_text($priority = FALSE)
{
$options = array('0' => 'Urgent', '1' => 'High', '2' => 'Medium', '3' => 'Low', '4' => 'Minimal');
if($priority !== FALSE)
return $options[$priority];
else
return $options;
}
}
How do I get ride of this if statement?
EDIT
here is the error
A PHP Error was encountered
Severity: Notice
Message: Undefined index: Medium
Filename: helpers/tasks_helper.php
Line Number: 70
line 70 of the helper is
return $options[$priority];

Answer 1

You are looping over each item in the array multiple times. The 'outer' loop runs once for every item in the array, then the 'inner' loop (which someone else pointed out is redundant) runs again for every item in the $subarray variable.
foreach($stories as $key => $subarray) {
foreach($subarray as $subkey => $subsubarray) {
if(array_key_exists('code', $subarray)){
//if($stories[$key]['code'] > 0){
$stories[$key]['code'] = task_priority_text($stories[$key]['code']);
//};
}
}
}
This would be a better way of doing it:
foreach($stories as $story)
{
$story['code'] = task_priority_text($story['code']);
}