function is not showing the success echo on executing? - php

Question

I am assigning a loop to a function so it's working fine when not enrolled in a function but when it's enrolled in function so it's not showing the echo on success please as :
function questions_query() {
global $mysqli;
global $form_name;
$questions = $_POST['questions'];
for($i=0;$i<count($questions);$i++){
$i_query = $i+1;
$query_2 = mysqli_query($mysqli,"UPDATE forms SET question$i_query='$questions[$i]' WHERE form_name='$form_name'") or die(mysqli_connect_error());
}
}
if (questions_query()) {
echo "All Questions Are Done!";
}
So if you people can please take a look at my code that what is going wrong in there..so I will be thankful to you for that please..!

Answer 1

The function doesn't return anything. There's no return true; or return false; statement.
If it's not successful it never returns, it calls die(), which terminates the whole script. So there's no reason to use if() around the call, just do:
questions_query();
echo 'All Questions Are Done!';

Answer 2

Want to use return
function questions_query() {
global $mysqli;
global $form_name;
$questions = $_POST['questions'];
for($i=0;$i<count($questions);$i++)
{
$i_query = $i+1;
$query_2 = mysqli_query($mysqli,"UPDATE forms SET question$i_query='$questions[$i]' WHERE form_name='$form_name'") or die(mysqli_connect_error());
}
return true;
}
if (questions_query()) {
echo "All Questions Are Done!";
}
else {
//something happened
}

Answer 3

If you want to check MySQL query result, then you need to return error check.
function questions_query() {
global $mysqli;
global $form_name;
$questions = $_POST['questions'];
$has_errors = 0;
for($i=0;$i<count($questions);$i++)
{
$i_query = $i+1;
$query_2 = mysqli_query($mysqli,"...");
if (mysqli_errno($mysqli) > 0) {
$has_errors ++;
}
}
return $has_errors;
}
$errors = questions_query();
if ($errors == 0) {
echo "All Questions Are Done!";
} else {
echo "Errors in questions: $errors times!";
}