Split the data into three arrays based on the time - php

Question

I want to split the data array into three arrays - past, today, later - based on the time.
For today's array, only data with today's date and the time greater than today's time should be there.
Here's my code. There is no bug in it (as far as I know). I am getting the desired result, but I want to know if this code can be more optimized.
$current_date = date('Y-m-d');
$current_time = date('H:i:s');
foreach($data as $key => $value) {
if(date('Y-m-d', $value->meeting_scheduled_at) > $current_date) {
$calendar_data['later'][] = $value;
} elseif (date('Y-m-d', $value->meeting_scheduled_at) < $current_date
|| ( (date('Y-m-d', $value->meeting_scheduled_at) == $current_date)
&& (date('H:i:s', $value->meeting_scheduled_at) < $current_time) )
) {
$calendar_data['past'][] = $value;
} else {
$calendar_data['now'][] = $value;
}
}
$value->meeting_scheduled_at is in timestamp
EDIT: I am using this in a Laravel project.
So, if the meeting is scheduled at today's date, and time is evening 6 PM. It will come into today array till the 6 PM. After 6 PM, it goes into the past array. In short, nothing should be there in later array, unless and until it is next day.

Answer 1

I like to use the DateTime class for this kinda thing. It takes into account daylight savings etc and can be compared really easily.
$now = new DateTime();
$tomorrow = new DateTime();
$meetingDate = new DateTime();
$tomorrow->add(new DateInterval('P1D'))->setTime(0,0,0);
foreach ($data as $key => $value) {
$meetingDate->setTimestamp($value->meeting_scheduled_at);
// if $value->meeting_scheduled_at format YYYY-MM-DD then
// we'd create the $meetingDate object here like this
// $meetingDate = new DateTime($value->meeting_scheduled_at);
if ($meetingDate < $now) {
$calendar_data['past'][] = $value;
} else if ($meetingDate >= $tomorrow) {
$calendar_data['later'][] = $value;
} else {
$calendar_data['now'][] = $value;
}
}

Answer 2

date('Y-m-d', $value->meeting_scheduled_at) should be calculated only once before you use its result in the conditions.

Answer 3

Make it easier
$now = time();
// Midnight due to discussion with Kevin Nagurski in comments :)
$tommorow = strtotime('tomorrow');
foreach($data as $key => $value)
if ($value->meeting_scheduled_at) < $now) $calendar_data['past'][] = $value;
elseif ($value->meeting_scheduled_at) >= $tommorow) $calendar_data['later'][] = $value;
else $calendar_data['now'][] = $value;

Answer 4

You can use timestamp instead.
$now = time();
$today_limt = strtotime("today 6 PM");
foreach($data as $key => $value) {
$meeting_time = strtotime($value->meeting_scheduled_at);
if($meeting_time > $today_limit) {
$calendar_data['later'][] = $value;
} elseif($meeting_time < $now) {
$calendar_data['past'][] = $value;
} else {
$calendar_data['now'][] = $value;
}
}