Cant identify Error - php

Question

I have some code that is supposed to show certain things depending if a radio button is pressed.
When no is selected, it hides entries in a table with a status_id of 15.
When yes is selected, it shows entries in a table with a status_id of 15
if($_REQUEST['statusVal']=="") {
$condition1= " AND MO.status_id <>'15'";
}
if($_REQUEST['statusVal']=="archive") {
$condition1 =" ";
} if($_REQUEST['statusVal']=="all") {
$condition1= " AND MO.status_id <>'15'";
}
$mode = $_REQUEST['mode'];
$mode_toggle = $_REQUEST['mode_toggle'];
$sql="SELECT MO.ssrs_id,MO.member_id,MO.assr_user_id,MO.product_id,MO.component_id,MO.status_id,MO.summary,MO.priority,V.product_name,M.component,T.name,S.statusTitle,S.flag_id FROM ".ASSR_SSRS." MO,".PRODUCTS." V,".PROD_COMPONENTS." M,".ASSR_USER." T ,".ASSR_STATUS." S WHERE MO.product_id=V.product_id AND MO.assr_user_id=T.assr_user_id AND MO.component_id=M.component_id AND MO.status_id=S.status_id AND MO.member_id='$memberID' ORDER BY MO.lastupdate DESC".$condition1;
$row_count = getRowCount($sql);
$sql .= $GLOBALS[sql_page];
$result=mysql_query($sql) or die(mysql_error());
I get this error when it is shown on the web browser (using latest Chrome)
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND MO.status_id <>'15' LIMIT 0,10' at line 1
Please help me

Answer 1

This is your query
$sql="
SELECT
MO.ssrs_id,
MO.member_id,
MO.assr_user_id,
MO.product_id,
MO.component_id,
MO.status_id,
MO.summary,
MO.priority,
V.product_name,
M.component,
T.name,
S.statusTitle,
S.flag_id
FROM ".ASSR_SSRS." MO,".PRODUCTS." V,".PROD_COMPONENTS." M,".ASSR_USER." T ,".ASSR_STATUS." S
WHERE
MO.product_id=V.product_id
AND MO.assr_user_id=T.assr_user_id
AND MO.component_id=M.component_id
AND MO.status_id=S.status_id
AND MO.member_id='$memberID'
ORDER BY MO.lastupdate DESC".$condition1;
Here you are appending the dynamic condition at the end and this makes the query invalid when you have some conditions for $condition1 something as
order by MO.lastupdate DESC AND MO.status_id <>'15' and hence the syntax is wrong
It should be as
$sql="
SELECT
MO.ssrs_id,
MO.member_id,
MO.assr_user_id,
MO.product_id,
MO.component_id,
MO.status_id,
MO.summary,
MO.priority,
V.product_name,
M.component,
T.name,
S.statusTitle,
S.flag_id
FROM ".ASSR_SSRS." MO,".PRODUCTS." V,".PROD_COMPONENTS." M,".ASSR_USER." T ,".ASSR_STATUS." S
WHERE
MO.product_id=V.product_id
AND MO.assr_user_id=T.assr_user_id
AND MO.component_id=M.component_id
AND MO.status_id=S.status_id
AND MO.member_id='$memberID'
".$condition1."
ORDER BY MO.lastupdate DESC";

Answer 2

You are adding condition after ORDER BY clause, which is error.
Following is the corrected SQL:
$sql="SELECT MO.ssrs_id,MO.member_id,MO.assr_user_id,MO.product_id,MO.component_id,
MO.status_id,MO.summary,MO.priority,V.product_name,M.component,T.name,
S.statusTitle,S.flag_id FROM ".ASSR_SSRS." MO,".PRODUCTS."
V,".PROD_COMPONENTS." M,".ASSR_USER." T ,".ASSR_STATUS." S WHERE
MO.product_id=V.product_id AND MO.assr_user_id=T.assr_user_id AND
MO.component_id=M.component_id AND MO.status_id=S.status_id AND
MO.member_id='$memberID' " . $condition1 . "ORDER BY MO.lastupdate DESC";