duplicate rows from foreach using php - php

Question

i have output from query
object(stdClass)#14 (6) {
["aid"]=>
string(2) "11"
["bid"]=>
string(2) "34"
["colorname"]=>
string(6) "Silver"
["colorgroupname"]=>
string(15) "LIGHT AQUA OPAL"
["colorcode"]=>
string(3) "6M8"
["brand"]=>
string(6) "Car"
}
but after loop in foreach
complite code what i use and i use var_dump to display output i get one rows but after loop i get 6 duplicate rows.
function ViewDBGridColorfinder($header,$DBG_control,$parameters)
{
$rows = $this->select_join_by(index_join_ColorFinder,TBL_COLOR,tbl_join_ColorFinder,where_by,order_by_dbgrid,$parameters);
$table = new Generator_Table($header);
//var_dump($rows);
if (is_array($rows) || is_object($rows))
{
foreach($rows as $val)
{
$DetailColor = ''.$rows->colorname.'';
$table->addCell($DetailColor);
$table->addCell($rows->colorcode);
$table->addCell($rows->brand);
$table->addCell($rows->colorgroupname);
$table->addCell(str_replace('onclick=""',"onclick=DelRow(".$rows->aid.")",$DBG_control));
}
}
$DBGrid_data = $table->generate();
return $DBGrid_data;
}
the result to be duplicate.
where is the error?

Answer 1

I think this sholud only do for you
$DetailColor = ''.$rows->colorname.'';
$table->addCell($DetailColor);
$table->addCell($rows->colorcode);
$table->addCell($rows->brand);
$table->addCell($rows->colorgroupname);
$table->addCell(str_replace('onclick=""',"onclick=DelRow(".$rows->aid.")",$DBG_control));
Remove foreach as.

Answer 2

Replace all $rows with $val in foreach loop

Answer 3

You used the variable $rows itself instead of $val. Update the code like this:
foreach($rows as $val)
{
$DetailColor = ''.$val->colorname.'';
$table->addCell($DetailColor);
$table->addCell($val->colorcode);
$table->addCell($val->brand);
$table->addCell($val->colorgroupname);
$table->addCell(str_replace('onclick=""',"onclick=DelRow(".$val->aid.")",$DBG_control));
}

Answer 4

Your $row is an object. So you don't really need to forloop inside the object. The reason why your getting 6 records is because there are six elements inside your object.
Count this and see, There are 6 elements(aid,bid,colorname,colorgroupname,colorcode,brand):
object(stdClass)#14 (6) {
["aid"]=>
string(2) "11"
["bid"]=>
string(2) "34"
["colorname"]=>
string(6) "Silver"
["colorgroupname"]=>
string(15) "LIGHT AQUA OPAL"
["colorcode"]=>
string(3) "6M8"
["brand"]=>
string(6) "Car"
}
So for each element, it will add the cell.In PHP you can use the -> to access the elements inside the object. Modify the code this way:
if (is_array($rows) || is_object($rows))
{
$DetailColor = ''.$rows->colorname.'';
$table->addCell($DetailColor);
$table->addCell($rows->colorcode);
$table->addCell($rows->brand);
$table->addCell($rows->colorgroupname);
$table->addCell(str_replace('onclick=""',"onclick=DelRow(".$rows->aid.")",$DBG_control));
}