If the array has more then 10 elements ... then what? - php

Question

I have a top 10 list right here. The list contains all the IPs who visited the domain (out of my log files) and my code below gives me the top 10 IPs of them.
But I want it more dynamically. Like if there are more then 10 different IPs, give me just the 10 IPs that appear the most. If the amount of different IPs is less then 10, just give me all the IPs there are.
The code for this:
$all_ips = array_count_values($ip_array);
arsort($all_ips);
$count = count($all_ips);
$keys = array_keys($all_ips);
$topTenIp = array();
$count = $count -1;
for($i=0; $i <= $count; $i++){
if($count < 9){
$topTenIp[] = $keys[$i];
}else{
$topTenIp[] = $keys[$i];
}
}
This works okay but not perfect. If the amount of IPs is below 10, it gives me all the IPs there are. But if there are more then 10, it doesn't give me the 10 most appearing IPs, it just gives me all IPs of the log script.
I hope you understood what I was trying to say. I'm from Germany, so my English isn't that good.
Thanks anyway :)

Answer 1

I don't really see how this is related to Laravel at all, but anyway:
$counted = array_count_values($ipArray);
arsort($counted);
$top = array_keys(array_slice($counted, 0, 10));
Would be a faster, simpler way to get top 10 items, given that your source $ipArray is a simple array of IP addresses.

Answer 2

What you're doing isn't logical. Say $all_ips is 30 then every 30 iterations will execute in the else. Resulting in a array of 30 ip's.
You'll need to change your if and else part.
for($i=0; $i <= $count; $i++){
if($i < 9){
$topTenIp[] = $keys[$i];
} else {
break; //Break out of the loop
}
}

Answer 3

This is because you are doing same code in if and else condition.
You can do like this:
for($i=0; $i <= $count; $i++){
if($i < 9){
$topTenIp[] = $keys[$i];
}
}

Answer 4

please try the following
$all_ips = array_count_values($ip_array);
arsort($all_ips);
$count = count($all_ips);
$keys = array_keys($all_ips);
$topTenIp = array();
$count = $count -1;
for($i=0; $i <= $count; $i++){
if($count < 9){
$topTenIp[] = $keys[$i];
}else{
$topTenIp[] = $keys[$i];
}
if( $i >= 9 )
{
break;
}
}
in your code there is no check given if number count is grater than 10 , so please give a check , i have updated my answer