need advise on if-else statement using php - php

Question

I'm trying to add selected in option when condition true. Its working fine, but its giving two times selected.
foreach ($sorts as $sorts) {
if ($cat_id == 59 && $sorts['value'] == 'p.price-ASC') { // True if category id equal to 59
<option value="<?php echo $sorts['href']; ?>" selected="selected"><?php echo $sorts['text']; ?></option>
}else{
if ($sorts['value'] == $sort . '-' . $order) { // True if values are equal
<option value="<?php echo $sorts['href']; ?>" selected="selected"><?php echo $sorts['text']; ?></option>
}else {
<option value="<?php echo $sorts['href']; ?>"><?php echo $sorts['text']; ?></option>
}
}
}
In above you can see there are two conditions for selected.
True if category id equal to 59 if ($cat_id == 59 &&
$sorts['value'] == 'p.price-ASC')
True if values are equal if ($sorts['value'] == $sort . '-' .
$order)
On other category pages it totally working fine, but on category 59 two if statements are giving true. That's why on this page two selected are adding on two option.
<option value="name-az" >Name (A - Z)</option>
<option value="name-az" selected="selected">Name (Z - A)</option>
<option value="p.price-ASC" selected="selected">Price (Low > High)</option>
So can any one guide me how to fix or modify the condition that i can get only one true condition in one time. Thanks

Answer 1

You could solve it by using a new variable $done indicating that the selected value was added already:
$done = false;
foreach ($sorts as $sorts) {
if (!$done && $cat_id == 59 && $sorts['value'] == 'p.price-ASC') { // True if category id equal to 59
<option value="<?php echo $sorts['href']; ?>" selected="selected"><?php echo $sorts['text']; ?></option>
$done = true;
}else{
if (!$done && $sorts['value'] == $sort . '-' . $order) { // True if values are equal
<option value="<?php echo $sorts['href']; ?>" selected="selected"><?php echo $sorts['text']; ?></option>
$done = true;
}else {
<option value="<?php echo $sorts['href']; ?>"><?php echo $sorts['text']; ?></option>
}
}
}
Problem with the above and your code is that the foreach is incorrect. $sorts as $sorts is not possible for the foreach. I've refactored your code to more safe and better usable code. This code is also tested and works as expected:
//INPUT:
$sort = 'name';
$order = 'za';
$cat_id = 59;
$sorts = array(
'name-az' => 'Name (A - Z)',
'name-za' => 'Name (Z - A)',
'p.price-ASC' => 'Price (Low > High)',
'p.price-DESC' => 'Price (High > Low)'
);
//CODE:
if(!array_key_exists($sort . '-' . $order, $sorts)) //check your input!
throw new Exception('Invalid sort order.');
$selected = $cat_id == 59 ? 'p.price-ASC' : $sort . '-' . $order;
$done = false;
echo '<select>';
foreach ($sorts as $key => $value) {
echo '<option value="'.htmlentities($key, ENT_QUOTES, 'UTF-8').'"'.($selected==$key?' selected="selected"':'').'>'.htmlentities($value, ENT_QUOTES, 'UTF-8').'</option>';
}
echo '</select>';

Answer 2

Why use 2 if statements? That's what elseif is for. Does this code work for you?
foreach($sorts as $sorts)
{
if($cat_id == 59 && $sorts['value'] == 'p.price-ASC')
{
<option value="<?php echo $sorts['href']; ?>" selected="selected"><?php echo $sorts['text']; ?></option>
continue;
}
elseif($sorts['value'] == $sort . '-' . $order)
{
<option value="<?php echo $sorts['href']; ?>" selected="selected"><?php echo $sorts['text']; ?></option>
continue;
}
else
{
<option value="<?php echo $sorts['href']; ?>"><?php echo $sorts['text']; ?></option>
}
}