Else If Not Work in PDO Script [closed] - php

Question

Closed. This question needs debugging details. It is not currently accepting answers.
Edit the question to include desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem. This will help others answer the question.
Closed 7 years ago.
Improve this question
I wanted to thwart POST if the number of characters entered is less than 6 use this code:
<?php
if(isset($_POST['button']))
{
$id = $_SESSION['user_session'];
$u_password = $_POST['password'];
if($crud->updatePassword($id,$u_password))
{
$msg = $msgsucces;
}
else if($u_password < 6) {
$msg = "<div class='alert alert-warning'><strong>Failed!!</strong> Minimum length 6 character</div>";
return false;
}
else
{
$msg = $msgfailled;
}
}
echo $msg ;
?>
But apparently it did not work. What is wrong?

Answer 1

You can use your conditions as like that:
$msg = "";
if(strlen($u_password) < 6) {
$msg = "<div class='alert alert-warning'><strong>Failed!!</strong> Minimum length 6 character</div>";
}
else{
if($crud->updatePassword($id,$u_password))
{
$msg = "success message";
}
else {
$msg = "failure message";
}
}
echo $msg;
For checking length of an input you can use strlen() function.
Side note:
Note that I have remove return false from ist condition.
Also suggest you to always add error_reporting() in your file this will help you to save your time. (Only for local environment not for production).

Answer 2

with $u_password <6 you are not really checking length.
You need strlen function to get the length and compare to 6 so we use strlen function
Rule of thumb is you should have wrong cases before the write one.
The last else is executed if $crud->updatePassword($id,$u_password) fails ie false.
if(strlen($u_password) < 6)
{
$msg = "<div class='alert alert-warning'><strong>Failed!!</strong> Minimum length 6 character</div>";
return false;
}
else if($crud->updatePassword($id,$u_password))
{
$msg = $msgsucces;
}
else {
$msg =$msgfailled;
}
}
echo $msg ;
?>