trying to get property of non-object - Laravel? - php

Question

I'm doing a blog to learn how to use laravel. The blog is mostly finished but I still found some mistakes in my code. Most of them are solved but there is still one error I can't fix.
It's about the 'my thread' of the user. If the user did a new account, he also get a 'my thread' page. If he's klicking on the page, he will get a view with all his threads. My problem now is, that if he don't have any threads, he will get a:
trying to get property of non-object exception. Of course I don't want him to see this.
So this is the function in my controller to his 'my thread' page:
public function startpage($id)
{
// $userthreads = Thread::query()->where('user_id', $id)->get();
// return $userthreads;
try {
return view('test.startpage', [
'userthreads' => Thread::query()->where('user_id', $id)->get(),
'user' => User::query()->findOrFail($id)
]);
} catch (ModelNotFoundException $e) {
return view('test.notfound');
}
}
with the first two ( uncommented ) lines, I checked if there was something in the array. I just got
'[]'
as an output. That means the array is empty. I returned the $userthreads variable to the view and on my view I did this to avoid the problem:
#if(empty($userthreads))
Add Thread
#else
#foreach($userthreads as $uthread)
<ul>
{{$uthread->thread}}
</ul>
#endforeach
#endif
This haven't worked for me and I can't see why. Maybe someone of you can help me there.
Thanks for any help!
Current code of Alexey Mezenin answers:
public function startpage($id)
{
try {
$arr = [];
$arr['userthreads'] = Thread::where('user_id', $id)->get();
$arr['user'] = User::findOrFail($id);
return view('test.startpage', $arr);
} catch (ModelNotFoundException $e) {
return view('test.notfound');
}
}
HTML:
#if(count($userthreads) > 0)
Thread hinzufügen
#else
#foreach($userthreads as $uthread)
<ul>
{{$uthread->thread}}
</ul>
#endforeach
#endif
Error :
Trying to get property of non-object (View: /var/www/laravel/logs/resources/views/test/startpage.blade.php)

Answer 1

Ok, we discussed it in chat and found a problem:
#if(Auth::user()->id == $userthreads->first()->user_id)

Answer 2

Error is in your startpage.blade.php here
#if( Auth::user()->id == $userthreads->first()->user_id)
And change it like below
#if( isset($userthreads) && count($userthreads) > 0 && Auth::user()->id == $userthreads->first()->user_id)
that's it
#if(isset($userthreads) && count($userthreads) > 0)
#foreach($userthreads as $uthread)
<ul>
{{$uthread->thread}}
</ul>
#endforeach
#else
Thread hinzufügen
#endif

Answer 3

#ItzMe488
I think replacing the following code :
#if( Auth::user()->id == $userthreads->first()->user_id)
with
#if( Auth::user()->id == $user->first()->user_id)
should work without any errors and bugs.
Explanation:
In our chat #AlexeyMezenin found out that the error is because $userthreads is empty and $userthreads->first() errors out because of that. I think since you are passing $user also into the template, using that we can authenticate for the current user and this should prevent user B from creating threads in User A's page.