PHP code just prints on screen instead of running [closed] - php

Question

Closed. This question is not reproducible or was caused by typos. It is not currently accepting answers.
This question was caused by a typo or a problem that can no longer be reproduced. While similar questions may be on-topic here, this one was resolved in a way less likely to help future readers.
Closed 6 years ago.
Improve this question
For some reason I can't connect to database. Here's my code:
<?php
//only process form if $_POST isnt empty
if ( ! empty( $_POST ) ) {
// Connect to MySQL
$mysqli = new mysqli( 'localhost', 'username', 'password', 'database' );
//Check connection
if ( $mysqli->connect_error ) {
die( 'Connect Error: ' . $mysqli->connect_errno . ': ' . $mysqli- >connect_error );
}
//Insert form data
$sql = "INSERT INTO user ( Name, Username, Password, Email ) VALUES
( '{mysqli->real_escape_string($_POST['Name'])}',
('{mysqli->real_escape_string($_POST['Lastname'])}',
('{mysqli->real_escape_string($_POST['Username'])}',
('{mysqli->real_escape_string($_POST['Password'])}' )
('{mysqli->real_escape_string($_POST['Email'])}' )";
//Print response from MySQL
if ( $insert ) {
echo "Success! Row ID: {$mysqli->insert_ID}";
}else{
die("Error: {$mysqli->errno} : {$mysqli->error}");
}
//Close our connection
$mysqli->close();
}
?>

Answer 1

Warning: your code is susceptible to SQL Injection!
Never use $_POST[] or any user submitted data directly in a SQL Insert.
Use Prepared Statements instead!
Regarding the code just prints on the screen:
If the PHP Code is printing on to the screen instead of being interpreted by the server; first make sure that the PHP file is using a valid PHP extension such as .php and not just .html
Also make sure that the php module is installed for your web server (this would be different instructions for IIS then for Apache).
Also your code is missing the actual query itself which is done using the following code:
$insert = $mysqli->query($sql) // do the insert
Then the rest of your code will start to function:
if ( $insert ) {
echo "Success! Row ID: {$mysqli->insert_ID}";
}else{
die("Error: {$mysqli->errno} : {$mysqli->error}");
}
$mysqli->close();
Without the $mysqli->query($sql) your hitting the else and die()
See query for more info.

Answer 2

The sql should be executed to return a result $insert
Example: $insert = $mysqli->query($sql)
(And, as mentioned it's much safer to use prepared statements.)

Answer 3

well, you wrote
if ( $insert ) {
echo "Success! Row ID: {$mysqli->insert_ID}";
That echoes exactly what is between the subsequent quotation marks (as a string)...

Answer 4

The script will keep hitting the die statement because $insert hasn't been set. So you are right: it just prints to the screen.
When you copied and pasted the code from "The Internet" you forgot one line - as Philip pointed out:
$insert = $mysqli->query($sql)
Without it, the only thing that your script would do is create a connection and close it again - or, most likely: not even managing to close it because it would die before it reached that line. :)
The line you forgot is supposed to be inserted just after the $sql string but before the conditional using $insert.