Simple if else statement not working as usual - php

Question

I got a simple if else statement where I show a list of pdf files, when the id is empty (aka there is no pdf file) I want to show: 'No available downloads'. But it shows that text no matter what, even if there are pdf files present.
My code:
<div class="widget broucher">
<h4>DOWNLOADS</h4>
<ul>
<?
//pdf bestanden
$pdf = "SELECT * FROM `snm_attachments` WHERE parent_id = '".$conn->real_escape_string($contentcr[0]['id'])."'";
$pdfcon = $conn->query($pdf);
$pdfcr = array();
while ($pdfcr[] = $pdfcon->fetch_array());
foreach($pdfcr as $pdf){
if($pdf['id'] != ''){
$downloads .= '<li><i class="fa fa-file-pdf-o"></i>'.$pdf['filename'].'</li>';
}else{
$downloads .= '<li>No available downloads</li>';
}
}
echo $downloads;
?>
</ul>
</div>
Why is it always showing, even when there is no id present for a row?

Answer 1

Use this code:
<?
//pdf bestanden
$pdf = "SELECT * FROM `snm_attachments` WHERE parent_id = '".$conn->real_escape_string($contentcr[0]['id'])."'";
$pdfcon = $conn->query($pdf);
// initialize downloads variable:
$downloads = '';
// see how while statement disappears (in your code you have the fetch_array attached to the first element of the array):
$pdfcr = $pdfcon->fetch_array();
foreach($pdfcr as $pdf){
if($pdf['id'] != ''){
$downloads .= '<li><i class="fa fa-file-pdf-o"></i>'.$pdf['filename'].'</li>';
}else{
$downloads .= '<li>No available downloads</li>';
}
}
echo $downloads;
?>
Note than the No available downloads message will be rendered in all iterations of the data array when id is different than empty. To show the message when there are no records use this code:
if(count($pdfcr) > 0) {
foreach($pdfcr as $pdf){
if($pdf['id'] != ''){
$downloads .= '<li><i class="fa fa-file-pdf-o"></i>'.$pdf['filename'].'</li>';
}
}
}