PHP postgresql: INSERT values from query array result - php

Question

I have some rows from this query statement:
SELECT * from jkd where idno='$id';
And I want to "copy" the values from those rows to other table:
INSERT INTO tmpjkd(pop, name, address) VALUES($pop, $name, $address);
I tried with this:
$jkd = SELECT * from jkd where idno='$id';
$sql = pg_query("SELECT * from jkd where idno='$id'");
while ($row = pg_fetch_object($sql)){
$pop = $jkd['pop'];
$name = $jkd['name'];
$address = $jkd['name'];
pg_query("INSERT INTO tmpjkd(pop, name, address) VALUES($pop, $name, $address)");}
But there's no luck. Please help me...
UPDATE:
I wrote in drupals:
$sql = db_query("SELECT * from jkd where idno='$id'");
while ($row = db_fetch_object($sql)){
$pop = $jkd['pop'];
$name = $jkd['name'];
$address = $jkd['name'];
db_query("INSERT INTO tmpjkd(pop, name, address) VALUES($pop, $name, $address)");}

Answer 1

Your code needs some changes
$sql = pg_query("SELECT * from jkd where idno=$id");
while ($row = pg_fetch_object($sql)) {
$pop = $row->pop;
$name = $row->name;
$address = $row->address;
pg_query("INSERT INTO tmpjkd(pop, name, address) VALUES ('$pop', '$name', '$address')");
}
pg_fetch_object is returning an object not an array, beside you you were using $jkd which doesn't do anything with actual values.
Also, the first line $jkd = SELECT * from jkd where idno='$id';, I don't know what it is used for, mostly you don't really need it.

Answer 2

The solution proposed above does N + 1 queries. This will lead to performance problems. Why not using a CTE for that ?
$query = <<<SQL
WITH
to_be_inserted AS (SELECT pop, name, address FROM jkd WHERE idno = $1)
INSERT INTO tmpjkd (pop, name, address)
SELECT pop, name, address FROM to_be_inserted;
SQL;
pg_query_params($sql, [$id]);
Furthermore, this makes an atomic transaction.