laravel router argument behaviour - php

I notice that when you use URL:::action, and set some arguments, sometimes laravel would cast them as GET requests, sometimes not.
Is there anyone know why and how to controller it?
echo URL::action('Campaign\\CampaignController#getIndex',['para' => 1]),"<br>";
echo URL::action('Campaign\\CampaignController#getOtherAction',['para' => 1]),"<br>";
echo URL::action('Campaign\\CampaignController#getOtherAction2',['para' => 1]),"<br>";
Output:
/campaign?para=1
/campaign/other-action/1
/campaign/other-action2/1
Note the getIndex gets argument as GET (?para=1)

This happens because system cannot differentiate requests to getIndex from others if they pass it as url segment.
Means
/campaign/other-action/1 translates to other-action as a method with 1 as param
By your expectation
/campaign/other-action/1 translates to getIndex as a method with other-action/1 as param
Index methods are not suppose to have URL segments as inputs. If you need url segments as inputs then you will have to pass it as a get parameter and thats what laravel is doing for you.
According to your first route output,
if the url is /campaign/1 which means it will expect a method named get1. Another example: if the url is /campaign/param system would expect a method getParam
NOTE for fellow stackoverflow-ers:Consider asking questions before downvoting

I actually found the reason.
when you are using route::controllers method, laravel would assume you have multiple parameters attached to each action
Route::controllers([
'order' => 'Order\OrderController',
'campaign' => 'Campaign\CampaignController'
]);
For example:
campaign/other-action/{VALUE1?}/{VALUE2?}/{VALUE3?}...
So when you pass ['para' => 1, 'para2' => 'abc'], laravel will try to match parameters to action. in this case: campaign/other-action/1/abc
Avoiding to use Route::controllers, an help you take control on laravel router argument behaviour.
For example, in routes.php:
Route::get('campaign/other-action/{id}','Campaign\CampaignController#getOtherAction2')
when you give
echo URL::action('Campaign\\CampaignController#getOtherAction2',['id'=>366, 'para' => 1, 'para2' => 'abc']);
you will get what you want:
campaign/other-action/366?para=1&para2=abc
I hope it is helpful and I now understand why laravel remove Route::controllers from 5.3 version.

Related

Laravel exclude route

I have this in my web.php (Laravel 5.3)
Route::get('/{perfil}/{seccion}', 'HotelsController#index')->where(['perfil' => '(perfil|profile)'])->where(['seccion' => '(mis-hoteles|my-properties)']);
Route::get('/{perfil}/{seccion}', 'PerfilController#index')->where(['perfil' => '(perfil|profile)']);
I want the urls /perfil/mis-hoteles and /profile/my-properties to be served by the first route. And the urls /perfil/[whatever] and /profile/[whatever] to be served by the second route.
It does not work, /perfil/mis-hoteles is redirected by the second route.
I'd also tried something like
Route::get('/{perfil}/{seccion}', 'PerfilController#index')->where(['perfil' => '(perfil|profile)','seccion' => '^(!mis\-hoteles$)'])
for the second route, but it does not work .
What am I doing wrong?
The weird thing is, if I delete the second route and leave only
Route::get('/{perfil}/{seccion}', 'HotelsController#index')->where(['perfil' => '(perfil|profile)'])->where(['seccion' => '(mis-hoteles|my-properties)']);
it works, so there is a match. Why if there is a match laravel continues looking for a match finding the second route?
Laravel does not like it when your routes have the same method and uri sring. If you have two routes with same methods and uri strings (not the actual uris they WILL receive) which you do, it just overrides it.
So we need to "trick" it a bit.
Instead of this:
Route::get('/{perfil}/{seccion}', 'HotelsController#index')->where(['perfil' => '(perfil|profile)'])->where(['seccion' => '(mis-hoteles|my-properties)']);
Route::get('/{perfil}/{seccion}', 'PerfilController#index')->where(['perfil' => '(perfil|profile)']);
We are going to "lie" and say:
Route::get('/{perfil}/{seccion}', 'HotelsController#index')->where(['perfil' => '(perfil|profile)'])->where(['seccion' => '(mis-hoteles|my-properties)']);
Route::get('/{perfil}/{section}', 'PerfilController#index')->where(['perfil' => '(perfil|profile)']);
Notice the {perfil}/{seccion} and {perfil}/{section} just this one letter will tell Laravel that we don't want to override the old route.
Don't forget to change the accepted parameter in the Controllers respectively.
Hope this solves your problem, it did for me.

Inconsistent behaviour for action() in Laravel

I do not know how to use this in order to always have GET parameters
Route is setup like
Route::controller('/test', TestController::class);
If I specify the getIndex function, it adds GET parameters
>>> action('TestController#getIndex', ['type' => '123'])
=> "http://localhost/test?type=123"
But if I specify anything but the getIndex function it does not add the parameters as GET variables
>>> action('TestController#getSuccess', ['type' => '123'])
=> "http://localhost/test/success/123"
Take a look at the output of php artisan routes --path=/test
Some of the routes (like the one mapped to getSuccess) have parameters and Laravel attempts to match the given parameter array to the route parameters.
Once all the query parameters are accounted for, any excess elements are converted into a query string and appended to the final URL.

Yii & Yii2: how to configure routing on a single method with a variable number of arguments?

I decided to move the logic with YII on Yii2 and a problem with the routing entry.
//yii1
'image/<id:\d+>*' => array('image/get'),
But it doesn't work on YII2
//yii2
'image/<id:\d+>*' => 'image/get',
How to write the route to get function takes a variable number of arguments?
Try
'image' => 'image/get',
And in the ImageController get the params the normal way
$id = \Yii::$app->request->post('id');
I have defined
'my-account' => 'my-account/index',
The link /my-account?id=5&foo=bar works just fine.

Laravel using named routes

Regarding the use of named routes, these 2 lines allow me to access the same page so which is correct?
// Named route
Route::get('test/apples', array('as'=>'apples', 'uses'=>'TestController#getApples'));
// Much simpler
Route::get('apples', 'TestController#getApples');
Is there any reason I should be using named routes if the latter is shorter and less prone to errors?
Named routes are better, Why ?
It's always better to use a named route because insstsead of using the url you may use the name to refer the route, for example:
return Redirect::to('an/url');
Now above code will work but if you would use this:
return Redirect::route('routename');
Then it'll generate the url on the fly so, if you even change the url your code won't be broken. For example, check your route:
Route::get('apples', 'TestController#getApples');
Route::get('apples', array('as' => 'apples.show', 'uses' => 'TestController#getApples'));
Both routes are same but one without name so to use the route without name you have to depend on the url, for example:
return Redirect::to('apples');
But same thing you may do using the route name if your route contains a name, for example:
return Redirect::route('apples.show');
In this case, you may change the url from apples to somethingelse but still your Redirect will work without changing the code.
The only advantage is it is easier to link to, and you can change the URL without going through and changing all of its references. For example, with named routes you can do stuff like this:
URL::route('apples');
Redirect::route('apples');
Form::open(array('route' => 'apples'));
Then, if you update your route, all of your URLs will be updated:
// from
Route::get('test/apples', array('as'=>'apples', 'uses'=>'TestController#getApples'));
// to
Route::get('new/apples', array('as'=>'apples', 'uses'=>'TestController#getApples'));
Another benefit is logically creating a URL with a lot parameters. This allows you to be a lot more dynamic with your URL generation, so something like:
Route::get('search/{category}/{query}', array(
'as' => 'search',
'uses' => 'SearchController#find',
));
$parameters = array(
'category' => 'articles',
'query' => 'apples',
);
echo URL::route('search', $parameters);
// http://domain.com/search/articles/apples
The only reason to name the route is if you need to reference it later. IE: from your page in a view or something, check whether you are in that route.

Getting parameter from url in Zend

My route setup :
Zend_Controller_Front::getInstance()
->getRouter()
->addRoute('view', new Zend_Controller_Router_Route('controller/action/:name'))
My link in view :
$this->url(array("name" => "John"), "view", TRUE);
// returns "controller/action/John" as should
Now, when I am at controller/action/John, how do I get the name from URL ? I tried
$this->getRequest()->getParam("name");
but the name param isn't there - getRequest() returns only controller, action and module params.
When you set up your route configuration the route definition should either directly match the controller/action names or be set with defaults. Actually setting the defaults in any case is just good practice and helps you avoid issues like this.
So, in your case according to the comments your route should probably look like this.
$defaults = array(
'controller'=> 'offers',
'action' => 'view',
'name' => ''
);
$route = new Zend_Controller_Router_Route('offers/view/:name',$defaults);
As mentioned in the comments you can always check what route has been used with Zend_Controller_Front::getInstance()->getRouter()->getCurrentRouteName(). If it doesn't show your expected route the Router isn't able to find a match and moves on until it usually ends in the "default" route.
As a side note to your question: When you use $this->url(array("name" => "John"), "view", TRUE) you only create the link based on the route. This method is only part of the view and does nothing in terms of dispatching to a controller or action.
For those who found this question and for future reference, you can get params from route using this : $this->params()->fromRoute('param1', 0); in Zend Framework 2 at least. This is what I was looking for in this question.

Categories