Symfony preSubmit form event changes not retained in controller/persist - php

Question

I'm having to make changes to collections (Symfony form CollectionType) to respect ordering and entity removal and I'm using a preSubmit event listener to make the changes as per this issue suggestion. However the changes aren't making it back to the controller/persistence.
The data is correct after the preSubmit and being set on the event using $event->setData($data) but the changes are not retained after submitting in $form->getData()
My pre submit abstract class:
abstract class AbstractEntityFormType extends AbstractType
{
/**
* #param FormBuilderInterface $builder
* #param array $options
*/
public function buildForm(FormBuilderInterface $builder, array $options)
{
$builder->addEventListener(FormEvents::PRE_SUBMIT, [$this, 'onPreSubmit']);
}
/**
* #param FormEvent $event
*/
public function onPreSubmit(FormEvent $event)
{
$form = $event->getForm();
$data = $event->getData();
$document = $form->getData();
foreach ($form->all() as $field) {
/** #var FormInterface $field */
$fieldName = $field->getName();
if ($field->getConfig()->getType()->getInnerType() instanceof CollectionType) {
// .. DO ALL TRANSFORMATION
}
}
$event->setData($data);
}
}
When I dump $data here, everything is correct.
FormType extending this AbstractEntityFormType class:
class DocumentType extends AbstractEntityFormType
{
/**
* #param FormBuilderInterface $builder
* #param array $options
* #return void
*/
public function buildForm(FormBuilderInterface $builder, array $options)
{
/** ADD THE LISTENER **/
parent::buildForm($builder, $options);
$builder->add('title', TextType::class, [
'required' => true,
'constraints' => [
new NotBlank([
'message' => '"title" is empty',
]),
],
]);
$builder->add('symptoms', CollectionType::class, [
'entry_type' => SymptomType::class,
'allow_add' => true,
'allow_delete' => true,
'by_reference' => false,
]);
$builder->add('tags', CollectionType::class, [
'entry_type' => TagType::class,
'allow_add' => true,
'allow_delete' => true,
'by_reference' => false,
]);
$builder->add('submit', SubmitType::class);
}
/**
* #param OptionsResolver $resolver
* #return void
*/
public function configureOptions(OptionsResolver $resolver)
{
$resolver->setDefaults([
'data_class' => Document::class,
]);
}
}
My controller action:
/**
* #param Request $request
* #param int|null $documentId
* #return Response
*/
public function formAction(Request $request, int $documentId = null)
{
if (!$documentId) {
$document = new Document();
} else {
try {
$document = $this->documentService->getDocument($documentId);
} catch (InvalidDocumentException $e) {
return new NotFoundResponse('Document not found');
}
}
$document = $this->setAuthor($document);
$form = $this->formFactory->create(DocumentType::class, $document);
$form->handleRequest($request);
if ($form->isSubmitted() && $form->isValid()) {
$document = $this->documentService->createDocument($form->getData());
return new RedirectResponse($this->router->generate('ui.document.view', [
'documentId' => $document->getId()
]));
}
return $this->templating->renderResponse(
'#KBS/Document/form.html.twig', [
'form' => $form->createView(),
]
);
}
When I dump $form->getData() before persisting the document with the service, the data is incorrect - it hasn't been affected by the preSubmit. What am I missing?
FYI, this is using Symfony 3.2 base components.
Update
Thanks to #LBT, I'm a bit closer but still facing some issues. Using this approach in the controller, I am able to get the correct data out of the request at the point of submitting the form:
public function formAction(Request $request, int $documentId = null)
{
if (!$documentId) {
$document = new Document();
} else {
try {
$document = $this->documentService->getDocument($documentId);
} catch (InvalidDocumentException $e) {
return new NotFoundResponse('Document not found');
}
}
$document = $this->setAuthor($document);
$form = $this->formFactory->create(DocumentType::class, $document);
if ($request->isMethod('POST')) {
$form->submit($request->request->get($form->getName()));
if ($form->isSubmitted() && $form->isValid()) {
$document = $this->documentService->createDocument($form->getData());
return new RedirectResponse($this->router->generate('ui.document.view', [
'documentId' => $document->getId()
]));
}
}
return $this->templating->renderResponse(
'#KBS/Document/form.html.twig', [
'form' => $form->createView(),
]
);
}
However, $form->submit($request->request->get($form->getName())); is also saving incorrect (original) data before being transformed. Even though the data in the request is correct:
/var/www/html/src/Controller/DocumentController.php:94:
array (size=8)
'title' => string 'Tag test' (length=8)
'symptoms' =>
array (size=1)
0 =>
array (size=3)
'position' => string '0' (length=1)
'title' => string 'The smell is terrible' (length=21)
'description' => string 'pew' (length=3)
'tags' =>
array (size=4)
0 =>
array (size=1)
'title' => string 'Volvo' (length=5)
1 =>
array (size=1)
'title' => string 'Engine' (length=6)
2 =>
array (size=1)
'title' => string 'BMW' (length=3)
3 =>
array (size=1)
'title' => string 'Funky' (length=5)
Feel like I'm getting closer but I don't seem to be able to use this request data as suggested in the documentation for some reason.