What's mistake I am doing with this ternary operator? [duplicate] - php

Question

This question already has answers here:
Stacking Multiple Ternary Operators in PHP
(11 answers)
Closed 5 years ago.
function get_status($data) {
return ($data->cm_status == 'Y') ? 'Active' :
($data->cm_status == 'N') ? 'Inactive' : '-';
}
I should get Active if $data->cm_status is Y
I should get Inactive if $data->cm_status is N
I should get - if $data->cm_status is anything else
But actually in all case I am getting Inactive
What is the mistake I am doing?
references to your answers appreciated

Answer 1

You need to wrap the inner ternary operator in brackets for the results to be produced correctly, like this
function get_status($data) {
return $data->cm_status == 'Y' ? 'Active' :
($data->cm_status == 'N' ? 'Inactive' : '-');
}
A more readable approach could be to use a switch instead, using nested ternary operators could easily confuse and cause more chaos than it solves. A switch would look like this
function get_status($data) {
switch ($data->cm_status) {
case "Y":
return 'Active';
case "N":
return 'Inactive';
default:
return '-';
}
}
This also assumes that the input would always be upper-case, you could add additional code to compare regardless if its upper or lowercase.

Answer 2

In case of nested ternary operator the composite one should be inside a couple of brackets. So try this;
function get_status($data) {
return ($data->cm_status == 'Y') ? 'Active' :(($data->cm_status == 'N') ? 'Inactive' : '-')
}
Notice the "()" in second ternary conditional operator.

Answer 3

Use this:
function get_status($data) {
return ($data->cm_status == 'Y') ? 'Active' :
(($data->cm_status == 'N') ? 'Inactive' : '-');
}