Matching node id with mysql table id - php

Question

I have to make function where I can get node id from url (example: localhost/site/node-1)and make link to mysql databes row where is (example: id=1) and i need to do it dynamically with several nodes.. I try this code:
<?php
function module_name_menu() {
$items['node-%'] = array(
'title' => 'Row from database',
'page callback' => 'module_name_node_page_view',
'access callback' => 'node_access',
);
return $items;
}
function module_name_node_page_view(){
$id = $_GET['id'];
$results=db_query("SELECT * FROM csvupload WHERE id = $id");
$header = array ( t('First name'), t('Last name'), t('Email'));
$rows = array();
foreach($results as $result){
$rows[] = array(
$result -> first_name,
$result -> last_name,
$result -> email,
);
}
return theme('table', array('header' => $header, 'rows' => $rows));
}
When I go to localhost/site/node-1 I get Page not found. I need to do it with node-2, node-3... Can someone help me with this problem?

Answer 1

There are several ways to get current page node id, i.e.:
if (arg(0) == 'node') {
$nid = arg(1);
}
Or
if ($node = menu_get_object()) {
$nid = $node->nid;
}
Then, your format:
localhost/site/node-1
is not drupal's url format, but something custom for you. For that you can first use:
$_SERVER['REQUEST_URI']
to get your custom path. Then, since your path contains only one "-" sign you can use php explode() function to split by that sign and find string part right from the minus sign.
http://php.net/manual/en/function.explode.php
Also, using views is "more natural" ("drupalish") way for getting content from database, but if your assignment is specific...you have to do it that way. But if you have to load a node, then why are you selecting "csvupload" table instead? Drupal's database organization is a bit more complex than you expect. Not all fields you add to your content type are part of one table. It's more that every field you add is different table and you'll need a lot of joins to get the content you need. That's why it's better to use views...