Laravel - Route pattern cannot reference variable name more than once - php

I am working on a legacy code, a project built with Laravel 5.2, and I am getting an error:
Route pattern "/api/v0/taxonomy/{term}/{{term}}" cannot reference variable name "term" more than once.
For this route:
/post/106
This is are my routes:
Route::group(['prefix' => 'api'], function() {
Route::group(['prefix' => 'v0'], function () {
Route::get('route/{a?}/{b?}/{c?}/{d?}', 'DynamicRouteController#resolve');
Route::get('id/{id}', 'DynamicRouteController#resolveId');
Route::get('search', 'SearchController#search');
Route::resource('taxonomy/{term}','TaxonomyController');
});
});
Not sure, why am I getting this error?

When you define a route as a resource then Laravel seems to create all the routes necessary for your resource: GET, POST, PATCH, DELETE.
So you would just need to define Route::resource('taxonomy','TaxonomyController'); or Route::resource('taxonomy.post','TaxonomyPostController');
Check docs

You just need rename your route parameter like this:
Route::resource('taxonomy/{term}','TaxonomyController', ['parameters'
=> ['{term}' => 'your_name']]);
be careful!!!!. you need insert bracket. this will cause wrong result:
Route::resource('taxonomy/{term}','TaxonomyController', ['parameters'
=> ['term' => 'your_name']] );
attention:
'your_name' should not be same as your parameter so this method make wrong
result.
Route::resource('taxonomy/{term}','TaxonomyController', ['parameters'
=> ['{term}' => 'term']});

Related

How to resolve conflict between routes in Laravel

I am trying to have two separate fuctions on my application. One to complete a task and the other to delete but I am getting an error and the form doesn't load: Route [task.delete] not defined. How can I resolve the conflict between the routes? The form only loads when I take the second route out. UPDATE: The delete function now acts the same as the complete function.
Route::patch('/task/{task}',['uses' => 'TaskController#complete', 'as'=> 'task.complete']);
Route::delete('/task/{task}',['uses' => 'TaskController#delete', 'as'=> 'task.delete']);
Controller:
public function delete(Task $task) { $task->delete(); session()->flash('status', 'Task Deleted!'); return redirect('/profile/' . auth()->user()->id); }
In laravel world you should use the delete request type if you try to remove
something from database
so it will be
Route::delete('/task/{task}',['uses' => 'TaskController#delete', 'as'=> 'task.delete']);
Route::patch('/task/{task}',['uses' => 'TaskController#complete', 'as'=> 'task.complete']);
you can read more about it in the Basic Routing section
Use a different verb. You can have multiple routes matching the same pattern as long as they use different methods.
Route::delete('/task/{task}',['uses' => 'TaskController#delete', 'as'=> 'task.delete']);
Route::post('/task/{task}',['uses' => 'TaskController#complete', 'as'=> 'task.complete']);
// or `Route::patch()`, both are valid.
Try to change
Route::patch('/task/{task}',['uses' => 'TaskController#delete', 'as'=> 'task.delete']);
to
Route::delete('/task/{task}',['uses' => 'TaskController#delete', 'as'=> 'task.delete']);

Redirect with id in Laravel

Trying to Redirect to a route:
return Redirect::route('job_view', array('id' =>$id))
->with('succes','Alread Apply for this post');
Error :InvalidArgumentException in UrlGenerator.php line 314
Route [job_view] not defined.
The route Define in Web.php
Route::get('/job_view/{id}','jobseekerController#job_view');
In your web definition you defined Id but when you were calling the redirect to the job_view, you did not add the id to it. Do this instead
return redirect()->to('job_view/'.$id);
you can pass parameter and some status like this
return Redirect::to('job_view')
->with(['id'=>$id,'succes' => 'Alread Apply for this post']);
['id'=>$id,'succes' => 'Alread Apply for this post'] thats mean you pass two parameters first id and second is succes and then you get in view like this
for id: {{$id}}
for succes: {{$succes}}
You need to define your route in your web.php file like that.
Route::get('/job_view/{id}', ['as' => 'job_view', 'uses' => 'jobseekerController#job_view']);
Since you use route() method, you need to define route name:
Route::get('/job_view/{id}', 'jobseekerController#job_view')->name('job_view');
Or:
Route::get('/job_view/{id}', ['as' => 'job_view', 'uses' => 'jobseekerController#job_view']);

Route resource in route group with prefix in Laravel 5

I'm trying to create a route resource in a route group:
Route::group(['middleware' => ['web', 'auth'], 'prefix' => 'template'], function() {
Route::resource('template', 'TemplateController');
Route::get('{template}/assign', 'blabla');
Route::post('{template}/assign', 'blabla');
Route::get('{template}/clone', 'blabla');
Route::get('{template}/customizer', 'blabla');
});
But now I get routes like this: template.template.index, template.template.create, etc.
And when I change the name from Route::resource('template', 'TemplateController'); to Route::resource('/', 'TemplateController');, the route look like this: template..index, template..create, etc.
I do have a solution but then I need to create another route group without prefix.
(TL;DR;) I was wondering how to make the route resource work in a route group with prefix and have the correct route name (template.index, template.create, etc.).
You can use as to define the route name. You can also use it in groups:
Route::group(['as' => 'admin::'], function () {
Route::get('dashboard', ['as' => 'dashboard', function () {
// Route named "admin::dashboard"
}]);
});
I assume you are using Laravel 5.1+ seeing as you are using group prefixes. You can read more in the route section of Laravel:
https://laravel.com/docs/5.1/routing#named-routes
https://laravel.com/docs/5.2/routing#named-routes
Not sure how you should do it in your case (my best guess would be to leave the as empty in the group), so you're going to have to fiddle around. But the principle should be the same.
(My best guess):
Route::group(['middleware' => ['web', 'auth'], 'prefix' => 'template', 'as' => ''], function() {
// stuff
});
If naming the group does not work in your case, you may have to set the as for each route.

Route before getting executed after the route

In my routes.php I have the following group:
Route::group(array('before' => 'checkSomething', 'prefix' => '{lang}'), function() {
echo "1";
Route::get('/', array('as' => 'home', 'uses' => 'HomeController#home'));
});
And the filter attached to it:
Route::filter('checkSomething', function(){
echo "2";
if(!somethingNotRight($something)){
return Redirect::route('index', array()));
}
});
My question is, why is the route inside the route group getting called first, and after that the filter? If I execute this code, I get the following result:
21
But what I want is:
12
Pretty simple isn't it? You are aplying your filter BEFORE the app hits the controller of the route, if you want to apply filter after just change:
Route::group(array('after' => 'checkSomething', 'prefix' => '{lang}')
The code inside the Route::group closure isn't called at the moment the route is executed. It's called very early to register all the routes. The filter is working correctly, but to test that you'd need to put the echo inside the controller

Laravel overrides named route and takes wrong one

I have this defined in my routes.php file
Route::post('gestionAdministrador', array('as' => 'Loguearse', 'uses' => 'AdministradorController#Login'));
Route::post('gestionAdministrador', array('as' => 'RegistrarAdministrador', 'uses' => 'AdministradorController#RegistrarAdministrador'));
And in my login.blade.php file, the form starts as this
{{ Form::open(array('route'=>'Loguearse'))}}
I dont know why when i submit the form takes the second route instead the first one, even though I am pointing to the first one.
There must be a way to go to the same url from two different forms, that is what I want.
If you have two routes with the exact same URI and same method:
Route::post('gestionAdministrador', array('as' => 'Loguearse', 'uses' => 'AdministradorController#Login'));
Route::post('gestionAdministrador', array('as' => 'RegistrarAdministrador', 'uses' => 'AdministradorController#RegistrarAdministrador'));
How can Laravel know the difference between them when something hit /gestionAdministrador?
It will always assume the first one.
The name you set 'as' => 'RegistrarAdministrador' will be used to create URLs based on that route name, only, when something (browser, curl...) hit the URL the only ways to differentiate them is by
1) URL
2) URL parameters (which is basically number 1 plus parameters)
3) Method (GET, POST)
So you could change them to something like:
Route::post('gestionAdministrador/loguearse', array('as' => 'Loguearse', 'uses' => 'AdministradorController#Login'));
Route::post('gestionAdministrador/registrar', array('as' => 'RegistrarAdministrador', 'uses' => 'AdministradorController#RegistrarAdministrador'));
EDIT 2
What you really need to understand is that the name you give to a route ('as' => 'name') will not be part of your url, so this is not something that Laravel can use to differentiate your two URls, this is for internal use only, to identify your routes during the creation of URLs. So, those instructions:
$loguearse = URL::route('Loguearse');
$registrar = URL::route('RegistrarAdministrador');
Would generate exactly the same URL:
http://yourserver.dev/gestionAdministrador
EDIT 1 - TO ANSWER A COMMENT
Redirecting in Laravel is easy, in your controller, after processing your form, in any of your methods you can just:
return Redirect::to('/');
or
return Redirect::route('home');
Having a route like this one:
Route::get('/', array('as' => 'home', 'uses' => 'HomeController#index'));
So, your controller would look like this:
class AdministradorController extends Controller {
public function RegistrarAdministrador()
{
...
return Redirect::route('home');
}
public function Login()
{
...
return Redirect::route('home');
}
}
Actually you have only one route in your route collection, because:
You have following routes declared:
Route::post('gestionAdministrador', array('as' => 'Loguearse', 'uses' => 'AdministradorController#Login'));
Route::post('gestionAdministrador', array('as' => 'RegistrarAdministrador', 'uses' => 'AdministradorController#RegistrarAdministrador'));
Both of these used post method and this is post method:
public function post($uri, $action)
{
return $this->addRoute('POST', $uri, $action);
}
It calls addRoute and here it is:
protected function addRoute($methods, $uri, $action)
{
return $this->routes->add($this->createRoute($methods, $uri, $action));
}
Here $this->routes->add means Illuminate\Routing\RouteCollection::add() and the add() method calls addToCollections() and it is as follows:
protected function addToCollections($route)
{
foreach ($route->methods() as $method)
{
$this->routes[$method][$route->domain().$route->getUri()] = $route;
}
$this->allRoutes[$method.$route->domain().$route->getUri()] = $route;
}
The $routes is an array (protected $routes = array();) and it's obvious that routes are grouped by methods (GET/POST etc) and in each method only one unique URL could be available because it's something like this:
$routes['post']['someUrl'] = 'a route';
$routes['post']['someUrl'] = 'a route';
So, in your case, the last one is replacing the first one and in this case you may use different methods to declare two routes using same URL so it would be in different array, something like this:
$routes['post']['someUrl'] = 'a route';
$routes['put']['someUrl'] = 'a route'; // Route::put(...)
There must be a way to go to the same url from two different forms
Yes, there is a way and it's simply that you have to use the same route as the action of your form and therefore, you don't need to declare it twice.
What you want to do is a bad idea, you shouldn't be logging in and registering from the same route. With that said what you are saying isn't really possible. Routing in Laravel is first come first served. Basically it checks the route until the URI matches one and then calls that method on the controller or executes the callback. Your routes have to be the other way in your routes file. This will be fixed by changing the url.

Categories