Cannot get PHP function to re-run and update array - php

Question

My PHP code looks something like this:
$size=1;
$newoffset=0;
$final=[];
function runQuery()
{
global $newoffset;
global $size;
global $final;
$SECRET_KEY = 'XXX';
$s = hash_hmac('sha256','/api/v2/tags?limit=100&offset='.$newoffset.'-', $SECRET_KEY, false);
$curl = curl_init();
$headers = array();
$headers[] = 'Accept: application/json';
$headers[] = 'Content-Type: application/json';
$headers[] = "RT-ORG-APP-CLIENT-ID: XXX";
$headers[] = "RT-ORG-APP-HMAC: ". $s;
curl_setopt_array($curl, array(
CURLOPT_URL => 'api/v2/tags?limit=100&offset='.$newoffset,
CURLOPT_HTTP_VERSION => CURL_HTTP_VERSION_1_1,
CURLOPT_CUSTOMREQUEST => "GET",
CURLOPT_RETURNTRANSFER => true,
CURLOPT_HTTPHEADER => $headers,
));
$response = curl_exec($curl);
$err = curl_error($curl);
curl_close($curl);
if ($err) {
echo "cURL Error #:" . $err;
} else {
$array = json_decode( $response, true );
$results = $array['data'];
//print_r($results); This returns correctly
$size = sizeof($array['data']); //size of array
$result = array();
if ($size>0){
//print_r($results); This also returns correctly
$newoffset += 100;
foreach($results as $member) {
$result[] = array(
'tag_name' => $member['name'],
'tag_id' => $member['id'],
'tag_public_id' => $member['public_id'],
);
}
$final['all_tags'] = $result;
}
}
}//end function
if($size>0){
runQuery();
}else{
echo json_encode($final);
}
What this is supposed to do is run the curl and if it returns results then push those results into $final. If there are results, then increase the value of a variable (newoffset) so that it can be used in the curl request. This is because I can only get 100 results at a time and need to do offset as many times as necessary to get them all.
If the size of what's returned is 0, then stop and echo the results.
However, this returns nothing.
I'm thinking I have a global variable problem.
Note that I know the query works if I remove all the conditionals and functions, so that isn't the issue.
Any suggestions on how to fix?

Answer 1

Your runQuery function is running only once because you're calling it only once. Execution does not continue at the line where the function declaration ends, it continues where the function was called, which in your case is the end of your script.
You'll have to move the
if($size>0){
runQuery();
}else{
echo json_encode($final);
}
part into the function and just call runQuery once.
Also, using global variables is discouraged because it could lead to clashes with other code. It's better to use function parameters and return values.