MYSQL DELETE multiple row doesnt work - php

Question

This is delete.php
<?php
if(isset($_GET['id']) && !empty($_GET['id']))
{
$id = $_GET['id'];
$servername = "localhost";
$username = "root";
$password = "";
$dbname = "test";
// Create connection
$conn = new mysqli($servername, $username, $password, $dbname);
// Check connection
if ($conn->connect_error) {
die("Connection failed: " . $conn->connect_error);
}
$sql = "DELETE FROM table WHERE memberid IN ('".$id."' )";
if ($conn->query($sql) === TRUE) {
echo "Record updated successfully" ;
} else {
echo "Error updating record: " . $conn->error;
}
$conn->close();
}
?>
this is home.php
$conn = new mysqli($servername, $username, $password, $dbname);
// Check connection
if ($conn->connect_error) {
die("Connection failed: " . $conn->connect_error);
}
$sql = "select memberid from table group by memberid having count(*) > 5";
$result = $conn->query($sql);
if ($result->num_rows > 0) {
// output data of each row
while($row = $result->fetch_assoc()) {
echo "Member ID: " . $row["memberid"]. " | <a href='javascript:void(0);' onClick='deleteId(".$row["memberid"].")'>reset</a><br>";
}
} else {
echo "0 results";
}
$conn->close();
<script>
function deleteId(id)
{
var xmlhttp = new XMLHttpRequest();
xmlhttp.onreadystatechange = function() {
if (xmlhttp.readyState == 4 && xmlhttp.status == 200)
{
alert(xmlhttp.responseText);
}
};
xmlhttp.open("GET", "delete.php?id=" +id, true);
xmlhttp.send();
//window.location.reload();
}
</script>
I'm trying to delete multiple row in a table by onclick from home.php unfortunately it doesnt work at all.
in the table row recorded many same memberid, so i'm trying to call by memberid and delete all of them in 1click
I'm new in php and mysql.
Thanks for the help.

Answer 1

$sql = "DELETE FROM table WHERE c ='$id'";

Answer 2

Try this:
$idArr = explode(",", $id);
$idStr = implode("','", $idArr);
$sql = "DELETE FROM table WHERE c IN ('$idStr' )";
Also, in your client side code,
Make sure that the id in deleteId() is alerting 012345 instead of 12345. Otherwise, convert the integer to string before calling deleteId().

Answer 3

You are sending in one id, so no need for using IN(), normal id = ? will delete all rows with that id. But you need to use bind parameters to stop someone from sending in something like 1 or 1=1 to delete all the rows in your table, don't trust the input even if it is sent from your javascript