laravel destroy just deletes last added stuff - php

Question

I am a Laravel newbie. While writing and testing my code, I noticed that my destroy method isn't working right anymore and I cannot find the mistake I've made. So I hope you can help me out.
Whats my (software) target? I want to manage "projects". Every project has many reports. So I got a page with all created projects and I got a page with all reports listed in a table with buttons for "modify" and "delete". I finished all the CRUD stuff for projects and reports, when I recognized that, if I am hover over the delete-button of a report or project, the right ID of the chosen report or project is shown. If I am hitting the delete-button a dialog plopps up and a message is shown: "Do you really want to delete..." with "yes" and "no" buttons. So if I am pressing the "yes"-button Laravel is going to delete the last added database entry.
Even the projects as the reports too got their own controller. But both are using the same _messages.php. I think, that my mistake is in that file.
Excerpt from _messages.php:
#if(Session::has('sweet_alert.confirmDeleteReport'))
<div class="alert alert-warning" role="alert">
<button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">×</span></button>
<div class="row">
<div class="col-xs-12">
<strong>Achtung!</strong> {{Session::get('sweet_alert.confirmDeleteReport')}}
</div>
</div>
<div class="row">
<div class="col-md-3 col-md-offset-8">
<a class="btn btn-danger" href="{{ route('reports.destroy', $report->id) }}" title="Löschen" data-token="{{csrf_token()}}" data-method="delete">Löschen</a>
<a class="btn btn-default" data-dismiss="alert">Abbrechen</a>
</div>
</div>
</div>
#endif
Excerpt from reportcontroller.php:
public function destroy(Report $report)
{
$report->delete();
Session::flash('sweet_alert.success','Der Bericht vom ' . $report->date . ' mit der Berichtsnummer ' . $report->reportNumber . ' wurde erfolgreich gelöscht.');
return redirect()->route('reports.index');
}
public function delete(Report $report) {
Session::flash('sweet_alert.confirmDeleteReport', 'Soll der Bericht vom ' . $report->date . ' mit der Berichtsnummer ' . $report->reportNumber . ' wirklich gelöscht werden? Dieser Vorgang kann nicht rückgängig gemacht werden.');
return redirect()->route('reports.index');
}
Might there be the fault within the session? I flushed the cache by executing php artisan config:cache but with no luck. Every idea is welcome.
Greetings

Answer 1

If I understand correctly you have a page which lists all reports. Each report has a delete button, and that button route maps to the delete() method you include above. That method flashes a msg to the session, and reloads your report index.
Now on your report index, all reports are listed again, probably inside something like #foreach ($reports as $report). At the bottom of the page, you have the extract you have shown. This uses $report->id, which on this page, after looping through all $reports, is just the last report in that collection. So all it will do is delete the last report.
There are a few solutions I can see:
1) Flash the id of the report you want to delete along with your message in the delete() method. I am not familiar with sweet_alert but can you flash an array, your msg and the id? Something like:
Session::flash('sweet_alert.confirmDeleteReport', [
'id' => $report->id,
'message' => 'Soll der Bericht ...'
]);
And then of course use that id in your alert:
<a class="btn btn-danger" href="{{ route('reports.destroy', Session::get('sweet_alert.confirmDeleteReport.id')) }}" ... </a>
Maybe the syntax is wrong, but I am assuming flashing an array is possible.
2) The way I usually do this kind of thing is use Javascript to populate the alert/modal/whatever with the required data when you click the delete button in the table. Eg your delete buttons (in the main table/list) could have a data-id attribute:
Delete
And some Javascript (pseudo code, implementation depends on how you have things set up):
$('a.delete').on('click', function(e) {
// Prevent the default behaviour of clicking a link
e.preventDefault();
// Find the id of the report clicked
var id = $(this).data('id');
// Update the href of the alert button so it will delete *that* report
$('div.alert a.danger').attr('href', 'reports/' + id);
// ... code to display the alert/modal
});
This way you avoid the page reload to get to your alert/modal. Note this makes your delete() method obsolete, it would not be used any more.
UPDATE
If you need to pass some variable from your view/controller to your external JS file, you can do something like this:
In the view
<script>
var url = "{{ route('reports.destroy', Session::get('sweet_alert.confirmDeleteReport.id')) }}";
</script>
In your external JS (must be loaded after the above inline script)
$('div.alert a.danger').attr('href', url);