Multiple file upload method in PHP OOP - php

Question

I am trying to build a method in PHP to upload multiple files into and insert the files names into a MySQL database.
I am trying to build this based on PHP OOP.
Multiple issues I am facing and I have been stucking with this for more than 2 weeks.
First: the method is only inserting 1 row into the database even if I selected multiple files in the form.
Second: the method is not getting the files name, so even if it inserts only 1 row, it inserts an empty row.
Here is the images class:
<?php
class Images extends Crud{
protected static $db_table = "images";
protected static $table_fields = array("id", "image_url", "property_id", "date");
public $id;
public $image_url;
public $property_id;
public $date;
public $filename;
public $tmp_path = array();
public $upload_dir = "images";
public $errors = array();
public $upload_errors_array = array(
UPLOAD_ERR_OK => "There is no error.",
UPLOAD_ERR_INI_SIZE => "The file size exceeds the upload_max_filesize",
UPLOAD_ERR_FORM_SIZE => "The file upload exceeds the MAX_FILE_SIZE",
UPLOAD_ERR_PARTIAL => "The uploaded file was only partially uploaded",
UPLOAD_ERR_NO_TMP_DIR => "Missing a temporary folder",
UPLOAD_ERR_CANT_WRITE => "Failed to write file on desk",
UPLOAD_ERR_EXTENSION => "A PHP extension stopped the file upload"
);
public function image_path(){
return $this->upload_dir.DS.$this->image_url;
}
public function set_files($file){
if(empty($file) || !$file || !is_array($file)){
$this->errors[] = "There was no file uploaded here";
return false;
}else{
$this->image_url = $file['name'];
$this->tmp_path = $file['tmp_name'];
}
}
public function new_images(){
foreach ($_FILES['images'] as $file) {
$this->set_files($file);
$this->property_id = "1";
$this->date = date('Y-m-d H:i:s');
$target_path = $this->upload_dir . DS . $this->image_url;
move_uploaded_file($this->tmp_path, $target_path);
if($this->create()){
print_r($file);
var_dump($file);
return true;
}
}
}
}
?>
print_r is showing the following:
Array ( [0] => download (1).jpg [1] => download (2).jpg [2] => download (3).jpg [3] => download.jpg )
and var_dump is showing the following:
array(4) { [0]=> string(16) "download (1).jpg" [1]=> string(16) "download (2).jpg" [2]=> string(16) "download (3).jpg" [3]=> string(12) "download.jpg" }
More details:
Here is the main class which the images class extends from:
<?php
class Crud{
protected static $db_table;
public static function find(){
return static::find_query("SELECT * FROM " . static::$db_table . "");
}
public static function find_limit($limit){
return static::find_query("SELECT * FROM " . static::$db_table . " LIMIT " . $limit. "");
}
public static function find_id($id){
global $database;
$the_result_array = static::find_query("SELECT * FROM " . static::$db_table . " WHERE id='$id'");
return !empty($the_result_array) ? array_shift($the_result_array) : false;
}
public static function find_query($sql){
global $database;
$set_result = $database->query($sql);
$object_array = array();
while($rows = mysqli_fetch_array($set_result)){
$object_array[] = static::instantiation($rows);
}
return $object_array;
}
public static function instantiation($records){
$calling_class = get_called_class();
$object = new $calling_class;
foreach ($records as $attribute => $value) {
if($object->has_attribute($attribute)){
$object->$attribute = $value;
}
}
return $object;
}
private function has_attribute($attribute){
$object_properties = get_object_vars($this);
return array_key_exists($attribute, $object_properties);
}
protected function properties(){
$properties = array();
foreach (static::$table_fields as $field){
if(property_exists($this, $field)){
$properties[$field] = $this->$field;
}
}
return $properties;
}
protected function clean_properties(){
global $database;
$clean_properties = array();
foreach ($this->properties() as $key => $value) {
$clean_properties[$key] = $database->escape_string($value);
}
return $clean_properties;
}
public function create(){
global $database;
$properties = $this->clean_properties();
$sql = "INSERT INTO ".static::$db_table."(". implode(",", array_keys($properties)).")";
$sql .= "VALUES ('". implode("','", array_values($properties)) ."')";
if($database->query($sql)){
$this->id = $database->last_id();
print_r($sql);
var_dump($sql);
return true;
}else{
return false;
}
}
}
?>
print_r is showing the following result:
INSERT INTO images(id,image_url,property_id,date)VALUES ('','','1','2017-10-20 20:24:05')
var_dump is showing the follwoing:
string(89) "INSERT INTO images(id,image_url,property_id,date)VALUES ('','','1','2017-10-20 20:24:05')"
Furthermore, here is the HTML page:
<?php include_once "admin/head.php"; ?>
<?php if(!$session->is_signed_in()) {redirect("../index");} ?>
<?php
if(isset($_POST['submit'])){
$images = new Images();
$images->new_images();
}
?>
<div class="container">
<div class="row">
<div class="col-xs-12 col-sm-6">
<form class="form-horizontal" action="" method="post" enctype="multipart/form-data">
<div class="form-group">
<label for="images" class="control-label">نص الصورة البديل</label>
<input type="file" class="form-control" name="images[]" id="images" multiple="">
</div>
<input type="submit" name="submit" value="Submit" class="btn btn-primary">
</form>
</div>
</div>
</div>
<?php include "admin/footer.php"; ?>

Answer 1

Your loop through $_FILES['images'] is wrong. Each element of this is not all the properties for a single file. Each element is a different property, which contains an array of those properties of all the uploads. E.g. $_FILES['images']['name'] is an array of all the names. So you need to loop through one of these properties, and then get the corresponding elements of the other properties.
foreach ($_FILES['images']['name'] as $index => $name) {
$file = array('name' => $name, 'tmp_name' => $_FILES['images']['tmp_name'][$index]);
$this->set_files($file);
...
}