How to fix 'Creating default object from empty value' in Laravel? - php

Question

In blade I have this code:
#foreach ($employees as $key => $employee)
<tr id="{{$employee->id}}">
<td class="visibleemployee tdcenter">
<form action="{{route('admin.employees.cambiarVisible',$employee->id)}}">
<button type="button" id="buttonchangevisible" data-id="{{$employee->id}}">
#if ($employee->public == '1')
<i class="fa fa-check" aria-hidden="true" id="margindataemployee" class="cambiarsiporno"></i>
#else
<i class="fa fa-times" aria-hidden="true" id="margindataemployee"></i>
#endif
</button>
<input type="hidden" name="_token" value="{{Session::token()}}">
</form>
</td>
</tr>
#endforeach
When I click the bottom the Ajax function is executed:
$("#buttonchangevisible").click(function(e){
e.preventDefault();
var button = $(this);
var id = button.data('id');
var formData = new FormData($(this)[0]);
$.ajax({
url:'employee/cambiarVisible/' + id,
type: 'PUT',
data: formData,
success: function() {
location.reload();
},
cache: false,
contentType: false,
processData: false
});
return false;
});
And call to the next method:
public function cambiarVisible(Request $request, $id)
{
$employee = Worker::find($id);
if ($employee->public = 0){
DB::table('workers')->where('id',$id)
->first()
->$employee->public = 1;
}
else{
$employee->public = 0;
}
$employee->save();
}
Now don't appear any error, if I click in first row, make the call but don't the update of visible.
But if I click in other row, don't make the call.

Answer 1

I wrote a similar piece of code.
I generated the form dynamically, then called some JavaScript/jQuery.
Code to generate the button:
<button class="btn btn-danger btn-block deleteUserBtn" data-name="{{ $user->name }}" data-id="{{ $user->id }}" data-type="delete" onclick="return false;"><i class="glyphicon glyphicon-trash"></i> Delete</button>
Then using the following code, I executed the ajax call. The reason the click event is attached to the body is because there are multiple delete buttons (this was for an user overview with multiple delete buttons, one for every user). And these buttons can be generated with jQuery, the click event will not fire if you bind to the buttons.
$('body').on('click', '.deleteUserBtn', function() {
var button = $(this) // Button that triggered the event
var id = button.data('id');
var name = button.data('name');
var csrf = $('input[name=_token]').val(); // This token is already on the page, you need a token to prevent csrf
if( confirm('Are you sure you want to delete: ' + name + '?') ) {
var url = "{{ route('overview.users.destroy', ':id') }}";
url = url.replace(':id', id);
$.ajax({
method: "DELETE",
url: url,
data: {
'id': id,
'_token': csrf
},
}).done(function(response) {
// Check if it is successful
if(response == 'deleted') {
// Reload page
location.reload();
} else {
alert('error');
console.log(response);
}
}).fail(function(response) {
alert('error 2');
console.log(response);
});
}
});
As you can see I just passed the id as a parameter.
In your case, to update the user, you can just use the following piece of code:
public function cambiarVisible(Request $request, $id)
{
$employee = Worker::findOrFail($id);
$employee->public = ($employee->public == 1) ? 0 : 1;
$employee->save();
}

Answer 2

Looks like your form has a ajax submit which is using employee/cambiarVisible/{id} as URL. since the id wildcard is supposed to be a php variable (cannot see the variable in JS), it's not being passed to the controller.
Try something like
var id = {!! json_encode($employee->id) !!};
Then change the url as
url:'employee/cambiarVisible/' + id,