[SOLVED]
I am having a problem in function in my controller. I want to upload a single image twice and save it in the same directory but have different file names.
Here's my form(view.php):
<form action="<?php echo base_url("process/testFunction"); ?>" enctype="multipart/form-data" method="post">
<input type="file" name="file_data" size="50" required>
<input type="hidden" name="user_id" value="<?php echo $this->session->userdata('user_id'); ?>" readonly>
<input type="hidden" name="purpose" value="Picture" readonly>
<input type="submit" value="Save Changes">
</form>
controller.php:
function testFunction(){
$userID = $this->input->post('user_id');
$purpose = $this->input->post('purpose');
$randomText = time();
if($purpose == "Picture"){
$uploadPath = "./uploads/images/";
$allowedTypes = "jpg|jpeg|png";
$maxSize = 10000000;
$fileName = "PP_".$userID.".jpeg";
$fileName2 = "PP_".$userID."_".$randomText.".jpeg"; //for backup
}
$config = array(
'upload_path' => $uploadPath,
'allowed_types' => $allowedTypes,
'max_size' => $maxSize,
'file_name' => $fileName
);
$configClone = array(
'upload_path' => $uploadPath,
'allowed_types' => $allowedTypes,
'max_size' => $maxSize,
'file_name' => $fileName2
);
$this->load->library('upload', $config);
$this->load->library('upload', $configClone);
if($this->upload->do_upload('file_data')){
echo "Uploaded";
}else{
echo $this->upload->display_errors();
}
}
What is currently happening in my code is. Although it uploads 2 same images. The file name with "Random Text" is not working.
[Solution]: controller file. I modified some lines.
Reference: Javier's answer below
$this->load->library('upload', $config);
if($this->upload->do_upload('file_data')){
unset($this->upload);
$this->load->library('upload', $configClone);
$this->upload->do_upload('file_data');
echo "Uploaded";
}else{
echo $this->upload->display_errors();
}
Loading the upload library twice in a row, even with different configuration arrays, won't do anything. Codeigniter will ignore the second $this->load->library(); statement if the library is already on memory. This is intended to prevent conflicts, race conditions, etc.
You'd need to:-
load the first instance of the library
process the first upload
unload the first instance of the library
load the second instance of the library
process the second upload
Point number 3 could for example be achieved using unset($this->upload); after processing the first upload.
Remove this line
$this->load->library('upload', $configClone);
Change
if($this->upload->do_upload('file_data')){
$this->upload->initialize($configClone);
if($this->upload->do_upload('file_data')){
echo "Uploaded";
}else{
echo $this->upload->display_errors();
}
}else{
echo $this->upload->display_errors();
}
Explanation: Javier Larroulet's answer
Related
I have a problem uploading a file in my form using CodeIgniter 4 and I can't find what's wrong. Can you help me, please? The name of the file is ok, the problem is that it doesn't move the file in the specified directory because I get this error: Call to a member function move() on null.
WRITEPATH has the value: C:\xampp\htdocs\myproject\writable\
The part of the view where I upload looks like this :
<div class="card-body">
<label for="exampleInputFile">Fisier</label>
<div class="form-group">
<div class="input-group">
<div class="custom-file">
<input type="file" class="custom-file-input" name="customFile" id="customFile" required>
<label class="custom-file-label" for="exampleInputFile">Alege Fisierul</label>
</div>
</div>
</div>
</div>
And the part of the controller function where I try to move the file in a specific folder looks like this :
$img = $this->request->getFile('customFile');
$img->move(WRITEPATH . 'uploads');
I take the name of the file with this : $this->request->getVar('customFile')
Thank you !
This worked in Codeigniter 4:
$file = $this->request->getFile('file');
if (!$file->isValid()) {
return $this->fail($file->getErrorString());
}
$file->move(ROOTPATH . 'public\uploads\documents');
$name = $file->getName();
Thank you!
In Controller Like this...
$config['upload_path'] = './upload/painting/';
$config['allowed_types'] = 'jpg|png|jpeg'; // here you want to define file type
$config['max_width'] = '250';
$config['max_height'] = '300';
$config['encrypt_name'] = TRUE;
$this->load->library('upload', $config);
// $this->upload->do_upload('profile_pic');
if ($this->upload->do_upload('ptn_url')) {
$data = array('upload_data' => $this->upload->data());
// print_r($data);
$_POST['ptn_url'] = "upload/painting/" . $data['upload_data']['file_name'];
$_POST['user_id'] = $this->session->user_data['user_id'];
in routes.php file which is located at config folder
you need to define path for store image
like this...
$route['upload-image'] = 'user';
$route['store-image'] = 'user/add';
$route['painting/(:num)'] = 'painting';
for More Reference about File Upload Visit CodeIgniter 3 File Upload
I hope this is helps to you...
Thank You...
I'm trying to add a file upload function in my website using codeigniter's upload library.
here's my view file (display.php):
<html>
<body>
<form method="post" action="" enctype="multipart/form-data">
<input type="file" name="filename" />
<input type="submit" name="submit" id="submit" value="submit"/>
</form>
</body>
</html>
and here's the controller:
public function testupload()
{
if ( ! empty($_FILES))
{
echo 'start upload';
$config['upload_path'] = './assets/img/tempfile/';
$this->load->library('upload');
$this->upload->initialize($config);
if ( ! $this->upload->do_upload('filename'))
{
echo 'error!';
}
else
{
echo 'success!';
}
echo 'end upload';
}
$this->load->view('display', $this->data);
}
but the code seems to stop after $this->upload->initialize($config); the file was not uploaded, and there was no message at all. only the 'start upload' message appeared; the echo 'success' , echo 'error' , and echo 'end upload' do not appear.
why is that? can anyone help me??
Late from party, but maybe this can help somebody with same problem. Please try this:
Views:
<?php echo form_open_multipart('test/upload');?>
<input type="file" name="photo">
<?php echo form_close();?>
Controller:
class Test extends CI_Controller {
function upload() {
$config = array(
'upload_path' => './assets/upload/',
'allowed_types'=> 'gif|jpg|png',
'encrypt_name' => TRUE // Optional, you can add more options as need
);
$this->load->library('upload', $config);
if ( ! $this->upload->do_upload('photo')) {
echo '<pre>';
print_r($this->upload->display_errors());
exit();
} else {
echo '<pre>';
print_r($this->upload->data());
exit();
}
}
}
Inside views i recomended use this function form_open_multipart('ctrl/method') but if you prefer using HTML5 forms, just be sure correct the attributes in form like this.
<form action="<?=site_url('ctrl/method')?>" enctype="multipart/form-data" method="post" accept-charset="utf-8">
<input type="file" name="photo">
</form>
More preferences in $config['..'] can you find in documentation CodeIgniter https://codeigniter.com/user_guide/libraries/file_uploading.html
Try like this....
public function testupload()
{
if ( ! empty($_FILES))
{
echo 'start upload';
$config['upload_path'] = './assets/img/tempfile/';
$this->load->library('upload',$config);
if ( ! $this->upload->do_upload('filename'))
{
$error = array('error' => $this->upload->display_errors());
$this->load->view('display', $error); //loads the view display.php with error
}
else
{
echo 'success!';
}
echo 'end upload';
$data = array('upload_data' => $this->upload->data());
$this->load->view('display', $data); //loads view display.php with data
}
}
change from
$config['upload_path'] = './assets/img/tempfile/';
to
$config['upload_path'] = 'assets/img/tempfile/';
i check this code this work perfect
simply add this line
$config['allowed_types'] = 'png|gif|jpg|jpeg';
$config['max_size'] = '7000';
after this
$config['upload_path'] = './assets/img/tempfile/';
or you can also set this in view page
action="<?php echo base_url('YourController/testupload');?>"
this is due to php server version and it's option.
1).go to cpanel account
2).click "select php version", in the software section.
3).tap the "fileinfo" chexbox in the php option and save.
now you can upload file perfectly.
Same issue as described. I have fixed it using the following: Open the file system/libraries/Upload.php go to function validate_upload_path() and add the command return TRUE; as a last line inside this function. Save and try again.
use this for image upload:
$valid_extensions = array('jpeg', 'jpg', 'png');
if ($_FILES['filename']['error'] == 0) {
$img = $_FILES['filename']['name'];
$tmp = $_FILES['filename']['tmp_name'];
$ext = strtolower(pathinfo($img, PATHINFO_EXTENSION));
if (in_array($ext, $valid_extensions)) {
$path = "./assets/img/tempfile/" . strtolower($img);
if (move_uploaded_file($tmp, $path)) {
$_POST['filename'] = $path;
}
}
}
use insert query to insert file :
$this->db->insert('table_name', $_POST);
Having the same problem on macOS. It seems that if you are not the "main" user of your laptop/pc, the default permission is "Read Only". You must change it to "Read & Write".
Right click on the folder
Get Info
Sharing and permissions
Change 'Read Only' to 'Read & Write'
add allowed file type parameter in config
$config['allowed_types'] = 'gif|jpg|png';
your code is missing the following,
$this->load->library('upload',$config);
Recorrect it by rewriting the above code.
I am uploading the multiple images in codeigniter when I try to upload more than 10 images it shows blank screen without any error but same code worked when I upload the 10 or less than 10 images. I unable to find out whats going wrong please help.
I also set the following settings in php.ini:
upload_max_filesize = 128M
max_file_uploads = 50
Here is my html code:
<form method="post" role="form" enctype="multipart/form-data" action="<?php echo base_url();?>admin/allbums/add_new">
<input type="file" name="myfile[]" multiple="multiple">
<input type="hidden" name="user_id" value="<?php echo $user_id;?>">
</form>
here is code in my controller:
public function add_new() {
$config['upload_path']="./uploads/";
$config['allowed_types']='*';
$config['encrypt_name'] = TRUE;
$config['overwrite'] = false;
$this->load->library('upload', $config);
if($this->upload->do_multi_upload("myfile")) {
$file_arr = $this->upload->get_multi_upload_data();
$arr_lenth = count($file_arr);
$user_id = $_POST['user_id'];
for($i=0;$i<=$arr_lenth-1;$i++) {
$data[] = array(
'img_name' => $file_arr[$i]['file_name'],
'size' => $file_arr[$i]['file_size'],
'user_id' => $user_id
);
}
$this->allbum_model->insert_allbum($user_id,$data);
$data['success'] = '<div class="note note-success"> Allbum Added Successfully!</div>';
$data['user_id'] = $user_id;
$this->load->view('admin/allbum', $data);
} else { // else if file not uploaded correctly
echo $this->upload->display_errors();
}
you should also add post_max_size to php.ini so you can be able to send the data
;Maximum allowed size for uploaded files.
upload_max_filesize = 128M
;Must be greater than or equal to upload_max_filesize
post_max_size=128M
When I am running on localhost, it is fine. After uploaded on server.one error thrown-i.e.
The upload destination folder does not appear to be writable.
This is my controller-
function do_upload()
{
$path = './uploads/';
chmod($path,0777);
$config['upload_path'] = $path;
$config['allowed_types'] = 'gif|jpg|png';
$config['max_size'] = '1000';
$config['max_width'] = '1024';
$config['max_height'] = '768';
$config['encrypt_name'] = TRUE;
$this->load->library('upload', $config);
if ( ! $this->upload->do_upload())
{
$error = array('error' => $this->upload->display_errors());
$this->load->view('upload_form', $error);
}
else
{
$this->load->library('form_validation');
$data = array('upload_data' => $this->upload->data());
$pic_path= 'uploads/'.$data['upload_data']['file_name'];
$this->form_validation->set_rules('txt_title','Title','trim|required|xss_clean');
$this->form_validation->set_rules('category', 'Select Category', 'callback_select_validate');
$this->form_validation->set_rules('description','Description','trim|required|xss_clean');
if($this->form_validation->run() == FALSE)
{
redirect('upload');
}
else{
$title =mysql_real_escape_string(htmlentities($this->input->post('txt_title')));
$category = $this->input->post('category');
$description = mysql_real_escape_string(htmlentities($this->input->post('description')));
$this->load->model('user');
$suc_mesg=$this->user->insertPic($pic_path,$category,$title,$description);
$this->load->view('upload_success', $suc_mesg);
}
}
}
This is my view page-
<?php
echo $error;
echo form_fieldset('Upload Category Pics');
echo form_open_multipart('upload/do_upload');
echo '</br>';
echo form_label('Title','title');
echo '<input type="text" size="30" name="txt_title" placeholder="Enter title to pic"/>';
echo '</br></br>';
echo form_label('Choose Category Pics', 'category');
$options = array(
'null' => '--Please Select--',
1 => 'Technology',
3 => 'Entertainment',
2 => 'Politics',
4 => 'Sports'
);
echo form_dropdown('category', $options, 'category');
echo "<br></br>";
echo form_label('Description','description');
$data = array(
'name' => 'description',
'id' => 'description',
'placeholder' => 'Enter description',
'rows' => '5',
'cols' => '40',
);
echo form_textarea($data);
echo '</br></br>';
echo form_label('Browse Pics','pics');
echo '<input type="file" name="userfile" size="20" />';
echo "<br></br>";
echo '<input type="submit" value="upload" />';
echo '</form>';
echo form_fieldset_close();
?>
I'm unable to find my bug,where exactly am wrong. is there anybody ready to help me plz?
If the folder is for loading files by users than permisision 777 is required.
It's up to you to validate what files are loaded through upload script. Also you can use .htaccess to alow or not alow certain files to be executed from that directory.
The documentation for upload in codeigniter it's pretty simple and intuitive. Also here you can look at some ways to validate the type of files that are uploaded http://ellislab.com/codeigniter/user-guide/libraries/file_uploading.html
I changed my uploads folder on web server as writable, so now it seems working.
Of course by that I mean I'm doing something wrong with it. I posted a question before similar to this one and got some answers. Well based on those answers (I wasn't using CI's class now I am) I'm having a new problem. Any help would be appreciated.
PHP
public function do_upload () {
$scopeId = $this->input->get('id');
$config['upload_path'] = './uploads/';
$config['allowed_types'] = 'gif|jpg|pdf';
$config['max_size'] = '1000';
$config['max_width'] = '1024';
$config['max_height'] = '768';
$this->load->library('upload', $config);
if ( ! $this->upload->do_upload()) {
$error = array('error' => $this->upload->display_errors());
echo 'error'; <----- This is what is showing up
// uploading failed. $error will holds the errors.
} else {
$data = array('upload_data' => $this->upload->data());
// uploading successfull, now do your further actions
redirect(site_url('discovery/scopeDetails?scID='.$scopeId.''));
}
echo $error;
}
HTML Form
<div id="upload">
<?=form_open_multipart('discovery/do_upload');?>
<input name="userfile" size="40" type="file" />
<input type="submit" value="Upload" />
</div>
With the form i usually would just use straight HTML but I tried doing EXACTLY what http://codeigniter.com/user_guide/libraries/file_uploading.html told me to do.
Most likely the problem is your upload folder. Make sure it exists and set it's permissions to 777.
If that's not the problem then use print_r($error) to see what's wrong.
I had never experienced anything like that. My friend suggested to replace upload.php a new library with the old. so try it:
folder path "system/libraries/".
download and replace the file "upload.php"
http://www.4shared.com/file/BZci40l8/Upload.html
good luck! :D