why does file_put_contents insert 2 rows into json file? - php

Question

I have a JSON file as my database, I wrote this function for creating a new user row into the file:
function create(array $data)
{
$tableFilePath = __DIR__ . "/storage/jsondb/users.json";
$fileData = json_decode(file_get_contents($tableFilePath));
$fileData[] = $data;
$fileDataJson = json_encode($fileData);
file_put_contents($tableFilePath, $fileDataJson);
}
create(['id' => rand(1, 100), 'name' => 'user' . rand(1, 100)]);
The problem is that when I call this function, I expect it inserts 1 row but it inserts 2 rows into the JSON file.
UPDATE:
my JSON file before running the code is an empty array:
[]
After running the code:
[{"id":28,"name":"user-3"},{"id":68,"name":"user-78"}]
as you can see, I executed the code one time, but it inserted two records into the JSON file.
UPDATE-3
I summarized my code because I wanted others can read it easily.
now it's my whole class that I wrote.
here is my interface:
interface CrudInterface
{
public function create(array $data) : int;
public function find(int $id): object;
public function get(array $columns,array $where):array;
public function update(array $data,array $where):int;
public function delete(array $where):int;
}
here I have abstract class BaseModel that implements CrudInterface:
abstract class BaseModel implements CrudInterface
{
protected $connection;
protected $table;
protected $pageSize = 10;
protected $attributes = [];
protected $primaryKey = 'id';
protected function __construct()
{
# if mysql => set mysql connection
}
protected function getAttribute($key)
{
if(!$key || array_key_exists($key, $this->attributes)){
return null;
}
return $this->attributes[$key];
}
}
here JsonBaseModel that extends BaseModel:
class JsonBaseModel extends BaseModel
{
private $dbFolder;
private $tableFilePath;
public function __construct()
{
$this->dbFolder = BASE_PATH . 'storage/jsondb/';
$this->tableFilePath = $this->dbFolder . $this->table . '.json';
}
private function readTable()
{
$fileData = json_decode(file_get_contents($this->tableFilePath));
return $fileData;
}
private function writeTable($fileData){
$fileDataJson = json_encode($fileData);
file_put_contents($this->tableFilePath, $fileDataJson);
}
public function create(array $newData): int
{
$fileData = $this->readTable();
$fileData[] = $newData;
$this->writeTable($fileData);
return $newData[$this->primaryKey];
}
}
and here I have class User that extends JsonBaseModel:
class User extends JsonBaseModel
{
protected $table = 'users';
}
then I made an instance of User class and call it's create() function here:
$data = ['id' => rand(1, 100),'name' => "user-".rand(1, 100)];
$userModel = new User();
$userModel->create($data);

Answer 1

You're passing in an array with the user details, then adding it to the current contents.
If there is already a entry in your file, you'll then have 2 entries.
Make sure that users.json is empty first.