Querybuilder Eloquent won't delete record from model - php

Question

I tried creating a universal delete function in 3 ways.
function DeleteByID($table, $id){
1. DB::table("$table")->delete("$id");
2. DB::table("$table")->find("$id")->delete();
3. DB::table("$table")->where('id', '=', "$id")->delete();
}
I'm using ajax to send the request to an Ajax Controller class, which sends it to the according controller class of the specific subject. Everything goes fine with the ajax request, it does what it should do. But deleting something from the table doesn't work.
And yes, I am putting the right table names into the $table parameter when I'm calling the DeleteByID($table, $id) function.
Update 1
removed every double "" from the ajax request to the call of the delete function.
DB::table($table)->where('id', '=', $value)->delete();
Is what it is now. Still doesn't work.
Update 2
This triggers the DeleteRole function. This will open a modal, asking if you are sure you want to delete the record. there will be another button with onclick="DeleteRole(this.id, true)" with ofcourse the id send with it.
<a id="{{$role->id}}" onclick="DeleteRole(this.id, false)">
<button class="btn btn-neutral btn-icon btn-round" data-toggle="modal"
id="{{$role->id}}" data-target="#rolesModalDelete">
<i class="material-icons" style="color:rgba(185,14,22,0.81)">clear</i>
</button>
</a>
AJAX Request:
function DeleteRole(id, bool){
let contentModal = $('#DeleteRoleContent');
if(bool === false){
$.ajaxSetup({
headers: {
'X-CSRF-TOKEN': $('meta[name="csrf-token"]').attr('content')
}
});
$.ajax({
url: '/DeleteRole',
type: 'POST',
dataType: "json",
beforeSend: function (xhr) {
const token = jQuery('meta[name="csrf_token"]').attr('content');
if (token) {
return xhr.setRequestHeader('X-CSRF-TOKEN', token);
}
},
data: {
roleID: id,
popup: bool,
},
success: function (data) {
contentModal.empty();
contentModal.append(data);
}
});
}else if (bool === true){
let row = $('#' + id);
$.ajaxSetup({
headers: {
'X-CSRF-TOKEN': $('meta[name="csrf-token"]').attr('content')
}
});
$.ajax({
url: '/DeleteRole',
type: 'POST',
dataType: "json",
beforeSend: function (xhr) {
const token = jQuery('meta[name="csrf_token"]').attr('content');
if (token) {
return xhr.setRequestHeader('X-CSRF-TOKEN', token);
}
},
data: {
roleID: id,
popup: bool,
},
success: function (data) {
row.empty();
}
});
}
}
Update 3
The if statement where it checks if the $_POST['popup'] is true or not, was ignored. Changed it, so the deletion works now. But now the succes handler won't be called. the ajaxrequest returns 200 OK.
public function RoleDelete()
{
if($_POST['roleID']){
if($_POST['popup'] == 0){
$htmlObject = $this->roleController->GetData($_POST['roleID']);
echo json_encode($htmlObject);
} else {
if($_POST['roleID'] !== null) {
$this->db->DeleteByID('rollen', $_POST['roleID']);
} else {
echo json_encode('ID is null');
}
}
} else {
echo json_encode('Geen gegevens gevonden, is het record al verwijderd? AC 256;');
}
}

Answer 1

You should try this
Do not use "" for variable
1. DB::table($table)->delete($id);
2. DB::table($table)->find($id)->delete();
3. DB::table($table)->where('id', '=', $id)->delete();

Answer 2

I apologize if this comes off as a "make sure it's plugged in" kind of answer, but sometimes the simple stuff is the easiest to overlook, especially when you're tunnel-visioned on the code. That said, are you sure your DB credentials actually have delete-permissions?

Answer 3

The if statement where it checks if the $_POST['popup'] is true or not, was ignored. Changed it, so the deletion works now. But now the succes handler won't be called. the ajaxrequest returns 200 OK.
public function RoleDelete(){
if($_POST['roleID']){
if($_POST['popup'] == 0){
$htmlObject = $this->roleController->GetData($_POST['roleID']);
echo json_encode($htmlObject);
} else {
if($_POST['roleID'] !== null) {
$this->db->DeleteByID('rollen', $_POST['roleID']);
} else {
echo json_encode('ID is null');
}
}
} else {
echo json_encode('Geen gegevens gevonden, is het record al verwijderd? AC 256;');
}
}